Title: [212568] trunk/Source/WebCore
- Revision
- 212568
- Author
- commit-qu...@webkit.org
- Date
- 2017-02-17 13:06:30 -0800 (Fri, 17 Feb 2017)
Log Message
Invalidate WebAVSampleBufferStatusChangeListener when MediaPlayerPrivateMediaStreamAVFObjC is deallocated.
https://bugs.webkit.org/show_bug.cgi?id=168488
Patch by Jeremy Jones <jere...@apple.com> on 2017-02-17
Reviewed by Jer Noble.
Fixes periodically crashing test: fast/mediastream/MediaStream-video-element-track-stop.html
WebAVSampleBufferStatusChangeListener has an unretained referecne to MediaPlayerPrivateMediaStreamAVFObjC
that must be invaldated when MediaPlayerPrivateMediaStreamAVFObjC is deallocated.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::~MediaPlayerPrivateMediaStreamAVFObjC):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (212567 => 212568)
--- trunk/Source/WebCore/ChangeLog 2017-02-17 20:54:57 UTC (rev 212567)
+++ trunk/Source/WebCore/ChangeLog 2017-02-17 21:06:30 UTC (rev 212568)
@@ -1,3 +1,18 @@
+2017-02-17 Jeremy Jones <jere...@apple.com>
+
+ Invalidate WebAVSampleBufferStatusChangeListener when MediaPlayerPrivateMediaStreamAVFObjC is deallocated.
+ https://bugs.webkit.org/show_bug.cgi?id=168488
+
+ Reviewed by Jer Noble.
+
+ Fixes periodically crashing test: fast/mediastream/MediaStream-video-element-track-stop.html
+
+ WebAVSampleBufferStatusChangeListener has an unretained referecne to MediaPlayerPrivateMediaStreamAVFObjC
+ that must be invaldated when MediaPlayerPrivateMediaStreamAVFObjC is deallocated.
+
+ * platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
+ (WebCore::MediaPlayerPrivateMediaStreamAVFObjC::~MediaPlayerPrivateMediaStreamAVFObjC):
+
2017-02-17 Antoine Quint <grao...@apple.com>
[Modern Media Controls] Improve handling of live broadcast video
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm (212567 => 212568)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm 2017-02-17 20:54:57 UTC (rev 212567)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm 2017-02-17 21:06:30 UTC (rev 212568)
@@ -180,6 +180,8 @@
destroyLayer();
+ [m_statusChangeListener invalidate];
+
m_audioTrackMap.clear();
m_videoTrackMap.clear();
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
