Title: [212700] trunk/Source/WebCore
- Revision
- 212700
- Author
- [email protected]
- Date
- 2017-02-20 21:51:36 -0800 (Mon, 20 Feb 2017)
Log Message
Remove unnecessary PerformanceEntry virtual methods
https://bugs.webkit.org/show_bug.cgi?id=168633
Patch by Joseph Pecoraro <[email protected]> on 2017-02-20
Reviewed by Ryosuke Niwa.
* page/PerformanceEntry.h:
(WebCore::PerformanceEntry::isResource):
(WebCore::PerformanceEntry::isMark):
(WebCore::PerformanceEntry::isMeasure):
Implement based on the Type.
* page/PerformanceMark.h:
* page/PerformanceMeasure.h:
* page/PerformanceResourceTiming.h:
Remove virtual overrides.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (212699 => 212700)
--- trunk/Source/WebCore/ChangeLog 2017-02-21 05:50:06 UTC (rev 212699)
+++ trunk/Source/WebCore/ChangeLog 2017-02-21 05:51:36 UTC (rev 212700)
@@ -1,3 +1,21 @@
+2017-02-20 Joseph Pecoraro <[email protected]>
+
+ Remove unnecessary PerformanceEntry virtual methods
+ https://bugs.webkit.org/show_bug.cgi?id=168633
+
+ Reviewed by Ryosuke Niwa.
+
+ * page/PerformanceEntry.h:
+ (WebCore::PerformanceEntry::isResource):
+ (WebCore::PerformanceEntry::isMark):
+ (WebCore::PerformanceEntry::isMeasure):
+ Implement based on the Type.
+
+ * page/PerformanceMark.h:
+ * page/PerformanceMeasure.h:
+ * page/PerformanceResourceTiming.h:
+ Remove virtual overrides.
+
2017-02-20 Youenn Fablet <[email protected]>
[WebRTC][Mac] Activate libwebrtc
Modified: trunk/Source/WebCore/page/PerformanceEntry.h (212699 => 212700)
--- trunk/Source/WebCore/page/PerformanceEntry.h 2017-02-21 05:50:06 UTC (rev 212699)
+++ trunk/Source/WebCore/page/PerformanceEntry.h 2017-02-21 05:51:36 UTC (rev 212700)
@@ -61,9 +61,9 @@
static std::optional<Type> parseEntryTypeString(const String& entryType);
- virtual bool isResource() const { return false; }
- virtual bool isMark() const { return false; }
- virtual bool isMeasure() const { return false; }
+ bool isResource() const { return m_type == Type::Resource; }
+ bool isMark() const { return m_type == Type::Mark; }
+ bool isMeasure() const { return m_type == Type::Measure; }
static bool startTimeCompareLessThan(const RefPtr<PerformanceEntry>& a, const RefPtr<PerformanceEntry>& b)
{
Modified: trunk/Source/WebCore/page/PerformanceMark.h (212699 => 212700)
--- trunk/Source/WebCore/page/PerformanceMark.h 2017-02-21 05:50:06 UTC (rev 212699)
+++ trunk/Source/WebCore/page/PerformanceMark.h 2017-02-21 05:51:36 UTC (rev 212700)
@@ -35,8 +35,6 @@
class PerformanceMark final : public PerformanceEntry {
public:
static Ref<PerformanceMark> create(const String& name, double startTime) { return adoptRef(*new PerformanceMark(name, startTime)); }
-
- bool isMark() const override { return true; }
private:
PerformanceMark(const String& name, double startTime)
Modified: trunk/Source/WebCore/page/PerformanceMeasure.h (212699 => 212700)
--- trunk/Source/WebCore/page/PerformanceMeasure.h 2017-02-21 05:50:06 UTC (rev 212699)
+++ trunk/Source/WebCore/page/PerformanceMeasure.h 2017-02-21 05:51:36 UTC (rev 212700)
@@ -36,8 +36,6 @@
public:
static Ref<PerformanceMeasure> create(const String& name, double startTime, double duration) { return adoptRef(*new PerformanceMeasure(name, startTime, duration)); }
- bool isMeasure() const override { return true; }
-
private:
PerformanceMeasure(const String& name, double startTime, double duration)
: PerformanceEntry(PerformanceEntry::Type::Measure, name, ASCIILiteral("measure"), startTime, duration)
Modified: trunk/Source/WebCore/page/PerformanceResourceTiming.h (212699 => 212700)
--- trunk/Source/WebCore/page/PerformanceResourceTiming.h 2017-02-21 05:50:06 UTC (rev 212699)
+++ trunk/Source/WebCore/page/PerformanceResourceTiming.h 2017-02-21 05:51:36 UTC (rev 212700)
@@ -62,8 +62,6 @@
double responseStart() const;
double responseEnd() const;
- bool isResource() const override { return true; }
-
private:
PerformanceResourceTiming(MonotonicTime timeOrigin, ResourceTiming&&);
~PerformanceResourceTiming();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
