Title: [99181] trunk/Source/WebCore
Revision
99181
Author
[email protected]
Date
2011-11-03 06:33:57 -0700 (Thu, 03 Nov 2011)

Log Message

Use createPrimitiveNumericValue function
https://bugs.webkit.org/show_bug.cgi?id=71432

Reviewed by Andreas Kling.

No new tests - no change in functionality.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseWrapShapeRect):
(WebCore::CSSParser::parseWrapShapeCircle):
(WebCore::CSSParser::parseWrapShapeEllipse):
(WebCore::CSSParser::parseWrapShapePolygon):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (99180 => 99181)


--- trunk/Source/WebCore/ChangeLog	2011-11-03 13:28:20 UTC (rev 99180)
+++ trunk/Source/WebCore/ChangeLog	2011-11-03 13:33:57 UTC (rev 99181)
@@ -1,3 +1,18 @@
+2011-11-03  Mike Lawther  <[email protected]>
+
+        Use createPrimitiveNumericValue function
+        https://bugs.webkit.org/show_bug.cgi?id=71432
+
+        Reviewed by Andreas Kling.
+
+        No new tests - no change in functionality.
+
+        * css/CSSParser.cpp:
+        (WebCore::CSSParser::parseWrapShapeRect):
+        (WebCore::CSSParser::parseWrapShapeCircle):
+        (WebCore::CSSParser::parseWrapShapeEllipse):
+        (WebCore::CSSParser::parseWrapShapePolygon):
+
 2011-11-03  Pavel Feldman  <[email protected]>
 
         Not reviewed: win build fix. Assign autoDPI at all cases (breakage introduced in r99173).

Modified: trunk/Source/WebCore/css/CSSParser.cpp (99180 => 99181)


--- trunk/Source/WebCore/css/CSSParser.cpp	2011-11-03 13:28:20 UTC (rev 99180)
+++ trunk/Source/WebCore/css/CSSParser.cpp	2011-11-03 13:33:57 UTC (rev 99181)
@@ -3733,8 +3733,7 @@
         if (!validUnit(argument, FLength, m_strict))
             return 0;
 
-        RefPtr<CSSPrimitiveValue> length = primitiveValueCache()->createValue(argument->fValue,
-            (CSSPrimitiveValue::UnitTypes) argument->unit);
+        RefPtr<CSSPrimitiveValue> length = createPrimitiveNumericValue(argument);
         ASSERT(argumentNumber < 6);
         switch (argumentNumber) {
         case 0:
@@ -3787,8 +3786,7 @@
         if (!validUnit(argument, FLength, m_strict))
             return 0;
 
-        RefPtr<CSSPrimitiveValue> length = primitiveValueCache()->createValue(argument->fValue,
-            (CSSPrimitiveValue::UnitTypes) argument->unit);
+        RefPtr<CSSPrimitiveValue> length = createPrimitiveNumericValue(argument);
         ASSERT(argumentNumber < 3);
         switch (argumentNumber) {
         case 0:
@@ -3831,8 +3829,7 @@
         if (!validUnit(argument, FLength, m_strict))
             return 0;
 
-        RefPtr<CSSPrimitiveValue> length = primitiveValueCache()->createValue(argument->fValue,
-            (CSSPrimitiveValue::UnitTypes) argument->unit);
+        RefPtr<CSSPrimitiveValue> length = createPrimitiveNumericValue(argument);
         ASSERT(argumentNumber < 4);
         switch (argumentNumber) {
         case 0:
@@ -3902,10 +3899,8 @@
         if (!argumentY || !validUnit(argumentY, FLength, m_strict))
             return 0;
 
-        RefPtr<CSSPrimitiveValue> xLength = primitiveValueCache()->createValue(argumentX->fValue,
-            (CSSPrimitiveValue::UnitTypes) argumentX->unit);
-        RefPtr<CSSPrimitiveValue> yLength = primitiveValueCache()->createValue(argumentY->fValue,
-            (CSSPrimitiveValue::UnitTypes) argumentY->unit);
+        RefPtr<CSSPrimitiveValue> xLength = createPrimitiveNumericValue(argumentX);
+        RefPtr<CSSPrimitiveValue> yLength = createPrimitiveNumericValue(argumentY);
 
         shape->appendPoint(xLength.release(), yLength.release());
 
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to