Title: [212816] trunk/Source/WebKit2
- Revision
- 212816
- Author
- [email protected]
- Date
- 2017-02-22 00:33:41 -0800 (Wed, 22 Feb 2017)
Log Message
NetworkProcess: Stop disabling buffering when NETWORK_CACHE is disabled in build
https://bugs.webkit.org/show_bug.cgi?id=168637
Reviewed by Alex Christensen.
It was added in r193752 as part of bug #137692 to fix an infinite loop in network process that happened in EFL
because they didn't enable the network cache at that time. I think that was actually a workaround, and it was
added without any comment so it has stayed there even when EFL enabled disk cache, and now that is gone. Looking
at current code I see no reason why buffering can't work with the disk cache disabled, so I think it's time to
remove that workaround.
* WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::maximumBufferingTime):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (212815 => 212816)
--- trunk/Source/WebKit2/ChangeLog 2017-02-22 08:31:53 UTC (rev 212815)
+++ trunk/Source/WebKit2/ChangeLog 2017-02-22 08:33:41 UTC (rev 212816)
@@ -1,3 +1,19 @@
+2017-02-22 Carlos Garcia Campos <[email protected]>
+
+ NetworkProcess: Stop disabling buffering when NETWORK_CACHE is disabled in build
+ https://bugs.webkit.org/show_bug.cgi?id=168637
+
+ Reviewed by Alex Christensen.
+
+ It was added in r193752 as part of bug #137692 to fix an infinite loop in network process that happened in EFL
+ because they didn't enable the network cache at that time. I think that was actually a workaround, and it was
+ added without any comment so it has stayed there even when EFL enabled disk cache, and now that is gone. Looking
+ at current code I see no reason why buffering can't work with the disk cache disabled, so I think it's time to
+ remove that workaround.
+
+ * WebProcess/Network/WebLoaderStrategy.cpp:
+ (WebKit::maximumBufferingTime):
+
2017-02-21 Youenn Fablet <[email protected]>
[WebRTC][Mac] Activate libwebrtc
Modified: trunk/Source/WebKit2/WebProcess/Network/WebLoaderStrategy.cpp (212815 => 212816)
--- trunk/Source/WebKit2/WebProcess/Network/WebLoaderStrategy.cpp 2017-02-22 08:31:53 UTC (rev 212815)
+++ trunk/Source/WebKit2/WebProcess/Network/WebLoaderStrategy.cpp 2017-02-22 08:33:41 UTC (rev 212816)
@@ -98,10 +98,6 @@
static std::chrono::milliseconds maximumBufferingTime(CachedResource* resource)
{
-#if !ENABLE(NETWORK_CACHE)
- return 0ms;
-#endif
-
if (!resource)
return 0ms;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
