Title: [212852] trunk/Tools
- Revision
- 212852
- Author
- [email protected]
- Date
- 2017-02-22 13:55:03 -0800 (Wed, 22 Feb 2017)
Log Message
AutoInstaller should not skip the install step if the package is downloaded but not installed
https://bugs.webkit.org/show_bug.cgi?id=168737
Reviewed by Ryosuke Niwa.
Don't skip the install step if the package target path don't exists.
Fix the description for "should_refresh" optional argument.
* Scripts/webkitpy/common/system/autoinstall.py:
(AutoInstaller.install):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (212851 => 212852)
--- trunk/Tools/ChangeLog 2017-02-22 21:52:13 UTC (rev 212851)
+++ trunk/Tools/ChangeLog 2017-02-22 21:55:03 UTC (rev 212852)
@@ -1,3 +1,16 @@
+2017-02-22 Carlos Alberto Lopez Perez <[email protected]>
+
+ AutoInstaller should not skip the install step if the package is downloaded but not installed
+ https://bugs.webkit.org/show_bug.cgi?id=168737
+
+ Reviewed by Ryosuke Niwa.
+
+ Don't skip the install step if the package target path don't exists.
+ Fix the description for "should_refresh" optional argument.
+
+ * Scripts/webkitpy/common/system/autoinstall.py:
+ (AutoInstaller.install):
+
2017-02-22 Carlos Garcia Campos <[email protected]>
[GTK] Do not use g_return_if_fail in EventSenderProxy::continuousMouseScrollBy
Modified: trunk/Tools/Scripts/webkitpy/common/system/autoinstall.py (212851 => 212852)
--- trunk/Tools/Scripts/webkitpy/common/system/autoinstall.py 2017-02-22 21:52:13 UTC (rev 212851)
+++ trunk/Tools/Scripts/webkitpy/common/system/autoinstall.py 2017-02-22 21:55:03 UTC (rev 212852)
@@ -467,7 +467,8 @@
Optional Args:
should_refresh: A boolean value of whether the package should be
- downloaded again if the package is already present.
+ downloaded and reinstalled again even if the
+ package is already present.
target_name: The name of the folder or file in the autoinstaller
target directory at which the package should be
installed. Defaults to the base name of the
@@ -488,7 +489,7 @@
target_name = os.path.basename(url_subpath)
target_path = os.path.join(self._target_dir, target_name.replace('/', os.sep))
- if not should_refresh and self._is_downloaded(target_name, url):
+ if not should_refresh and self._is_downloaded(target_name, url) and os.path.exists(target_path):
return
files_to_remove = files_to_remove or []
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
