Title: [212855] trunk/Source/WebInspectorUI
- Revision
- 212855
- Author
- [email protected]
- Date
- 2017-02-22 15:09:26 -0800 (Wed, 22 Feb 2017)
Log Message
Web Inspector: RTL: Sidebar borders are on the wrong side
https://bugs.webkit.org/show_bug.cgi?id=168743
Patch by Devin Rousso <[email protected]> on 2017-02-22
Reviewed by Matt Baker.
* UserInterface/Views/Sidebar.css:
(body[dir=ltr] .sidebar.right > .resizer, body[dir=rtl] .sidebar.left > .resizer):
(body[dir=ltr] .sidebar.left > .resizer, body[dir=rtl] .sidebar.right > .resizer):
(body[dir=ltr] .sidebar.left, body[dir=rtl] .sidebar.right):
(body[dir=ltr] .sidebar.right, body[dir=rtl] .sidebar.left):
(.sidebar.right > .resizer): Deleted.
(.sidebar.left > .resizer): Deleted.
(.sidebar.left): Deleted.
(.sidebar.right): Deleted.
* UserInterface/Views/Sidebar.js:
(WebInspector.Sidebar.prototype.resizerDragging):
Reverse the change if the direction is RTL.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (212854 => 212855)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-02-22 22:37:41 UTC (rev 212854)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-02-22 23:09:26 UTC (rev 212855)
@@ -1,3 +1,24 @@
+2017-02-22 Devin Rousso <[email protected]>
+
+ Web Inspector: RTL: Sidebar borders are on the wrong side
+ https://bugs.webkit.org/show_bug.cgi?id=168743
+
+ Reviewed by Matt Baker.
+
+ * UserInterface/Views/Sidebar.css:
+ (body[dir=ltr] .sidebar.right > .resizer, body[dir=rtl] .sidebar.left > .resizer):
+ (body[dir=ltr] .sidebar.left > .resizer, body[dir=rtl] .sidebar.right > .resizer):
+ (body[dir=ltr] .sidebar.left, body[dir=rtl] .sidebar.right):
+ (body[dir=ltr] .sidebar.right, body[dir=rtl] .sidebar.left):
+ (.sidebar.right > .resizer): Deleted.
+ (.sidebar.left > .resizer): Deleted.
+ (.sidebar.left): Deleted.
+ (.sidebar.right): Deleted.
+
+ * UserInterface/Views/Sidebar.js:
+ (WebInspector.Sidebar.prototype.resizerDragging):
+ Reverse the change if the direction is RTL.
+
2017-02-22 Brian Burg <[email protected]>
Web Inspector: RTL: Settings tab labels need adjustment
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Sidebar.css (212854 => 212855)
--- trunk/Source/WebInspectorUI/UserInterface/Views/Sidebar.css 2017-02-22 22:37:41 UTC (rev 212854)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Sidebar.css 2017-02-22 23:09:26 UTC (rev 212855)
@@ -62,11 +62,13 @@
display: block;
}
-.sidebar.right > .resizer {
+body[dir=ltr] .sidebar.right > .resizer,
+body[dir=rtl] .sidebar.left > .resizer {
left: -3px;
}
-.sidebar.left > .resizer {
+body[dir=ltr] .sidebar.left > .resizer,
+body[dir=rtl] .sidebar.right > .resizer {
right: -3px;
}
@@ -74,10 +76,12 @@
display: none;
}
-.sidebar.left {
+body[dir=ltr] .sidebar.left,
+body[dir=rtl] .sidebar.right {
border-right: 1px solid var(--border-color);
}
-.sidebar.right {
+body[dir=ltr] .sidebar.right,
+body[dir=rtl] .sidebar.left {
border-left: 1px solid var(--border-color);
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Sidebar.js (212854 => 212855)
--- trunk/Source/WebInspectorUI/UserInterface/Views/Sidebar.js 2017-02-22 22:37:41 UTC (rev 212854)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Sidebar.js 2017-02-22 23:09:26 UTC (rev 212855)
@@ -254,6 +254,9 @@
if (this._side === WebInspector.Sidebar.Sides.Left)
positionDelta *= -1;
+ if (WebInspector.resolvedLayoutDirection() === WebInspector.LayoutDirection.RTL)
+ positionDelta *= -1;
+
var newWidth = positionDelta + this._widthBeforeResize;
this.width = newWidth;
this.collapsed = (newWidth < (this.minimumWidth / 2));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
