Title: [212915] trunk/Source/WebKit2
Revision
212915
Author
[email protected]
Date
2017-02-23 12:39:46 -0800 (Thu, 23 Feb 2017)

Log Message

[WebRTC][Mac][WebKit2] WebRTC requires media capture
https://bugs.webkit.org/show_bug.cgi?id=168782
<rdar://problem/30675242>

Reviewed by Youenn Fablet.

* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess): Extend the sanbox to allow microphone access
if media stream OR WebRTC is enabled.

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (212914 => 212915)


--- trunk/Source/WebKit2/ChangeLog	2017-02-23 20:32:26 UTC (rev 212914)
+++ trunk/Source/WebKit2/ChangeLog	2017-02-23 20:39:46 UTC (rev 212915)
@@ -1,3 +1,15 @@
+2017-02-23  Eric Carlson  <[email protected]>
+
+        [WebRTC][Mac][WebKit2] WebRTC requires media capture
+        https://bugs.webkit.org/show_bug.cgi?id=168782
+        <rdar://problem/30675242>
+
+        Reviewed by Youenn Fablet.
+
+        * UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+        (WebKit::WebProcessPool::platformInitializeWebProcess): Extend the sanbox to allow microphone access
+        if media stream OR WebRTC is enabled.
+
 2017-02-23  Brent Fulgham  <[email protected]>
 
         [Mac] Remove unneeded sandbox exceptions for media elements

Modified: trunk/Source/WebKit2/UIProcess/Cocoa/WebProcessPoolCocoa.mm (212914 => 212915)


--- trunk/Source/WebKit2/UIProcess/Cocoa/WebProcessPoolCocoa.mm	2017-02-23 20:32:26 UTC (rev 212914)
+++ trunk/Source/WebKit2/UIProcess/Cocoa/WebProcessPoolCocoa.mm	2017-02-23 20:39:46 UTC (rev 212915)
@@ -249,12 +249,14 @@
     parameters.uiProcessCookieStorageIdentifier.append(CFDataGetBytePtr(cookieStorageData.get()), CFDataGetLength(cookieStorageData.get()));
 #endif
 #if ENABLE(MEDIA_STREAM)
+    // Allow microphone access if either preference is set because WebRTC requires microphone access.
     bool mediaStreamEnabled = m_defaultPageGroup->preferences().mediaStreamEnabled();
+    bool webRTCEnabled = m_defaultPageGroup->preferences().peerConnectionEnabled();
     if ([defaults objectForKey:@"ExperimentalPeerConnectionEnabled"])
-        mediaStreamEnabled = [defaults boolForKey:@"ExperimentalPeerConnectionEnabled"];
+        webRTCEnabled = [defaults boolForKey:@"ExperimentalPeerConnectionEnabled"];
     
     // FIXME: Remove this and related parameter when <rdar://problem/29448368> is fixed.
-    if (mediaStreamEnabled)
+    if (mediaStreamEnabled || webRTCEnabled)
         SandboxExtension::createHandleForGenericExtension("com.apple.webkit.microphone", parameters.audioCaptureExtensionHandle);
 #endif
 }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to