Title: [212921] trunk/Source/_javascript_Core
Revision
212921
Author
[email protected]
Date
2017-02-23 13:25:15 -0800 (Thu, 23 Feb 2017)

Log Message

Make Briggs fixpoint validation run only with validateGraphAtEachPhase
https://bugs.webkit.org/show_bug.cgi?id=168795

Rubber stamped by Keith Miller.

The Briggs allocator was running intensive validation
on each step of the fixpoint. Instead, it now will just
do it when shouldValidateIRAtEachPhase() is true because
doing this for all !ASSERT_DISABLED builds takes too long.

* b3/air/AirAllocateRegistersByGraphColoring.cpp:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (212920 => 212921)


--- trunk/Source/_javascript_Core/ChangeLog	2017-02-23 20:56:54 UTC (rev 212920)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-02-23 21:25:15 UTC (rev 212921)
@@ -1,3 +1,17 @@
+2017-02-23  Saam Barati  <[email protected]>
+
+        Make Briggs fixpoint validation run only with validateGraphAtEachPhase
+        https://bugs.webkit.org/show_bug.cgi?id=168795
+
+        Rubber stamped by Keith Miller.
+
+        The Briggs allocator was running intensive validation
+        on each step of the fixpoint. Instead, it now will just
+        do it when shouldValidateIRAtEachPhase() is true because
+        doing this for all !ASSERT_DISABLED builds takes too long.
+
+        * b3/air/AirAllocateRegistersByGraphColoring.cpp:
+
 2017-02-23  Filip Pizlo  <[email protected]>
 
         SpeculativeJIT::compilePutByValForIntTypedArray should only do the constant-folding optimization when the constant passes the type check

Modified: trunk/Source/_javascript_Core/b3/air/AirAllocateRegistersByGraphColoring.cpp (212920 => 212921)


--- trunk/Source/_javascript_Core/b3/air/AirAllocateRegistersByGraphColoring.cpp	2017-02-23 20:56:54 UTC (rev 212920)
+++ trunk/Source/_javascript_Core/b3/air/AirAllocateRegistersByGraphColoring.cpp	2017-02-23 21:25:15 UTC (rev 212921)
@@ -645,6 +645,8 @@
         auto assertInvariants = [&] () {
             if (ASSERT_DISABLED)
                 return;
+            if (!shouldValidateIRAtEachPhase())
+                return;
 
             IndexType firstNonRegIndex = m_lastPrecoloredRegisterIndex + 1;
             unsigned registerCount = this->registerCount();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to