Title: [212931] trunk/Source/WebCore
Revision
212931
Author
[email protected]
Date
2017-02-23 17:00:50 -0800 (Thu, 23 Feb 2017)

Log Message

[WebRTC] Outgoing video quality is poor
https://bugs.webkit.org/show_bug.cgi?id=168778
<rdar://problem/30674673>

Patch by Youenn Fablet <[email protected]> on 2017-02-23
Reviewed by Eric Carlson.

Covered by manually ensuring the voice process thread is not spinning.

* platform/mediastream/libwebrtc/LibWebRTCAudioModule.h: Setting the next call to max was not a good idea since the thread process is adding some value to it, making it a negative value.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (212930 => 212931)


--- trunk/Source/WebCore/ChangeLog	2017-02-23 23:38:06 UTC (rev 212930)
+++ trunk/Source/WebCore/ChangeLog	2017-02-24 01:00:50 UTC (rev 212931)
@@ -1,3 +1,15 @@
+2017-02-23  Youenn Fablet  <[email protected]>
+
+        [WebRTC] Outgoing video quality is poor
+        https://bugs.webkit.org/show_bug.cgi?id=168778
+        <rdar://problem/30674673>
+
+        Reviewed by Eric Carlson.
+
+        Covered by manually ensuring the voice process thread is not spinning.
+
+        * platform/mediastream/libwebrtc/LibWebRTCAudioModule.h: Setting the next call to max was not a good idea since the thread process is adding some value to it, making it a negative value.
+
 2017-02-23  Wenson Hsieh  <[email protected]>
 
         Data interaction with a URL should navigate the page if the operation is not handled

Modified: trunk/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCAudioModule.h (212930 => 212931)


--- trunk/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCAudioModule.h	2017-02-23 23:38:06 UTC (rev 212930)
+++ trunk/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCAudioModule.h	2017-02-24 01:00:50 UTC (rev 212931)
@@ -56,7 +56,8 @@
     int32_t RegisterAudioCallback(webrtc::AudioTransport*) final;
     bool Playing() const final { return m_isPlaying; }
 
-    int64_t TimeUntilNextProcess() final { return std::numeric_limits<int64_t>::max(); }
+    // Set it to a big value so that we are not called often but not close to int64_t max so that it does not create integer overflows.
+    int64_t TimeUntilNextProcess() final { return 100000000; }
     void Process() final { }
     int32_t ActiveAudioLayer(AudioLayer*) const final { return shouldNotBeCalled(-1); }
     ErrorCode LastError() const final { return kAdmErrNone; }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to