Title: [212996] trunk/Source/WebInspectorUI
- Revision
- 212996
- Author
- [email protected]
- Date
- 2017-02-24 23:53:35 -0800 (Fri, 24 Feb 2017)
Log Message
Web Inspector: RTL: add support for Error page
https://bugs.webkit.org/show_bug.cgi?id=168855
Patch by Devin Rousso <[email protected]> on 2017-02-24
Reviewed by Brian Burg.
* UserInterface/Debug/UncaughtExceptionReporter.css:
(.uncaught-exception-sheet):
(body[dir=ltr] .uncaught-exception-sheet):
(body[dir=rtl] .uncaught-exception-sheet):
(.uncaught-exception-sheet h1 > img):
(body[dir=ltr] .uncaught-exception-sheet h1 > img):
(body[dir=rtl] .uncaught-exception-sheet h1 > img):
(.uncaught-exception-sheet h2 > img):
(body[dir=ltr] .uncaught-exception-sheet h2 > img):
(body[dir=rtl] .uncaught-exception-sheet h2 > img):
(.uncaught-exception-sheet dd):
(body[dir=ltr] .uncaught-exception-sheet dd):
(body[dir=rtl] .uncaught-exception-sheet dd):
(.uncaught-exception-sheet ul):
(body[dir=ltr] .uncaught-exception-sheet ul):
(body[dir=rtl] .uncaught-exception-sheet ul):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (212995 => 212996)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-02-25 07:50:32 UTC (rev 212995)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-02-25 07:53:35 UTC (rev 212996)
@@ -1,5 +1,29 @@
2017-02-24 Devin Rousso <[email protected]>
+ Web Inspector: RTL: add support for Error page
+ https://bugs.webkit.org/show_bug.cgi?id=168855
+
+ Reviewed by Brian Burg.
+
+ * UserInterface/Debug/UncaughtExceptionReporter.css:
+ (.uncaught-exception-sheet):
+ (body[dir=ltr] .uncaught-exception-sheet):
+ (body[dir=rtl] .uncaught-exception-sheet):
+ (.uncaught-exception-sheet h1 > img):
+ (body[dir=ltr] .uncaught-exception-sheet h1 > img):
+ (body[dir=rtl] .uncaught-exception-sheet h1 > img):
+ (.uncaught-exception-sheet h2 > img):
+ (body[dir=ltr] .uncaught-exception-sheet h2 > img):
+ (body[dir=rtl] .uncaught-exception-sheet h2 > img):
+ (.uncaught-exception-sheet dd):
+ (body[dir=ltr] .uncaught-exception-sheet dd):
+ (body[dir=rtl] .uncaught-exception-sheet dd):
+ (.uncaught-exception-sheet ul):
+ (body[dir=ltr] .uncaught-exception-sheet ul):
+ (body[dir=rtl] .uncaught-exception-sheet ul):
+
+2017-02-24 Devin Rousso <[email protected]>
+
Web Inspector: Uncaught Exception: Unknown angle units "undefined"
https://bugs.webkit.org/show_bug.cgi?id=168851
Modified: trunk/Source/WebInspectorUI/UserInterface/Debug/UncaughtExceptionReporter.css (212995 => 212996)
--- trunk/Source/WebInspectorUI/UserInterface/Debug/UncaughtExceptionReporter.css 2017-02-25 07:50:32 UTC (rev 212995)
+++ trunk/Source/WebInspectorUI/UserInterface/Debug/UncaughtExceptionReporter.css 2017-02-25 07:53:35 UTC (rev 212996)
@@ -35,13 +35,26 @@
}
.uncaught-exception-sheet {
- padding: 50px 55px 50px 65px;
+ min-width: 400px;
+ padding: 50px 0;
font-family: '-webkit-system-font';
font-size: 11pt;
- min-width: 400px;
color: hsl(0, 0%, 40%);
+
+ --uncaught-exception-sheet-margin-start: 65px;
+ --uncaught-exception-sheet-margin-end: 55px;
}
+body[dir=ltr] .uncaught-exception-sheet {
+ margin-left: var(--uncaught-exception-sheet-margin-start);
+ margin-right: var(--uncaught-exception-sheet-margin-end);
+}
+
+body[dir=rtl] .uncaught-exception-sheet {
+ margin-left: var(--uncaught-exception-sheet-margin-end);
+ margin-right: var(--uncaught-exception-sheet-margin-start);
+}
+
.uncaught-exception-sheet a {
text-decoration: underline;
color: hsl(240, 55%, 30%);
@@ -68,21 +81,41 @@
}
.uncaught-exception-sheet h1 > img {
+ position: relative;
height: 35px;
- position: relative;
- margin-left: -50px;
margin-top: -5px;
+
+ --uncaught-exception-sheet-h1-img-margin-start: -50px;
+}
+
+body[dir=ltr] .uncaught-exception-sheet h1 > img {
float: left;
+ margin-left: var(--uncaught-exception-sheet-h1-img-margin-start);
}
+body[dir=rtl] .uncaught-exception-sheet h1 > img {
+ float: right;
+ margin-right: var(--uncaught-exception-sheet-h1-img-margin-start);
+}
+
.uncaught-exception-sheet h2 > img {
+ position: relative;
height: 25px;
- position: relative;
- margin-left: -45px;
- margin-top: 0px;
+ margin-top: 0;
+
+ --uncaught-exception-sheet-h2-img-margin-start: -45px;
+}
+
+body[dir=ltr] .uncaught-exception-sheet h2 > img {
float: left;
+ margin-left: var(--uncaught-exception-sheet-h2-img-margin-start);
}
+body[dir=rtl] .uncaught-exception-sheet h2 > img {
+ float: right;
+ margin-right: var(--uncaught-exception-sheet-h2-img-margin-start);
+}
+
.uncaught-exception-sheet dl {
max-width: 600px;
}
@@ -93,19 +126,39 @@
}
.uncaught-exception-sheet dd {
- margin: 10px 0 20px 10px;
+ margin: 10px 0 20px;
font-size: 13px;
line-height: 18px;
+
+ --uncaught-exception-sheet-dd-margin-start: 10px;
}
+body[dir=ltr] .uncaught-exception-sheet dd {
+ margin-left: var(--uncaught-exception-sheet-dd-margin-start);
+}
+
+body[dir=rtl] .uncaught-exception-sheet dd {
+ margin-right: var(--uncaught-exception-sheet-dd-margin-start);
+}
+
.uncaught-exception-sheet ul {
+ margin: 0;
+ padding: 0;
font-family: Menlo, monospace;
font-size: 12px;
line-height: 18px;
- margin: 0 0 0 2px;
- padding: 0;
+
+ --uncaught-exception-sheet-ul-margin-start: 2px;
}
+body[dir=ltr] .uncaught-exception-sheet ul {
+ margin-left: var(--uncaught-exception-sheet-ul-margin-start);
+}
+
+body[dir=rtl] .uncaught-exception-sheet ul {
+ margin-right: var(--uncaught-exception-sheet-ul-margin-start);
+}
+
.uncaught-exception-sheet li {
margin-bottom: 20px;
word-break: break-word;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
