Title: [212998] trunk/Source/WebInspectorUI
- Revision
- 212998
- Author
- [email protected]
- Date
- 2017-02-25 00:05:21 -0800 (Sat, 25 Feb 2017)
Log Message
Web Inspector: RTL: disclosure triangles in details section headers should be flipped and aligned right
https://bugs.webkit.org/show_bug.cgi?id=168283
Patch by Devin Rousso <[email protected]> on 2017-02-25
Reviewed by Brian Burg.
* UserInterface/Views/DetailsSection.css:
(.details-section):
(.details-section > .header):
(body[dir=ltr] .details-section > .header):
(body[dir=rtl] .details-section > .header):
(.details-section > .header > .options > .navigation-bar):
(body[dir=ltr] .details-section > .header > :matches(label, .node-link, .go-to-arrow, .options > .navigation-bar), body[dir=rtl] .details-section > .header::before):
(body[dir=ltr] .details-section > .header::before, body[dir=rtl] .details-section > .header > :matches(label, .node-link, .go-to-arrow, .options > .navigation-bar)):
(.details-section > .header::before):
(body[dir=rtl] .details-section > .header::before):
(.details-section > .header > label):
(.details-section > .header > label > input[type="checkbox"]):
(body[dir=ltr] .details-section > .header > label > input[type="checkbox"]):
(body[dir=rtl] .details-section > .header > label > input[type="checkbox"]):
(.details-section > .header .go-to-arrow):
(body[dir=ltr] .details-section > .header .go-to-arrow):
(body[dir=rtl] .details-section > .header .go-to-arrow):
(.details-section > .content > .group > .row.simple > .label):
(body[dir=ltr] .details-section > .content > .group > .row.simple > .label):
(body[dir=rtl] .details-section > .content > .group > .row.simple > .label):
(.details-section > .content > .group > .row.simple > .value):
(body[dir=ltr] .details-section > .content > .group > .row.simple > .value):
(body[dir=rtl] .details-section > .content > .group > .row.simple > .value):
(.details-section > .content > .group > .row.simple > .value .go-to-arrow):
(body[dir=ltr] .details-section > .content > .group > .row.simple > .value .go-to-arrow):
(body[dir=rtl] .details-section > .content > .group > .row.simple > .value .go-to-arrow):
(.details-section > .header > :matches(.node-link, .go-to-arrow)): Deleted.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (212997 => 212998)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-02-25 08:02:02 UTC (rev 212997)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-02-25 08:05:21 UTC (rev 212998)
@@ -1,3 +1,38 @@
+2017-02-25 Devin Rousso <[email protected]>
+
+ Web Inspector: RTL: disclosure triangles in details section headers should be flipped and aligned right
+ https://bugs.webkit.org/show_bug.cgi?id=168283
+
+ Reviewed by Brian Burg.
+
+ * UserInterface/Views/DetailsSection.css:
+ (.details-section):
+ (.details-section > .header):
+ (body[dir=ltr] .details-section > .header):
+ (body[dir=rtl] .details-section > .header):
+ (.details-section > .header > .options > .navigation-bar):
+ (body[dir=ltr] .details-section > .header > :matches(label, .node-link, .go-to-arrow, .options > .navigation-bar), body[dir=rtl] .details-section > .header::before):
+ (body[dir=ltr] .details-section > .header::before, body[dir=rtl] .details-section > .header > :matches(label, .node-link, .go-to-arrow, .options > .navigation-bar)):
+ (.details-section > .header::before):
+ (body[dir=rtl] .details-section > .header::before):
+ (.details-section > .header > label):
+ (.details-section > .header > label > input[type="checkbox"]):
+ (body[dir=ltr] .details-section > .header > label > input[type="checkbox"]):
+ (body[dir=rtl] .details-section > .header > label > input[type="checkbox"]):
+ (.details-section > .header .go-to-arrow):
+ (body[dir=ltr] .details-section > .header .go-to-arrow):
+ (body[dir=rtl] .details-section > .header .go-to-arrow):
+ (.details-section > .content > .group > .row.simple > .label):
+ (body[dir=ltr] .details-section > .content > .group > .row.simple > .label):
+ (body[dir=rtl] .details-section > .content > .group > .row.simple > .label):
+ (.details-section > .content > .group > .row.simple > .value):
+ (body[dir=ltr] .details-section > .content > .group > .row.simple > .value):
+ (body[dir=rtl] .details-section > .content > .group > .row.simple > .value):
+ (.details-section > .content > .group > .row.simple > .value .go-to-arrow):
+ (body[dir=ltr] .details-section > .content > .group > .row.simple > .value .go-to-arrow):
+ (body[dir=rtl] .details-section > .content > .group > .row.simple > .value .go-to-arrow):
+ (.details-section > .header > :matches(.node-link, .go-to-arrow)): Deleted.
+
2017-02-24 Devin Rousso <[email protected]>
Web Inspector: RTL: add support for Error page
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DetailsSection.css (212997 => 212998)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DetailsSection.css 2017-02-25 08:02:02 UTC (rev 212997)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DetailsSection.css 2017-02-25 08:05:21 UTC (rev 212998)
@@ -27,6 +27,12 @@
font-size: 10px;
background-color: var(--panel-background-color);
border-bottom: 1px solid var(--border-color);
+
+ --details-section-header-padding-end: 5px;
+ --details-section-header-label-checkbox-margin-start: 5px;
+ --details-section-header-go-to-margin-start: -3px;
+ --details-section-content-row-simple-padding-start: 6px;
+ --details-section-content-group-row-simple-value-go-to-margin-start: 5px;
}
.details-section .details-section {
@@ -46,30 +52,43 @@
position: -webkit-sticky;
top: -1px;
height: 23px;
-
+ padding: 4px 0;
+ font-size: 11px;
+ font-weight: bold;
+ white-space: nowrap;
+ text-overflow: ellipsis;
+ color: hsl(0, 0%, 22%);
background-color: var(--panel-background-color);
- color: hsl(0, 0%, 22%);
-
- white-space: nowrap;
overflow: hidden;
- text-overflow: ellipsis;
- font-size: 11px;
- font-weight: bold;
-
- padding: 4px 5px 4px 0;
-
/* Ensure the headers are displayed above scrollbars. */
z-index: var(--z-index-header);
}
+body[dir=ltr] .details-section > .header {
+ padding-right: var(--details-section-header-padding-end);
+}
+
+body[dir=rtl] .details-section > .header {
+ padding-left: var(--details-section-header-padding-end);
+}
+
.details-section > .header > .options > .navigation-bar {
margin-top: 1px;
height: 100%;
- float: right;
border: none;
}
+body[dir=ltr] .details-section > .header > :matches(label, .node-link, .go-to-arrow, .options > .navigation-bar),
+body[dir=rtl] .details-section > .header::before {
+ float: right;
+}
+
+body[dir=ltr] .details-section > .header::before,
+body[dir=rtl] .details-section > .header > :matches(label, .node-link, .go-to-arrow, .options > .navigation-bar) {
+ float: left;
+}
+
.details-section > .header > .options > .navigation-bar > .item {
width: 20px;
height: 100%;
@@ -94,17 +113,17 @@
.details-section > .header::before {
display: block;
- float: left;
-
width: 21px;
height: 100%;
-
+ content: "";
background-image: url(../Images/DisclosureTriangles.svg#open-normal);
background-repeat: no-repeat;
background-position: center;
background-size: 13px 13px;
+}
- content: "";
+body[dir=rtl] .details-section > .header::before {
+ transform: scaleX(-1);
}
.details-section > .header:not(.mouse-over-options-element):active::before {
@@ -120,10 +139,9 @@
}
.details-section > .header > label {
- float: right;
font-size: 10px;
color: hsla(0, 0%, 0%, 0.6);
- text-align: right;
+ text-align: end;
}
.details-section.collapsed > .header > label {
@@ -131,21 +149,32 @@
}
.details-section > .header > label > input[type="checkbox"] {
- margin: 0 0 0 5px;
+ margin: 0;
vertical-align: 1px;
font-size: 10px;
}
-.details-section > .header > :matches(.node-link, .go-to-arrow) {
- float: right;
+body[dir=ltr] .details-section > .header > label > input[type="checkbox"] {
+ margin-left: var(--details-section-header-label-checkbox-margin-start);
}
+body[dir=rtl] .details-section > .header > label > input[type="checkbox"] {
+ margin-right: var(--details-section-header-label-checkbox-margin-start);
+}
+
.details-section > .header .go-to-arrow {
width: 10px;
height: 12px;
- margin-left: 3px;
}
+body[dir=ltr] .details-section > .header .go-to-arrow {
+ margin-left: var(--details-section-header-go-to-margin-start);
+}
+
+body[dir=rtl] .details-section > .header .go-to-arrow {
+ margin-right: var(--details-section-header-go-to-margin-start);
+}
+
.details-section > .content {
display: table;
width: 100%;
@@ -214,30 +243,46 @@
}
.details-section > .content > .group > .row.simple > .label {
+ width: 85px;
color: hsl(0, 0%, 20%);
+ text-align: end;
+}
- text-align: right;
+body[dir=ltr] .details-section > .content > .group > .row.simple > .label {
+ padding-left: var(--details-section-content-group-row-simple-padding-start);
+}
- padding-left: 6px;
-
- width: 85px;
+body[dir=rtl] .details-section > .content > .group > .row.simple > .label {
+ padding-right: var(--details-section-content-group-row-simple-padding-start);
}
.details-section > .content > .group > .row.simple > .value {
word-wrap: break-word;
+ cursor: text;
+ -webkit-user-select: text;
+}
- padding-right: 6px;
+body[dir=ltr] .details-section > .content > .group > .row.simple > .value {
+ padding-right: var(--details-section-content-group-row-simple-padding-start);
+}
- -webkit-user-select: text;
- cursor: text;
+body[dir=rtl] .details-section > .content > .group > .row.simple > .value {
+ padding-left: var(--details-section-content-group-row-simple-padding-start);
}
.details-section > .content > .group > .row.simple > .value .go-to-arrow {
width: 10px;
height: 12px;
- margin-left: 5px;
}
+body[dir=ltr] .details-section > .content > .group > .row.simple > .value .go-to-arrow {
+ margin-right: var(--details-section-content-group-row-simple-value-go-to-margin-start);
+}
+
+body[dir=rtl] .details-section > .content > .group > .row.simple > .value .go-to-arrow {
+ margin-left: var(--details-section-content-group-row-simple-value-go-to-margin-start);
+}
+
.details-section > .content > .group > .row.simple.data > .value {
word-break: break-all;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
