Title: [213001] trunk/Source/WebInspectorUI
Revision
213001
Author
[email protected]
Date
2017-02-25 00:43:29 -0800 (Sat, 25 Feb 2017)

Log Message

Web Inspector: RTL: Elements tab Styles sidebar label/arrows need adjustment
https://bugs.webkit.org/show_bug.cgi?id=168746

Patch by Devin Rousso <[email protected]> on 2017-02-25
Reviewed by Brian Burg.

* UserInterface/Views/ScopeRadioButtonNavigationItem.css:
(.scope-radio-button-navigation-item):
(.scope-radio-button-navigation-item > .scope-radio-button-item-select):
(body[dir=ltr] .scope-radio-button-navigation-item > .scope-radio-button-item-select):
(body[dir=rtl] .scope-radio-button-navigation-item > .scope-radio-button-item-select):
(.scope-radio-button-navigation-item > .scope-radio-button-item-select:focus):
(.scope-radio-button-navigation-item > .arrows):
(body[dir=ltr] .scope-radio-button-navigation-item > .arrows):
(body[dir=rtl] .scope-radio-button-navigation-item > .arrows):

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (213000 => 213001)


--- trunk/Source/WebInspectorUI/ChangeLog	2017-02-25 08:29:59 UTC (rev 213000)
+++ trunk/Source/WebInspectorUI/ChangeLog	2017-02-25 08:43:29 UTC (rev 213001)
@@ -1,5 +1,22 @@
 2017-02-25  Devin Rousso  <[email protected]>
 
+        Web Inspector: RTL: Elements tab Styles sidebar label/arrows need adjustment
+        https://bugs.webkit.org/show_bug.cgi?id=168746
+
+        Reviewed by Brian Burg.
+
+        * UserInterface/Views/ScopeRadioButtonNavigationItem.css:
+        (.scope-radio-button-navigation-item):
+        (.scope-radio-button-navigation-item > .scope-radio-button-item-select):
+        (body[dir=ltr] .scope-radio-button-navigation-item > .scope-radio-button-item-select):
+        (body[dir=rtl] .scope-radio-button-navigation-item > .scope-radio-button-item-select):
+        (.scope-radio-button-navigation-item > .scope-radio-button-item-select:focus):
+        (.scope-radio-button-navigation-item > .arrows):
+        (body[dir=ltr] .scope-radio-button-navigation-item > .arrows):
+        (body[dir=rtl] .scope-radio-button-navigation-item > .arrows):
+
+2017-02-25  Devin Rousso  <[email protected]>
+
         Web Inspector: copying a search result out of Search Tab navigation sidebar does nothing
         https://bugs.webkit.org/show_bug.cgi?id=167074
 

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ScopeRadioButtonNavigationItem.css (213000 => 213001)


--- trunk/Source/WebInspectorUI/UserInterface/Views/ScopeRadioButtonNavigationItem.css	2017-02-25 08:29:59 UTC (rev 213000)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ScopeRadioButtonNavigationItem.css	2017-02-25 08:43:29 UTC (rev 213001)
@@ -25,12 +25,14 @@
 
 .scope-radio-button-navigation-item {
     position: relative;
+
+    --scope-radio-button-navigation-item-select-offset-start: 0;
+    --scope-radio-button-navigation-item-arrows-margin-start: 4px;
 }
 
 .scope-radio-button-navigation-item > .scope-radio-button-item-select {
     position: absolute;
     top: 0;
-    left: 0;
     width: 100%;
     height: 100%;
     border: 1px solid transparent;
@@ -40,10 +42,17 @@
     outline: none;
 }
 
+body[dir=ltr] .scope-radio-button-navigation-item > .scope-radio-button-item-select {
+    left: var(--scope-radio-button-navigation-item-select-offset-start);
+}
+
+body[dir=rtl] .scope-radio-button-navigation-item > .scope-radio-button-item-select {
+    right: var(--scope-radio-button-navigation-item-select-offset-start);
+}
+
 /* Positions the "Style" text almost exactly over the radio-button-item */
 .scope-radio-button-navigation-item > .scope-radio-button-item-select:focus {
     top: -2px;
-    left: 0px;
     border: none;
 }
 
@@ -50,10 +59,17 @@
 .scope-radio-button-navigation-item > .arrows {
     width: 5px;
     height: 11px;
-    margin-left: 4px;
     transform: translateY(1px);
 }
 
+body[dir=ltr] .scope-radio-button-navigation-item > .arrows {
+    margin-left: var(--scope-radio-button-navigation-item-arrows-margin-start);
+}
+
+body[dir=rtl] .scope-radio-button-navigation-item > .arrows {
+    margin-right: var(--scope-radio-button-navigation-item-arrows-margin-start);
+}
+
 .scope-radio-button-navigation-item.selected > .arrows {
     display: inline-block;
 }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to