Title: [213025] trunk/Source/WebKit2
Revision
213025
Author
[email protected]
Date
2017-02-26 22:31:44 -0800 (Sun, 26 Feb 2017)

Log Message

Web Inspector: RTL: Docking Left doesn't constrain the page width
https://bugs.webkit.org/show_bug.cgi?id=168862

Patch by Devin Rousso <[email protected]> on 2017-02-26
Reviewed by Brian Burg.

* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::inspectedViewFrameDidChange):
Calculate the inspectedViewFrame to be the remaining space after WebInspector is opened
instead of using the original page size.

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (213024 => 213025)


--- trunk/Source/WebKit2/ChangeLog	2017-02-27 06:03:23 UTC (rev 213024)
+++ trunk/Source/WebKit2/ChangeLog	2017-02-27 06:31:44 UTC (rev 213025)
@@ -1,3 +1,15 @@
+2017-02-26  Devin Rousso  <[email protected]>
+
+        Web Inspector: RTL: Docking Left doesn't constrain the page width
+        https://bugs.webkit.org/show_bug.cgi?id=168862
+
+        Reviewed by Brian Burg.
+
+        * UIProcess/mac/WebInspectorProxyMac.mm:
+        (WebKit::WebInspectorProxy::inspectedViewFrameDidChange):
+        Calculate the inspectedViewFrame to be the remaining space after WebInspector is opened
+        instead of using the original page size.
+
 2017-02-26  Alexey Proskuryakov  <[email protected]>
 
         Stop exporting C++ member variables from WKDOMTextIterator

Modified: trunk/Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm (213024 => 213025)


--- trunk/Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm	2017-02-27 06:03:23 UTC (rev 213024)
+++ trunk/Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm	2017-02-27 06:31:44 UTC (rev 213025)
@@ -575,7 +575,7 @@
 
         // Preserve the top position of the inspected view so banners in Safari still work. But don't use that
         // top position for the inspector view since the banners only stretch as wide as the the inspected view.
-        inspectedViewFrame = NSMakeRect(inspectorWidth, 0, NSWidth(inspectedViewFrame), inspectedViewTop);
+        inspectedViewFrame = NSMakeRect(inspectorWidth, 0, parentWidth - inspectorWidth, inspectedViewTop);
         CGFloat insetExcludingBanners = 0;
         if ([inspectedView isKindOfClass:[WKView class]])
             insetExcludingBanners = ((WKView *)inspectedView)._topContentInset - ((WKView *)inspectedView)._totalHeightOfBanners;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to