Skip to site navigation (Press enter)

[webkit-changes] [213067] trunk

jfbastien Mon, 27 Feb 2017 08:52:40 -0800

Title: [213067] trunk

Revision: 213067
Author: [email protected]
Date: 2017-02-27 08:52:46 -0800 (Mon, 27 Feb 2017)

Log Message

WebAssembly: miscellaneous spec fixes part deux
https://bugs.webkit.org/show_bug.cgi?id=168861


Reviewed by Keith Miller.

JSTests:

* wasm.yaml: more passing tests
* wasm/Builder.js: use a Map instead of an Object for the function
index space, because Number entries such as 0 were colliding with
string entries such as "0". This in turn requires some hashing of
objects which are inserted, because Map uses Object's insertion
order when comparing.
(export.default.Builder):
(export.default.Builder.prototype._functionIndexSpaceKeyHash):
(export.default.Builder.prototype._registerFunctionToIndexSpace):
(export.default.Builder.prototype._getFunctionFromIndexSpace):
* wasm/js-api/test_Instance.js: add a FIXME test
* wasm/spec-tests/memory.wast.js:
(assert_unlinkable):
* wasm/spec-tests/names.wast.js:

Source/_javascript_Core:

* wasm/WasmFunctionParser.h: add some FIXME

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/wasm/Builder.js
trunk/JSTests/wasm/js-api/test_Instance.js
trunk/JSTests/wasm/spec-tests/memory.wast.js
trunk/JSTests/wasm/spec-tests/names.wast.js
trunk/JSTests/wasm.yaml
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wasm/WasmFunctionParser.h

Diff

Modified: trunk/JSTests/ChangeLog (213066 => 213067)


--- trunk/JSTests/ChangeLog	2017-02-27 16:29:10 UTC (rev 213066)
+++ trunk/JSTests/ChangeLog	2017-02-27 16:52:46 UTC (rev 213067)
@@ -1,3 +1,25 @@
+2017-02-27  JF Bastien  <[email protected]>
+
+        WebAssembly: miscellaneous spec fixes part deux
+        https://bugs.webkit.org/show_bug.cgi?id=168861
+
+        Reviewed by Keith Miller.
+
+        * wasm.yaml: more passing tests
+        * wasm/Builder.js: use a Map instead of an Object for the function
+        index space, because Number entries such as 0 were colliding with
+        string entries such as "0". This in turn requires some hashing of
+        objects which are inserted, because Map uses Object's insertion
+        order when comparing.
+        (export.default.Builder):
+        (export.default.Builder.prototype._functionIndexSpaceKeyHash):
+        (export.default.Builder.prototype._registerFunctionToIndexSpace):
+        (export.default.Builder.prototype._getFunctionFromIndexSpace):
+        * wasm/js-api/test_Instance.js: add a FIXME test
+        * wasm/spec-tests/memory.wast.js:
+        (assert_unlinkable):
+        * wasm/spec-tests/names.wast.js:
+
 2017-02-26  Caio Lima  <[email protected]>
 
         op_get_by_id_with_this should use inline caching

Modified: trunk/JSTests/wasm/Builder.js (213066 => 213067)


--- trunk/JSTests/wasm/Builder.js	2017-02-27 16:29:10 UTC (rev 213066)
+++ trunk/JSTests/wasm/Builder.js	2017-02-27 16:52:46 UTC (rev 213067)
@@ -423,7 +423,7 @@
             preamble[p.name] = p.value;
         this.setPreamble(preamble);
         this._sections = [];
-        this._functionIndexSpace = {};
+        this._functionIndexSpace = new Map();
         this._functionIndexSpaceCount = 0;
         this._registerSectionBuilders();
     }
@@ -435,18 +435,29 @@
         this._preamble = Object.assign(this._preamble || {}, p);
         return this;
     }
+    _functionIndexSpaceKeyHash(obj) {
+        // We don't need a full hash, just something that has a defined order for Map. Objects we insert aren't nested.
+        if (typeof(obj) !== 'object')
+            return obj;
+        const keys = Object.keys(obj).sort();
+        let entries = [];
+        for (let k in keys)
+            entries.push([k, obj[k]]);
+        return JSON.stringify(entries);
+    }
     _registerFunctionToIndexSpace(name) {
         if (typeof(name) === "undefined") {
             // Registering a nameless function still adds it to the function index space. Register it as something that can't normally be registered.
             name = {};
         }
+        const value = this._functionIndexSpaceCount++;
         // Collisions are fine: we'll simply count the function and forget the previous one.
-        this._functionIndexSpace[name] = this._functionIndexSpaceCount++;
+        this._functionIndexSpace.set(this._functionIndexSpaceKeyHash(name), value);
         // Map it both ways, the number space is distinct from the name space.
-        this._functionIndexSpace[this._functionIndexSpace[name]] = name;
+        this._functionIndexSpace.set(this._functionIndexSpaceKeyHash(value), name);
     }
     _getFunctionFromIndexSpace(name) {
-        return this._functionIndexSpace[name];
+        return this._functionIndexSpace.get(this._functionIndexSpaceKeyHash(name));
     }
     _registerSectionBuilders() {
         for (const section in WASM.description.section) {

Modified: trunk/JSTests/wasm/js-api/test_Instance.js (213066 => 213067)


--- trunk/JSTests/wasm/js-api/test_Instance.js	2017-02-27 16:29:10 UTC (rev 213066)
+++ trunk/JSTests/wasm/js-api/test_Instance.js	2017-02-27 16:52:46 UTC (rev 213067)
@@ -30,6 +30,33 @@
     assert.eq(result, 42);
 })();
 
+// FIXME exporting a property with a name that's a number doesn't work https://bugs.webkit.org/show_bug.cgi?id=168857
+/*
+(function ExportedNumber() {
+    for (let i = 0; i <= 129; ++i) {
+        const name = i.toString();
+        const builder = (new Builder())
+             .Type().End()
+             .Function().End()
+             .Export()
+                 .Function(name)
+             .End()
+             .Code()
+                 .Function(name, { params: [], ret: "i32" })
+                 .I32Const(i)
+                 .Return()
+             .End()
+             .End();
+        const bin = builder.WebAssembly().get();
+        const module = new WebAssembly.Module(bin);
+        const instance = new WebAssembly.Instance(module);
+        const result = instance.exports[name]();
+        assert.isA(result, "number");
+        assert.eq(result, i);
+    }
+})();
+*/
+
 const wasmModuleWhichImportJS = () => {
     const builder = (new Builder())
         .Type().End()

Modified: trunk/JSTests/wasm/spec-tests/memory.wast.js (213066 => 213067)


--- trunk/JSTests/wasm/spec-tests/memory.wast.js	2017-02-27 16:29:10 UTC (rev 213066)
+++ trunk/JSTests/wasm/spec-tests/memory.wast.js	2017-02-27 16:52:46 UTC (rev 213067)
@@ -56,7 +56,7 @@
 function assert_unlinkable(bytes) {
   let mod = module(bytes);
   try { new WebAssembly.Instance(mod, registry) } catch (e) {
-    if (e instanceof TypeError) return;
+    if (e instanceof WebAssembly.LinkError) return; // Note: this is fixed in tip-of-tree wabt.
   }
   throw new Error("Wasm linking failure expected");
 }
@@ -142,15 +142,17 @@
 $$ = instance("\x00\x61\x73\x6d\x01\x00\x00\x00\x01\x04\x01\x60\x00\x00\x03\x02\x01\x00\x05\x03\x01\x00\x00\x0a\x0a\x01\x08\x00\x41\x00\x2f\x01\x00\x1a\x0b");
 $$ = instance("\x00\x61\x73\x6d\x01\x00\x00\x00\x01\x04\x01\x60\x00\x00\x03\x02\x01\x00\x05\x03\x01\x00\x00\x0a\x0a\x01\x08\x00\x41\x00\x28\x02\x00\x1a\x0b");
 $$ = instance("\x00\x61\x73\x6d\x01\x00\x00\x00\x01\x04\x01\x60\x00\x00\x03\x02\x01\x00\x05\x03\x01\x00\x00\x0a\x0a\x01\x08\x00\x41\x00\x2a\x02\x00\x1a\x0b");
-assert_invalid("\x00\x61\x73\x6d\x01\x00\x00\x00\x01\x04\x01\x60\x00\x00\x03\x02\x01\x00\x05\x03\x01\x00\x00\x0a\x0a\x01\x08\x00\x41\x00\x29\x04\x00\x1a\x0b");
-assert_invalid("\x00\x61\x73\x6d\x01\x00\x00\x00\x01\x04\x01\x60\x00\x00\x03\x02\x01\x00\x05\x03\x01\x00\x00\x0a\x0a\x01\x08\x00\x41\x00\x29\x05\x00\x1a\x0b");
-assert_invalid("\x00\x61\x73\x6d\x01\x00\x00\x00\x01\x04\x01\x60\x00\x00\x03\x02\x01\x00\x05\x03\x01\x00\x00\x0a\x0a\x01\x08\x00\x41\x00\x28\x03\x00\x1a\x0b");
-assert_invalid("\x00\x61\x73\x6d\x01\x00\x00\x00\x01\x04\x01\x60\x00\x00\x03\x02\x01\x00\x05\x03\x01\x00\x00\x0a\x0a\x01\x08\x00\x41\x00\x2f\x02\x00\x1a\x0b");
-assert_invalid("\x00\x61\x73\x6d\x01\x00\x00\x00\x01\x04\x01\x60\x00\x00\x03\x02\x01\x00\x05\x03\x01\x00\x00\x0a\x0a\x01\x08\x00\x41\x00\x2d\x01\x00\x1a\x0b");
-assert_invalid("\x00\x61\x73\x6d\x01\x00\x00\x00\x01\x04\x01\x60\x00\x00\x03\x02\x01\x00\x05\x03\x01\x00\x00\x0a\x0b\x01\x09\x00\x41\x00\x41\x00\x3a\x01\x00\x0b");
+// FIXME validate alignment. https://bugs.webkit.org/show_bug.cgi?id=168836
+//assert_invalid("\x00\x61\x73\x6d\x01\x00\x00\x00\x01\x04\x01\x60\x00\x00\x03\x02\x01\x00\x05\x03\x01\x00\x00\x0a\x0a\x01\x08\x00\x41\x00\x29\x04\x00\x1a\x0b");
+//assert_invalid("\x00\x61\x73\x6d\x01\x00\x00\x00\x01\x04\x01\x60\x00\x00\x03\x02\x01\x00\x05\x03\x01\x00\x00\x0a\x0a\x01\x08\x00\x41\x00\x29\x05\x00\x1a\x0b");
+//assert_invalid("\x00\x61\x73\x6d\x01\x00\x00\x00\x01\x04\x01\x60\x00\x00\x03\x02\x01\x00\x05\x03\x01\x00\x00\x0a\x0a\x01\x08\x00\x41\x00\x28\x03\x00\x1a\x0b");
+//assert_invalid("\x00\x61\x73\x6d\x01\x00\x00\x00\x01\x04\x01\x60\x00\x00\x03\x02\x01\x00\x05\x03\x01\x00\x00\x0a\x0a\x01\x08\x00\x41\x00\x2f\x02\x00\x1a\x0b");
+//assert_invalid("\x00\x61\x73\x6d\x01\x00\x00\x00\x01\x04\x01\x60\x00\x00\x03\x02\x01\x00\x05\x03\x01\x00\x00\x0a\x0a\x01\x08\x00\x41\x00\x2d\x01\x00\x1a\x0b");
+//assert_invalid("\x00\x61\x73\x6d\x01\x00\x00\x00\x01\x04\x01\x60\x00\x00\x03\x02\x01\x00\x05\x03\x01\x00\x00\x0a\x0b\x01\x09\x00\x41\x00\x41\x00\x3a\x01\x00\x0b");
 assert_invalid("\x00\x61\x73\x6d\x01\x00\x00\x00\x01\x04\x01\x60\x00\x00\x03\x02\x01\x00\x05\x03\x01\x00\x00\x0a\x09\x01\x07\x00\x41\x00\x2f\x02\x00\x0b");
 assert_invalid("\x00\x61\x73\x6d\x01\x00\x00\x00\x01\x04\x01\x60\x00\x00\x03\x02\x01\x00\x05\x03\x01\x00\x00\x0a\x09\x01\x07\x00\x41\x00\x2d\x01\x00\x0b");
-assert_invalid("\x00\x61\x73\x6d\x01\x00\x00\x00\x01\x04\x01\x60\x00\x00\x03\x02\x01\x00\x05\x03\x01\x00\x00\x0a\x0b\x01\x09\x00\x41\x00\x41\x00\x3a\x01\x00\x0b");
+// FIXME validate alignment. https://bugs.webkit.org/show_bug.cgi?id=168836
+//assert_invalid("\x00\x61\x73\x6d\x01\x00\x00\x00\x01\x04\x01\x60\x00\x00\x03\x02\x01\x00\x05\x03\x01\x00\x00\x0a\x0b\x01\x09\x00\x41\x00\x41\x00\x3a\x01\x00\x0b");
 $$ = instance("\x00\x61\x73\x6d\x01\x00\x00\x00\x01\x16\x05\x60\x00\x01\x7f\x60\x00\x01\x7c\x60\x01\x7f\x01\x7f\x60\x01\x7e\x01\x7e\x60\x00\x00\x03\x1b\x1a\x00\x00\x00\x01\x02\x02\x02\x02\x03\x03\x03\x03\x03\x03\x04\x04\x04\x04\x04\x04\x04\x04\x04\x04\x04\x04\x05\x03\x01\x00\x01\x07\xbd\x02\x1a\x04\x64\x61\x74\x61\x00\x00\x07\x61\x6c\x69\x67\x6e\x65\x64\x00\x01\x09\x75\x6e\x61\x6c\x69\x67\x6e\x65\x64\x00\x02\x04\x63\x61\x73\x74\x00\x03\x0b\x69\x33\x32\x5f\x6c\x6f\x61\x64\x38\x5f\x73\x00\x04\x0b\x69\x33\x32\x5f\x6c\x6f\x61\x64\x38\x5f\x75\x00\x05\x0c\x69\x33\x32\x5f\x6c\x6f\x61\x64\x31\x36\x5f\x73\x00\x06\x0c\x69\x33\x32\x5f\x6c\x6f\x61\x64\x31\x36\x5f\x75\x00\x07\x0b\x69\x36\x34\x5f\x6c\x6f\x61\x64\x38\x5f\x73\x00\x08\x0b\x69\x36\x34\x5f\x6c\x6f\x61\x64\x38\x5f\x75\x00\x09\x0c\x69\x36\x34\x5f\x6c\x6f\x61\x64\x31\x36\x5f\x73\x00\x0a\x0c\x69\x36\x34\x5f\x6c\x6f\x61\x64\x31\x36\x5f\x75\x00\x0b\x0c\x69\x36\x34\x5f\x6c\x6f\x61\x64\x33\x32\x5f\x73\x00\x
 0c\x0c\x69\x36\x34\x5f\x6c\x6f\x61\x64\x33\x32\x5f\x75\x00\x0d\x08\x61\x73\x73\x65\x72\x74\x5f\x30\x00\x0e\x08\x61\x73\x73\x65\x72\x74\x5f\x31\x00\x0f\x08\x61\x73\x73\x65\x72\x74\x5f\x32\x00\x10\x08\x61\x73\x73\x65\x72\x74\x5f\x33\x00\x11\x08\x61\x73\x73\x65\x72\x74\x5f\x34\x00\x12\x08\x61\x73\x73\x65\x72\x74\x5f\x35\x00\x13\x08\x61\x73\x73\x65\x72\x74\x5f\x36\x00\x14\x08\x61\x73\x73\x65\x72\x74\x5f\x37\x00\x15\x08\x61\x73\x73\x65\x72\x74\x5f\x38\x00\x16\x08\x61\x73\x73\x65\x72\x74\x5f\x39\x00\x17\x09\x61\x73\x73\x65\x72\x74\x5f\x31\x30\x00\x18\x09\x61\x73\x73\x65\x72\x74\x5f\x31\x31\x00\x19\x0a\x9a\x05\x1a\x4e\x00\x41\x00\x2d\x00\x00\x41\xc1\x00\x46\x41\x03\x2d\x00\x00\x41\xa7\x01\x46\x71\x41\x06\x2d\x00\x00\x41\x00\x46\x41\x13\x2d\x00\x00\x41\x00\x46\x71\x71\x41\x14\x2d\x00\x00\x41\xd7\x00\x46\x41\x17\x2d\x00\x00\x41\xcd\x00\x46\x71\x41\x18\x2d\x00\x00\x41\x00\x46\x41\xff\x07\x2d\x00\x00\x41\x00\x46\x71\x71\x71\x0b\x43\x01\x03\x7f\x41\x0a\x21\x00\x02\x40\x03\x40\x20\x00\x4
 1\x00\x46\x04\x40\x0c\x02\x0b\x20\x00\x41\x04\x6c\x21\x02\x20\x02\x20\x00\x36\x02\x00\x20\x02\x28\x02\x00\x21\x01\x20\x00\x20\x01\x47\x04\x40\x41\x00\x0f\x0b\x20\x00\x41\x01\x6b\x21\x00\x0c\x00\x0b\x0b\x41\x01\x0b\x43\x02\x01\x7f\x02\x7c\x41\x0a\x21\x00\x02\x40\x03\x40\x20\x00\x41\x00\x46\x04\x40\x0c\x02\x0b\x20\x00\xb7\x21\x02\x20\x00\x20\x02\x39\x00\x00\x20\x00\x2b\x00\x00\x21\x01\x20\x02\x20\x01\x62\x04\x40\x41\x00\x0f\x0b\x20\x00\x41\x01\x6b\x21\x00\x0c\x00\x0b\x0b\x41\x01\x0b\x38\x00\x41\x08\x42\xc7\x9f\x7f\x37\x03\x00\x41\x08\x2b\x03\x00\x42\xc7\x9f\x7f\xbf\x61\x04\x40\x44\x00\x00\x00\x00\x00\x00\x00\x00\x0f\x0b\x41\x09\x42\x00\x37\x00\x00\x41\x0f\x41\xc5\x80\x01\x3b\x00\x00\x41\x09\x2b\x00\x00\x0b\x0e\x00\x41\x08\x20\x00\x3a\x00\x00\x41\x08\x2c\x00\x00\x0b\x0e\x00\x41\x08\x20\x00\x3a\x00\x00\x41\x08\x2d\x00\x00\x0b\x0e\x00\x41\x08\x20\x00\x3b\x01\x00\x41\x08\x2e\x01\x00\x0b\x0e\x00\x41\x08\x20\x00\x3b\x01\x00\x41\x08\x2f\x01\x00\x0b\x0e\x00\x41\x08\x20\x00\x3c\x00\x00
 \x41\x08\x30\x00\x00\x0b\x0e\x00\x41\x08\x20\x00\x3c\x00\x00\x41\x08\x31\x00\x00\x0b\x0e\x00\x41\x08\x20\x00\x3d\x01\x00\x41\x08\x32\x01\x00\x0b\x0e\x00\x41\x08\x20\x00\x3d\x01\x00\x41\x08\x33\x01\x00\x0b\x0e\x00\x41\x08\x20\x00\x3e\x02\x00\x41\x08\x34\x02\x00\x0b\x0e\x00\x41\x08\x20\x00\x3e\x02\x00\x41\x08\x35\x02\x00\x0b\x11\x00\x02\x40\x42\x7f\x10\x08\x42\x7f\x51\x45\x0d\x00\x0f\x0b\x00\x0b\x12\x00\x02\x40\x42\x7f\x10\x09\x42\xff\x01\x51\x45\x0d\x00\x0f\x0b\x00\x0b\x11\x00\x02\x40\x42\x7f\x10\x0a\x42\x7f\x51\x45\x0d\x00\x0f\x0b\x00\x0b\x13\x00\x02\x40\x42\x7f\x10\x0b\x42\xff\xff\x03\x51\x45\x0d\x00\x0f\x0b\x00\x0b\x11\x00\x02\x40\x42\x7f\x10\x0c\x42\x7f\x51\x45\x0d\x00\x0f\x0b\x00\x0b\x15\x00\x02\x40\x42\x7f\x10\x0d\x42\xff\xff\xff\xff\x0f\x51\x45\x0d\x00\x0f\x0b\x00\x0b\x13\x00\x02\x40\x42\xe4\x00\x10\x08\x42\xe4\x00\x51\x45\x0d\x00\x0f\x0b\x00\x0b\x13\x00\x02\x40\x42\xc8\x01\x10\x09\x42\xc8\x01\x51\x45\x0d\x00\x0f\x0b\x00\x0b\x15\x00\x02\x40\x42\xa0\x9c\x01\x10\x0a\x42\
 xa0\x9c\x01\x51\x45\x0d\x00\x0f\x0b\x00\x0b\x15\x00\x02\x40\x42\xc0\xb8\x02\x10\x0b\x42\xc0\xb8\x02\x51\x45\x0d\x00\x0f\x0b\x00\x0b\x15\x00\x02\x40\x42\xa0\x9c\x01\x10\x0c\x42\xa0\x9c\x01\x51\x45\x0d\x00\x0f\x0b\x00\x0b\x15\x00\x02\x40\x42\xc0\xb8\x02\x10\x0d\x42\xc0\xb8\x02\x51\x45\x0d\x00\x0f\x0b\x00\x0b\x0b\x14\x02\x00\x41\x00\x0b\x05\x41\x42\x43\xa7\x44\x00\x41\x14\x0b\x04\x57\x41\x53\x4d");
 assert_return(() => $$.exports["data"](), 1);
 assert_return(() => $$.exports["aligned"](), 1);

Modified: trunk/JSTests/wasm/spec-tests/names.wast.js (213066 => 213067)


--- trunk/JSTests/wasm/spec-tests/names.wast.js	2017-02-27 16:29:10 UTC (rev 213066)
+++ trunk/JSTests/wasm/spec-tests/names.wast.js	2017-02-27 16:52:46 UTC (rev 213067)
@@ -102,7 +102,8 @@
 assert_return(() => $$.exports["_malloc"](), f32(6.296875));
 assert_return(() => $$.exports["__malloc"](), f32(6.3125));
 assert_return(() => $$.exports["~!@#$%^&*()_+`-={}|[]\x5c:\x22;'<>?,./ "](), f32(6.34375));
-assert_return(() => $$.exports["0"](), f32(6.359375));
+// FIXME exporting a property with a name that's a number doesn't work https://bugs.webkit.org/show_bug.cgi?id=168857
+//assert_return(() => $$.exports["0"](), f32(6.359375));
 assert_return(() => $$.exports["_"](), f32(6.375));
 assert_return(() => $$.exports["$"](), f32(6.390625));
 assert_return(() => $$.exports["@"](), f32(8.0));

Modified: trunk/JSTests/wasm.yaml (213066 => 213067)


--- trunk/JSTests/wasm.yaml	2017-02-27 16:29:10 UTC (rev 213066)
+++ trunk/JSTests/wasm.yaml	2017-02-27 16:52:46 UTC (rev 213067)
@@ -133,13 +133,13 @@
   cmd: runWebAssemblySpecTest :normal
 
 - path: wasm/spec-tests/linking.wast.js
-  cmd: runWebAssemblySpecTest :skip
+  cmd: runWebAssemblySpecTest :skip # FIXME This test is mostly blocked on implementing re-exporting an import. https://bugs.webkit.org/show_bug.cgi?id=165510
 
 - path: wasm/spec-tests/loop.wast.js
   cmd: runWebAssemblySpecTest :normal
 
 - path: wasm/spec-tests/memory.wast.js
-  cmd: runWebAssemblySpecTest :skip
+  cmd: runWebAssemblySpecTest :normal
 
 - path: wasm/spec-tests/memory_redundancy.wast.js
   cmd: runWebAssemblySpecTest :normal
@@ -148,7 +148,7 @@
   cmd: runWebAssemblySpecTest :normal
 
 - path: wasm/spec-tests/names.wast.js
-  cmd: runWebAssemblySpecTest :skip
+  cmd: runWebAssemblySpecTest :normal
 
 - path: wasm/spec-tests/nop.wast.js
   cmd: runWebAssemblySpecTest :normal

Modified: trunk/Source/_javascript_Core/ChangeLog (213066 => 213067)


--- trunk/Source/_javascript_Core/ChangeLog	2017-02-27 16:29:10 UTC (rev 213066)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-02-27 16:52:46 UTC (rev 213067)
@@ -1,3 +1,12 @@
+2017-02-27  JF Bastien  <[email protected]>
+
+        WebAssembly: miscellaneous spec fixes part deux
+        https://bugs.webkit.org/show_bug.cgi?id=168861
+
+        Reviewed by Keith Miller.
+
+        * wasm/WasmFunctionParser.h: add some FIXME
+
 2017-02-27  Alex Christensen  <[email protected]>
 
         [libwebrtc] Enable WebRTC in some Production Builds

Modified: trunk/Source/_javascript_Core/wasm/WasmFunctionParser.h (213066 => 213067)


--- trunk/Source/_javascript_Core/wasm/WasmFunctionParser.h	2017-02-27 16:29:10 UTC (rev 213066)
+++ trunk/Source/_javascript_Core/wasm/WasmFunctionParser.h	2017-02-27 16:52:46 UTC (rev 213067)
@@ -212,6 +212,7 @@
         ExpressionType pointer;
         ExpressionType result;
         WASM_PARSER_FAIL_IF(!parseVarUInt32(alignment), "can't get load alignment");
+        // FIXME validate alignment. https://bugs.webkit.org/show_bug.cgi?id=168836
         WASM_PARSER_FAIL_IF(!parseVarUInt32(offset), "can't get load offset");
         WASM_TRY_POP_EXPRESSION_STACK_INTO(pointer, "load pointer");
         WASM_TRY_ADD_TO_CONTEXT(load(static_cast<LoadOpType>(op), pointer, result, offset));
@@ -225,6 +226,7 @@
         ExpressionType value;
         ExpressionType pointer;
         WASM_PARSER_FAIL_IF(!parseVarUInt32(alignment), "can't get store alignment");
+        // FIXME validate alignment. https://bugs.webkit.org/show_bug.cgi?id=168836
         WASM_PARSER_FAIL_IF(!parseVarUInt32(offset), "can't get store offset");
         WASM_TRY_POP_EXPRESSION_STACK_INTO(value, "store value");
         WASM_TRY_POP_EXPRESSION_STACK_INTO(pointer, "store pointer");

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes