[webkit-changes] [99217] trunk/Source/WebCore

[pfeldman]

Title: [99217] trunk/Source/WebCore

Revision

99217

Author

pfeld...@chromium.org

Date

2011-11-03 10:42:20 -0700 (Thu, 03 Nov 2011)

Log Message

Web Inspector: fix heap profiler rendering and resize.
https://bugs.webkit.org/show_bug.cgi?id=71484

Reviewed by Yury Semikhatsky.

* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.DetailedHeapshotView.prototype.wasShown.profileCallback2):
(WebInspector.DetailedHeapshotView.prototype.wasShown):
(WebInspector.DetailedHeapshotView.prototype._changeView):
(WebInspector.DetailedHeapshotView.prototype._startRetainersHeaderDragging):

Modified Paths

• trunk/Source/WebCore/ChangeLog
• trunk/Source/WebCore/inspector/front-end/DetailedHeapshotView.js

Diff

Modified: trunk/Source/WebCore/ChangeLog (99216 => 99217)

--- trunk/Source/WebCore/ChangeLog	2011-11-03 17:41:41 UTC (rev 99216)
+++ trunk/Source/WebCore/ChangeLog	2011-11-03 17:42:20 UTC (rev 99217)
@@ -1,3 +1,16 @@
+2011-11-03  Pavel Feldman  <pfeld...@google.com>
+
+        Web Inspector: fix heap profiler rendering and resize.
+        https://bugs.webkit.org/show_bug.cgi?id=71484
+
+        Reviewed by Yury Semikhatsky.
+
+        * inspector/front-end/DetailedHeapshotView.js:
+        (WebInspector.DetailedHeapshotView.prototype.wasShown.profileCallback2):
+        (WebInspector.DetailedHeapshotView.prototype.wasShown):
+        (WebInspector.DetailedHeapshotView.prototype._changeView):
+        (WebInspector.DetailedHeapshotView.prototype._startRetainersHeaderDragging):
+
 2011-11-03  Julien Chaffraix  <jchaffr...@webkit.org>
 
         Stop abusing RenderTableSection::needsRecalcCells logic

Modified: trunk/Source/WebCore/inspector/front-end/DetailedHeapshotView.js (99216 => 99217)

--- trunk/Source/WebCore/inspector/front-end/DetailedHeapshotView.js	2011-11-03 17:41:41 UTC (rev 99216)
+++ trunk/Source/WebCore/inspector/front-end/DetailedHeapshotView.js	2011-11-03 17:42:20 UTC (rev 99217)
@@ -750,7 +750,7 @@
         }
 
         function profileCallback2() {
-            this.currentView.show(this.element);
+            this.currentView.show(this.viewsContainer);
         }
     },
 
@@ -1062,7 +1062,7 @@
         var view = this.views[this.views.current];
         this.currentView = view.view;
         this.dataGrid = view.grid;
-        this.currentView.show(this.element);
+        this.currentView.show(this.viewsContainer);
         this.refreshVisibleData();
         this.dataGrid.updateWidths();
 
@@ -1202,7 +1202,7 @@
 
     _startRetainersHeaderDragging: function(event)
     {
-        if (!this.visible || event.target === this.retainingPathsRoot)
+        if (!this.isShowing() || event.target === this.retainingPathsRoot)
             return;
 
         WebInspector.elementDragStart(this.retainmentViewHeader, this._retainersHeaderDragging.bind(this), this._endRetainersHeaderDragging.bind(this), event, "row-resize");

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes