Title: [213075] trunk/Tools
- Revision
- 213075
- Author
- [email protected]
- Date
- 2017-02-27 09:36:26 -0800 (Mon, 27 Feb 2017)
Log Message
Unreviewed. Fix two GTK+ unit tests failing after r213062.
We were building wrong Content-Disposition headers that libsoup doesn't parse correctly.
* TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
(addContentDispositionHTTPHeaderToResponse):
* TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
(serverCallback):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (213074 => 213075)
--- trunk/Tools/ChangeLog 2017-02-27 17:21:55 UTC (rev 213074)
+++ trunk/Tools/ChangeLog 2017-02-27 17:36:26 UTC (rev 213075)
@@ -1,3 +1,14 @@
+2017-02-27 Carlos Garcia Campos <[email protected]>
+
+ Unreviewed. Fix two GTK+ unit tests failing after r213062.
+
+ We were building wrong Content-Disposition headers that libsoup doesn't parse correctly.
+
+ * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
+ (addContentDispositionHTTPHeaderToResponse):
+ * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
+ (serverCallback):
+
2017-02-24 Jer Noble <[email protected]>
Add public method to MediaTime for doing timeScale conversion.
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp (213074 => 213075)
--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp 2017-02-27 17:21:55 UTC (rev 213074)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp 2017-02-27 17:36:26 UTC (rev 213075)
@@ -384,7 +384,7 @@
static void addContentDispositionHTTPHeaderToResponse(SoupMessage* message)
{
- GUniquePtr<char> contentDisposition(g_strdup_printf("filename=%s", kServerSuggestedFilename));
+ GUniquePtr<char> contentDisposition(g_strdup_printf("attachment; filename=%s", kServerSuggestedFilename));
soup_message_headers_append(message->response_headers, "Content-Disposition", contentDisposition.get());
}
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp (213074 => 213075)
--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp 2017-02-27 17:21:55 UTC (rev 213074)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp 2017-02-27 17:36:26 UTC (rev 213075)
@@ -786,7 +786,7 @@
} else if (g_str_equal(path, "/_javascript_.js") || g_str_equal(path, "/_javascript_-after-redirection.js")) {
soup_message_body_append(message->response_body, SOUP_MEMORY_STATIC, kJavascript, strlen(kJavascript));
soup_message_headers_append(message->response_headers, "Content-Type", "text/_javascript_");
- soup_message_headers_append(message->response_headers, "Content-Disposition", "filename=_javascript_.js");
+ soup_message_headers_append(message->response_headers, "Content-Disposition", "attachment; filename=_javascript_.js");
} else if (g_str_equal(path, "/relative-_javascript_.html")) {
static const char* _javascript_RelativeHTML = "<html><head><script language='_javascript_' src=''></script></head><body></body></html>";
soup_message_body_append(message->response_body, SOUP_MEMORY_STATIC, _javascript_RelativeHTML, strlen(_javascript_RelativeHTML));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
