Title: [213091] trunk
Revision
213091
Author
[email protected]
Date
2017-02-27 13:32:53 -0800 (Mon, 27 Feb 2017)

Log Message

Unreviewed, roll out r213065.

Source/WebKit2:

* UIProcess/ios/WKContentViewInteraction.h:

Tools:

We need these temporary fixes to keep the perf bots running.

* TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
* TestWebKitAPI/ios/DataInteractionSimulator.h:
* TestWebKitAPI/ios/DataInteractionSimulator.mm:
(-[DataInteractionSimulator _advanceProgress]):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (213090 => 213091)


--- trunk/Source/WebKit2/ChangeLog	2017-02-27 21:26:40 UTC (rev 213090)
+++ trunk/Source/WebKit2/ChangeLog	2017-02-27 21:32:53 UTC (rev 213091)
@@ -1,3 +1,9 @@
+2017-02-27  Wenson Hsieh  <[email protected]>
+
+        Unreviewed, roll out r213065.
+
+        * UIProcess/ios/WKContentViewInteraction.h:
+
 2017-02-27  Alexey Proskuryakov  <[email protected]>
 
         Remove some deprecated WKPage plug-in information functions

Modified: trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h (213090 => 213091)


--- trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h	2017-02-27 21:26:40 UTC (rev 213090)
+++ trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h	2017-02-27 21:32:53 UTC (rev 213091)
@@ -189,7 +189,9 @@
 #if ENABLE(DATA_INTERACTION)
     WebKit::WKDataInteractionState _dataInteractionState;
     BOOL _isPerformingDataInteractionOperation;
+#if HAS_DATA_INTERACTION_SPI
     RetainPtr<WKDataInteraction> _dataInteraction;
+#endif
     CGPoint _deferredActionSheetRequestLocation;
 #endif
 }
@@ -198,8 +200,11 @@
 
 @interface WKContentView (WKInteraction) <UIGestureRecognizerDelegate, UIWebTouchEventsGestureRecognizerDelegate, UITextInputPrivate, UIWebFormAccessoryDelegate, UIWKInteractionViewProtocol, WKFileUploadPanelDelegate, WKActionSheetAssistantDelegate
 #if ENABLE(DATA_INTERACTION)
-    , WKDataInteractionItemVisualTarget, WKDataInteractionDelegate, WKViewDataInteractionDestinationDelegate
+    , WKDataInteractionItemVisualTarget, WKViewDataInteractionDestinationDelegate
+#if HAS_DATA_INTERACTION_SPI
+    , WKDataInteractionDelegate
 #endif
+#endif
 >
 
 @property (nonatomic, readonly) CGPoint lastInteractionLocation;

Modified: trunk/Tools/ChangeLog (213090 => 213091)


--- trunk/Tools/ChangeLog	2017-02-27 21:26:40 UTC (rev 213090)
+++ trunk/Tools/ChangeLog	2017-02-27 21:32:53 UTC (rev 213091)
@@ -1,3 +1,14 @@
+2017-02-27  Wenson Hsieh  <[email protected]>
+
+        Unreviewed, roll out r213065.
+
+        We need these temporary fixes to keep the perf bots running.
+
+        * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
+        * TestWebKitAPI/ios/DataInteractionSimulator.h:
+        * TestWebKitAPI/ios/DataInteractionSimulator.mm:
+        (-[DataInteractionSimulator _advanceProgress]):
+
 2017-02-27  Simon Fraser  <[email protected]>
 
         Add specification and status metadata to CSSProperties.json, and validate it

Modified: trunk/Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm (213090 => 213091)


--- trunk/Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm	2017-02-27 21:26:40 UTC (rev 213090)
+++ trunk/Tools/TestWebKitAPI/Tests/ios/DataInteractionTests.mm	2017-02-27 21:32:53 UTC (rev 213091)
@@ -25,7 +25,7 @@
 
 #include "config.h"
 
-#if ENABLE(DATA_INTERACTION)
+#if 0
 
 #import "DataInteractionSimulator.h"
 #import "PlatformUtilities.h"

Modified: trunk/Tools/TestWebKitAPI/ios/DataInteractionSimulator.h (213090 => 213091)


--- trunk/Tools/TestWebKitAPI/ios/DataInteractionSimulator.h	2017-02-27 21:26:40 UTC (rev 213090)
+++ trunk/Tools/TestWebKitAPI/ios/DataInteractionSimulator.h	2017-02-27 21:32:53 UTC (rev 213091)
@@ -23,7 +23,7 @@
  * THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#if ENABLE(DATA_INTERACTION)
+#if 0
 
 #import "TestWKWebView.h"
 #import <UIKit/UIItemProvider.h>

Modified: trunk/Tools/TestWebKitAPI/ios/DataInteractionSimulator.mm (213090 => 213091)


--- trunk/Tools/TestWebKitAPI/ios/DataInteractionSimulator.mm	2017-02-27 21:26:40 UTC (rev 213090)
+++ trunk/Tools/TestWebKitAPI/ios/DataInteractionSimulator.mm	2017-02-27 21:32:53 UTC (rev 213091)
@@ -26,7 +26,7 @@
 #include "config.h"
 #include "DataInteractionSimulator.h"
 
-#if ENABLE(DATA_INTERACTION)
+#if 0
 
 #import "PlatformUtilities.h"
 #import <UIKit/UIItemProvider_Private.h>
@@ -147,7 +147,7 @@
     switch (_phase) {
     case DataInteractionBeginning: {
         NSMutableArray<UIItemProvider *> *itemProviders = [NSMutableArray array];
-        NSArray<WKDataInteractionItem *> *items = [_webView _simulatedItemsForSession:_dataInteractionSession.get()];
+        NSArray *items = [_webView _simulatedItemsForSession:_dataInteractionSession.get()];
         if (!items.count) {
             _phase = DataInteractionCancelled;
             _currentProgress = 1;
@@ -155,11 +155,15 @@
             return;
         }
 
+#if HAS_DATA_INTERACTION_ITEMS
         for (WKDataInteractionItem *item in items)
             [itemProviders addObject:item.itemProvider];
+#endif
 
         _dataInteractionInfo = adoptNS([[MockDataInteractionInfo alloc] initWithProvider:itemProviders.firstObject location:self._currentLocation window:[_webView window]]);
+#if HAS_DATA_INTERACTION_ITEMS
         [_dataInteractionSession setItems:items];
+#endif
         [_webView _simulateWillBeginDataInteractionWithSession:_dataInteractionSession.get()];
         _phase = DataInteractionBegan;
         break;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to