Title: [213096] trunk/Source/WebKit
Revision
213096
Author
aakash_j...@apple.com
Date
2017-02-27 14:54:26 -0800 (Mon, 27 Feb 2017)

Log Message

Enable SUPPORTS_TEXT_BASED_API in WebKitLegacy for iOS
https://bugs.webkit.org/show_bug.cgi?id=168919

Reviewed by Tim Horton.

Source/WebKit:

* WebKit.xcodeproj/project.pbxproj: Run scripts which are run for installhdrs phase for installapi phase as well.

Source/WebKit/mac:

* Configurations/WebKitLegacy.xcconfig: Enable SUPPORTS_TEXT_BASED_API.
* migrate-headers.sh: Run the migrate-headers script for installapi phase.

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (213095 => 213096)


--- trunk/Source/WebKit/ChangeLog	2017-02-27 22:44:19 UTC (rev 213095)
+++ trunk/Source/WebKit/ChangeLog	2017-02-27 22:54:26 UTC (rev 213096)
@@ -1,3 +1,12 @@
+2017-02-27  Aakash Jain  <aakash_j...@apple.com>
+
+        Enable SUPPORTS_TEXT_BASED_API in WebKitLegacy for iOS
+        https://bugs.webkit.org/show_bug.cgi?id=168919
+
+        Reviewed by Tim Horton.
+
+        * WebKit.xcodeproj/project.pbxproj: Run scripts which are run for installhdrs phase for installapi phase as well.
+
 2017-02-22  Aakash Jain  <aakash_j...@apple.com>
 
         Export Objective-C symbols for variables in Webkit SPI

Modified: trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj (213095 => 213096)


--- trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj	2017-02-27 22:44:19 UTC (rev 213095)
+++ trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj	2017-02-27 22:54:26 UTC (rev 213096)
@@ -3338,7 +3338,7 @@
 			);
 			runOnlyForDeploymentPostprocessing = 0;
 			shellPath = /bin/sh;
-			shellScript = "if [ \"${ACTION}\" = \"installhdrs\" ]; then\n    exit 0;\nfi\n\nif [ -f ../../Tools/Scripts/check-for-inappropriate-objc-class-names ]; then\n    ../../Tools/Scripts/check-for-inappropriate-objc-class-names DOM Web _Web || exit $?\nfi";
+			shellScript = "if [ \"${ACTION}\" = \"installhdrs\" ] || [ \"${ACTION}\" = \"installapi\" ]; then\n    exit 0;\nfi\n\nif [ -f ../../Tools/Scripts/check-for-inappropriate-objc-class-names ]; then\n    ../../Tools/Scripts/check-for-inappropriate-objc-class-names DOM Web _Web || exit $?\nfi";
 		};
 		5D0D54210E98631D0029E223 /* Check For Weak VTables and Externals */ = {
 			isa = PBXShellScriptBuildPhase;
@@ -3353,7 +3353,7 @@
 			);
 			runOnlyForDeploymentPostprocessing = 0;
 			shellPath = /bin/sh;
-			shellScript = "if [ \"${ACTION}\" = \"installhdrs\" ]; then\n    exit 0;\nfi\n\nif [ -f ../../Tools/Scripts/check-for-weak-vtables-and-externals ]; then\n    ../../Tools/Scripts/check-for-weak-vtables-and-externals || exit $?\nfi";
+			shellScript = "if [ \"${ACTION}\" = \"installhdrs\" ] || [ \"${ACTION}\" = \"installapi\" ]; then\n    exit 0;\nfi\n\nif [ -f ../../Tools/Scripts/check-for-weak-vtables-and-externals ]; then\n    ../../Tools/Scripts/check-for-weak-vtables-and-externals || exit $?\nfi";
 		};
 		5D2F7DB70C687A5A00B5B72B /* Update Info.plist with version information */ = {
 			isa = PBXShellScriptBuildPhase;

Modified: trunk/Source/WebKit/mac/ChangeLog (213095 => 213096)


--- trunk/Source/WebKit/mac/ChangeLog	2017-02-27 22:44:19 UTC (rev 213095)
+++ trunk/Source/WebKit/mac/ChangeLog	2017-02-27 22:54:26 UTC (rev 213096)
@@ -1,3 +1,13 @@
+2017-02-27  Aakash Jain  <aakash_j...@apple.com>
+
+        Enable SUPPORTS_TEXT_BASED_API in WebKitLegacy for iOS
+        https://bugs.webkit.org/show_bug.cgi?id=168919
+
+        Reviewed by Tim Horton.
+
+        * Configurations/WebKitLegacy.xcconfig: Enable SUPPORTS_TEXT_BASED_API.
+        * migrate-headers.sh: Run the migrate-headers script for installapi phase.
+
 2017-02-27  Alex Christensen  <achristen...@webkit.org>
 
         [libwebrtc] Enable WebRTC in some Production Builds

Modified: trunk/Source/WebKit/mac/Configurations/WebKitLegacy.xcconfig (213095 => 213096)


--- trunk/Source/WebKit/mac/Configurations/WebKitLegacy.xcconfig	2017-02-27 22:44:19 UTC (rev 213095)
+++ trunk/Source/WebKit/mac/Configurations/WebKitLegacy.xcconfig	2017-02-27 22:54:26 UTC (rev 213096)
@@ -119,3 +119,8 @@
 
 WK_QUOTED_OVERRIDE_FRAMEWORKS_DIR = $(WK_QUOTED_OVERRIDE_FRAMEWORKS_DIR_$(WK_USE_OVERRIDE_FRAMEWORKS_DIR));
 WK_QUOTED_OVERRIDE_FRAMEWORKS_DIR_YES = "$(WK_OVERRIDE_FRAMEWORKS_DIR)";
+
+// FIXME: Enable TAPI in open source builds once <rdar://problem/24582471> is fixed in all supported SDKs.
+SUPPORTS_TEXT_BASED_API[sdk=iphone*] = $(USE_INTERNAL_SDK);
+OTHER_TAPI_FLAGS[sdk=iphone*] = -x objective-c++ -std=c++11 -fno-rtti;
+TAPI_VERIFY_MODE[sdk=iphone*] = Pedantic;

Modified: trunk/Source/WebKit/mac/migrate-headers.sh (213095 => 213096)


--- trunk/Source/WebKit/mac/migrate-headers.sh	2017-02-27 22:44:19 UTC (rev 213095)
+++ trunk/Source/WebKit/mac/migrate-headers.sh	2017-02-27 22:54:26 UTC (rev 213096)
@@ -32,7 +32,7 @@
     export WEBCORE_PRIVATE_HEADERS_DIR="`eval 'echo ${WEBCORE_PRIVATE_HEADERS_DIR_Production}'`"
 fi
 
-if [ "${ACTION}" = "build" -o "${ACTION}" = "install" -o "${ACTION}" = "installhdrs" ]; then
+if [ "${ACTION}" = "build" -o "${ACTION}" = "install" -o "${ACTION}" = "installhdrs" -o "${ACTION}" = "installapi" ]; then
     ln -sfh "${WEBCORE_PRIVATE_HEADERS_DIR}" "${BUILT_PRODUCTS_DIR}/DerivedSources/WebKitLegacy/WebCorePrivateHeaders"
     make -C mac -f "MigrateHeaders.make" -j `/usr/sbin/sysctl -n hw.activecpu`
 fi
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to