Title: [213200] trunk/LayoutTests
- Revision
- 213200
- Author
- commit-qu...@webkit.org
- Date
- 2017-02-28 17:24:30 -0800 (Tue, 28 Feb 2017)
Log Message
[mac-wk1 Debug] LayoutTest media/modern-media-controls/rewind-button/rewind-button.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=167352
<rdar://problem/30771343>
Patch by Antoine Quint <grao...@apple.com> on 2017-02-28
Reviewed by Dean Jackson.
Use the asynchronous assertion methods for this test to be on the safe side, this should address flakiness.
* media/modern-media-controls/rewind-button/rewind-button-expected.txt:
* media/modern-media-controls/rewind-button/rewind-button.html:
* platform/mac-wk1/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (213199 => 213200)
--- trunk/LayoutTests/ChangeLog 2017-03-01 01:18:18 UTC (rev 213199)
+++ trunk/LayoutTests/ChangeLog 2017-03-01 01:24:30 UTC (rev 213200)
@@ -1,3 +1,17 @@
+2017-02-28 Antoine Quint <grao...@apple.com>
+
+ [mac-wk1 Debug] LayoutTest media/modern-media-controls/rewind-button/rewind-button.html is a flaky timeout
+ https://bugs.webkit.org/show_bug.cgi?id=167352
+ <rdar://problem/30771343>
+
+ Reviewed by Dean Jackson.
+
+ Use the asynchronous assertion methods for this test to be on the safe side, this should address flakiness.
+
+ * media/modern-media-controls/rewind-button/rewind-button-expected.txt:
+ * media/modern-media-controls/rewind-button/rewind-button.html:
+ * platform/mac-wk1/TestExpectations:
+
2017-02-28 Javier Fernandez <jfernan...@igalia.com>
[GTK] Unreviewed test gardening
Modified: trunk/LayoutTests/media/modern-media-controls/rewind-button/rewind-button-expected.txt (213199 => 213200)
--- trunk/LayoutTests/media/modern-media-controls/rewind-button/rewind-button-expected.txt 2017-03-01 01:18:18 UTC (rev 213199)
+++ trunk/LayoutTests/media/modern-media-controls/rewind-button/rewind-button-expected.txt 2017-03-01 01:24:30 UTC (rev 213200)
@@ -7,7 +7,7 @@
PASS rewindButton.element.classList.contains("icon") is true
PASS rewindButton.element.classList.contains("rewind") is true
PASS rewindButton.iconName is "rewind"
-PASS rewindButton.element.style.webkitMaskImage.includes("macOS/rewind@") is true
+PASS rewindButton.element.style.webkitMaskImage.includes("macOS/rewind@") became true
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/media/modern-media-controls/rewind-button/rewind-button.html (213199 => 213200)
--- trunk/LayoutTests/media/modern-media-controls/rewind-button/rewind-button.html 2017-03-01 01:18:18 UTC (rev 213199)
+++ trunk/LayoutTests/media/modern-media-controls/rewind-button/rewind-button.html 2017-03-01 01:24:30 UTC (rev 213200)
@@ -17,15 +17,8 @@
shouldBeTrue('rewindButton.element.classList.contains("rewind")');
shouldBeEqualToString("rewindButton.iconName", `${Icons.Rewind}`);
-scheduler.frameDidFire = function()
-{
- if (rewindButton.width == 0)
- return;
+shouldBecomeEqual('rewindButton.element.style.webkitMaskImage.includes("macOS/rewind@")', "true", finishJSTest);
- shouldBeTrue('rewindButton.element.style.webkitMaskImage.includes("macOS/rewind@")');
- finishMediaControlsTest();
-};
-
</script>
<script src=""
</body>
Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (213199 => 213200)
--- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2017-03-01 01:18:18 UTC (rev 213199)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2017-03-01 01:24:30 UTC (rev 213200)
@@ -323,5 +323,4 @@
webkit.org/b/168409 media/modern-media-controls/airplay-button/airplay-button.html [ Pass Timeout ]
webkit.org/b/167589 media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-containers-styles.html [ Pass Timeout ]
webkit.org/b/168378 media/modern-media-controls/media-controller/media-controller-resize.html [ Pass Failure ]
-webkit.org/b/167352 [ Debug ] media/modern-media-controls/rewind-button/rewind-button.html [ Pass Timeout ]
webkit.org/b/168476 media/modern-media-controls/tracks-button/tracks-button.html [ Pass Timeout ]
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
