Log Message
Update peer connection preference https://bugs.webkit.org/show_bug.cgi?id=169016 rdar://problem/30773889
Reviewed by Eric Carlson. * Shared/WebPreferencesDefinitions.h: * UIProcess/WebPreferences.cpp: (WebKit::WebPreferences::setEnabledForFeature): (WebKit::WebPreferences::setPeerConnectionAndMediaStreamEnabled): Deleted. * UIProcess/WebPreferences.h:
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (213220 => 213221)
--- trunk/Source/WebKit2/ChangeLog 2017-03-01 14:38:22 UTC (rev 213220)
+++ trunk/Source/WebKit2/ChangeLog 2017-03-01 15:12:17 UTC (rev 213221)
@@ -1,3 +1,17 @@
+2017-03-01 Jon Lee <[email protected]>
+
+ Update peer connection preference
+ https://bugs.webkit.org/show_bug.cgi?id=169016
+ rdar://problem/30773889
+
+ Reviewed by Eric Carlson.
+
+ * Shared/WebPreferencesDefinitions.h:
+ * UIProcess/WebPreferences.cpp:
+ (WebKit::WebPreferences::setEnabledForFeature):
+ (WebKit::WebPreferences::setPeerConnectionAndMediaStreamEnabled): Deleted.
+ * UIProcess/WebPreferences.h:
+
2017-03-01 Tomas Popela <[email protected]>
[GTK] Fix problems found by Coverity scan in WebPrintOperationGtk.cpp
Modified: trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h (213220 => 213221)
--- trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h 2017-03-01 14:38:22 UTC (rev 213220)
+++ trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h 2017-03-01 15:12:17 UTC (rev 213221)
@@ -206,6 +206,7 @@
macro(SubpixelCSSOMElementMetricsEnabled, subpixelCSSOMElementMetricsEnabled, Bool, bool, false, "", "") \
macro(UseGiantTiles, useGiantTiles, Bool, bool, false, "", "") \
macro(MediaStreamEnabled, mediaStreamEnabled, Bool, bool, false, "", "") \
+ macro(PeerConnectionEnabled, peerConnectionEnabled, Bool, bool, false, "", "") \
macro(UseLegacyTextAlignPositionedElementBehavior, useLegacyTextAlignPositionedElementBehavior, Bool, bool, false, "", "") \
macro(SpatialNavigationEnabled, spatialNavigationEnabled, Bool, bool, false, "", "") \
macro(MediaSourceEnabled, mediaSourceEnabled, Bool, bool, true, "", "") \
@@ -323,7 +324,6 @@
macro(UserTimingEnabled, userTimingEnabled, Bool, bool, DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, "User Timing", "Enable UserTiming API") \
macro(WebAnimationsEnabled, webAnimationsEnabled, Bool, bool, false, "Web Animations", "Web Animations prototype") \
macro(WebGL2Enabled, webGL2Enabled, Bool, bool, DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, "WebGL 2.0", "WebGL 2 prototype") \
- macro(PeerConnectionEnabled, peerConnectionEnabled, Bool, bool, WebCore::LibWebRTCProvider::webRTCAvailable(), "WebRTC", "Enable WebRTC API") \
\
#if PLATFORM(COCOA)
Modified: trunk/Source/WebKit2/UIProcess/WebPreferences.cpp (213220 => 213221)
--- trunk/Source/WebKit2/UIProcess/WebPreferences.cpp 2017-03-01 14:38:22 UTC (rev 213220)
+++ trunk/Source/WebKit2/UIProcess/WebPreferences.cpp 2017-03-01 15:12:17 UTC (rev 213221)
@@ -260,12 +260,6 @@
return false;
}
-void WebPreferences::setPeerConnectionAndMediaStreamEnabled(bool value)
-{
- setPeerConnectionEnabled(value);
- setMediaStreamEnabled(value);
-}
-
void WebPreferences::setEnabledForFeature(bool value, const API::ExperimentalFeature& feature)
{
struct FeatureSetterMapping {
@@ -286,10 +280,7 @@
for (auto& setter : setters) {
if (key == setter.name) {
- if (key == WebPreferencesKey::peerConnectionEnabledKey())
- setPeerConnectionAndMediaStreamEnabled(value);
- else
- (this->*setter.function)(value);
+ (this->*setter.function)(value);
return;
}
}
Modified: trunk/Source/WebKit2/UIProcess/WebPreferences.h (213220 => 213221)
--- trunk/Source/WebKit2/UIProcess/WebPreferences.h 2017-03-01 14:38:22 UTC (rev 213220)
+++ trunk/Source/WebKit2/UIProcess/WebPreferences.h 2017-03-01 15:12:17 UTC (rev 213221)
@@ -93,8 +93,6 @@
void updatePrivateBrowsingValue(bool value);
- void setPeerConnectionAndMediaStreamEnabled(bool value);
-
void registerDefaultBoolValueForKey(const String&, bool);
void registerDefaultUInt32ValueForKey(const String&, uint32_t);
_______________________________________________ webkit-changes mailing list [email protected] https://lists.webkit.org/mailman/listinfo/webkit-changes
