Title: [213222] trunk/Source/_javascript_Core
- Revision
- 213222
- Author
- [email protected]
- Date
- 2017-03-01 07:38:14 -0800 (Wed, 01 Mar 2017)
Log Message
Leak under Options::setOptions
https://bugs.webkit.org/show_bug.cgi?id=169029
Reviewed by Michael Saboff.
Don't leak the optionsStrCopy variable.
* runtime/Options.cpp:
(JSC::Options::setOptions):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (213221 => 213222)
--- trunk/Source/_javascript_Core/ChangeLog 2017-03-01 15:12:17 UTC (rev 213221)
+++ trunk/Source/_javascript_Core/ChangeLog 2017-03-01 15:38:14 UTC (rev 213222)
@@ -1,3 +1,15 @@
+2017-03-01 Tomas Popela <[email protected]>
+
+ Leak under Options::setOptions
+ https://bugs.webkit.org/show_bug.cgi?id=169029
+
+ Reviewed by Michael Saboff.
+
+ Don't leak the optionsStrCopy variable.
+
+ * runtime/Options.cpp:
+ (JSC::Options::setOptions):
+
2017-03-01 Yusuke Suzuki <[email protected]>
[JSC] Allow UnlinkedCodeBlock to dump its bytecode sequence
Modified: trunk/Source/_javascript_Core/runtime/Options.cpp (213221 => 213222)
--- trunk/Source/_javascript_Core/runtime/Options.cpp 2017-03-01 15:12:17 UTC (rev 213221)
+++ trunk/Source/_javascript_Core/runtime/Options.cpp 2017-03-01 15:38:14 UTC (rev 213222)
@@ -557,6 +557,7 @@
p = strstr(p, "=");
if (!p) {
dataLogF("'=' not found in option string: %p\n", optionStart);
+ WTF::fastFree(optionsStrCopy);
return false;
}
p++;
@@ -568,6 +569,7 @@
p = strstr(p + 1, "\"");
if (!p) {
dataLogF("Missing trailing '\"' in option string: %p\n", optionStart);
+ WTF::fastFree(optionsStrCopy);
return false; // End of string not found.
}
hasStringValue = true;
@@ -610,6 +612,8 @@
ensureOptionsAreCoherent();
+ WTF::fastFree(optionsStrCopy);
+
return success;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
