Title: [213225] trunk/Tools
- Revision
- 213225
- Author
- [email protected]
- Date
- 2017-03-01 09:23:37 -0800 (Wed, 01 Mar 2017)
Log Message
IndexedDB.IndexedDBMultiProcess is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=160780
Reviewed by Brady Eidson.
* TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm: Releasing the object
once doesn't necessarily deallocate the object, there can be other references.
We can use -[WKWebView _close] or -[WKWebView _killWebContentProcessAndResetState].
The latter seems more appropriate, because "kill" is what the comment says.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (213224 => 213225)
--- trunk/Tools/ChangeLog 2017-03-01 17:04:43 UTC (rev 213224)
+++ trunk/Tools/ChangeLog 2017-03-01 17:23:37 UTC (rev 213225)
@@ -1,3 +1,15 @@
+2017-03-01 Alexey Proskuryakov <[email protected]>
+
+ IndexedDB.IndexedDBMultiProcess is a flaky timeout
+ https://bugs.webkit.org/show_bug.cgi?id=160780
+
+ Reviewed by Brady Eidson.
+
+ * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm: Releasing the object
+ once doesn't necessarily deallocate the object, there can be other references.
+ We can use -[WKWebView _close] or -[WKWebView _killWebContentProcessAndResetState].
+ The latter seems more appropriate, because "kill" is what the comment says.
+
2017-02-28 Srinivasan Vijayaraghavan <[email protected]>
Add ability for webkitpy to run bindings tests
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm (213224 => 213225)
--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm 2017-03-01 17:04:43 UTC (rev 213224)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm 2017-03-01 17:23:37 UTC (rev 213225)
@@ -31,6 +31,7 @@
#import <WebKit/WKProcessPoolPrivate.h>
#import <WebKit/WKUserContentControllerPrivate.h>
#import <WebKit/WKWebViewConfigurationPrivate.h>
+#import <WebKit/WKWebViewPrivate.h>
#import <WebKit/_WKProcessPoolConfiguration.h>
#import <WebKit/_WKUserStyleSheet.h>
#import <wtf/Deque.h>
@@ -106,7 +107,7 @@
EXPECT_WK_STREQ(@"Blocked!", string6.get());
// Kill the blocking web process
- webView2 = nil;
+ [webView2 _killWebContentProcessAndResetState];
RetainPtr<NSString> string7 = (NSString *)[getNextMessage() body];
EXPECT_WK_STREQ(@"Deleted!", string7.get());
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
