[webkit-changes] [213239] trunk/Source/WebCore

[commit-queue]

Title: [213239] trunk/Source/WebCore

Revision

213239

Author

commit-qu...@webkit.org

Date

2017-03-01 13:10:45 -0800 (Wed, 01 Mar 2017)

Log Message

Unreviewed, rolling out r213226.
https://bugs.webkit.org/show_bug.cgi?id=169051

Speculative rollout, might be causing several failures and
crashes in WebKitGTK+ (Requested by lajava on #webkit).

Reverted changeset:

"REGRESSION(r213062): [SOUP] UTF-8 filename in Content-
Disposition header incorrectly handled since r213062"
https://bugs.webkit.org/show_bug.cgi?id=169024
http://trac.webkit.org/changeset/213226

Modified Paths

• trunk/Source/WebCore/ChangeLog
• trunk/Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp

Diff

Modified: trunk/Source/WebCore/ChangeLog (213238 => 213239)

--- trunk/Source/WebCore/ChangeLog	2017-03-01 20:15:08 UTC (rev 213238)
+++ trunk/Source/WebCore/ChangeLog	2017-03-01 21:10:45 UTC (rev 213239)
@@ -1,3 +1,18 @@
+2017-03-01  Commit Queue  <commit-qu...@webkit.org>
+
+        Unreviewed, rolling out r213226.
+        https://bugs.webkit.org/show_bug.cgi?id=169051
+
+        Speculative rollout, might be causing several failures and
+        crashes in WebKitGTK+ (Requested by lajava on #webkit).
+
+        Reverted changeset:
+
+        "REGRESSION(r213062): [SOUP] UTF-8 filename in Content-
+        Disposition header incorrectly handled since r213062"
+        https://bugs.webkit.org/show_bug.cgi?id=169024
+        http://trac.webkit.org/changeset/213226
+
 2017-03-01  James Craig  <jcr...@apple.com>
 
         AX: add role aliases for ARIA DPUB module

Modified: trunk/Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp (213238 => 213239)

--- trunk/Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp	2017-03-01 20:15:08 UTC (rev 213238)
+++ trunk/Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp	2017-03-01 21:10:45 UTC (rev 213239)
@@ -98,8 +98,6 @@
 {
     SoupMessageHeaders* soupHeaders = soup_message_headers_new(SOUP_MESSAGE_HEADERS_RESPONSE);
     String contentDisposition(httpHeaderField(HTTPHeaderName::ContentDisposition));
-    if (contentDisposition.is8Bit())
-        contentDisposition = String::fromUTF8WithLatin1Fallback(contentDisposition.characters8(), contentDisposition.length());
     soup_message_headers_append(soupHeaders, "Content-Disposition", contentDisposition.utf8().data());
     GRefPtr<GHashTable> params;
     soup_message_headers_get_content_disposition(soupHeaders, nullptr, &params.outPtr());

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes