Title: [213289] trunk/LayoutTests
- Revision
- 213289
- Author
- [email protected]
- Date
- 2017-03-02 10:28:28 -0800 (Thu, 02 Mar 2017)
Log Message
[mac-wk1] LayoutTest media/modern-media-controls/mute-button/mute-button.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=165320
<rdar://problem/30809600>
Patch by Antoine Quint <[email protected]> on 2017-03-02
Reviewed by Dean Jackson.
Use asynchronous assertions to improve robustness.
* media/modern-media-controls/mute-button/mute-button-expected.txt:
* media/modern-media-controls/mute-button/mute-button.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (213288 => 213289)
--- trunk/LayoutTests/ChangeLog 2017-03-02 18:28:06 UTC (rev 213288)
+++ trunk/LayoutTests/ChangeLog 2017-03-02 18:28:28 UTC (rev 213289)
@@ -1,3 +1,16 @@
+2017-03-02 Antoine Quint <[email protected]>
+
+ [mac-wk1] LayoutTest media/modern-media-controls/mute-button/mute-button.html is a flaky timeout
+ https://bugs.webkit.org/show_bug.cgi?id=165320
+ <rdar://problem/30809600>
+
+ Reviewed by Dean Jackson.
+
+ Use asynchronous assertions to improve robustness.
+
+ * media/modern-media-controls/mute-button/mute-button-expected.txt:
+ * media/modern-media-controls/mute-button/mute-button.html:
+
2017-03-02 Youenn Fablet <[email protected]>
Activate some new webrtc tests
Modified: trunk/LayoutTests/media/modern-media-controls/mute-button/mute-button-expected.txt (213288 => 213289)
--- trunk/LayoutTests/media/modern-media-controls/mute-button/mute-button-expected.txt 2017-03-02 18:28:06 UTC (rev 213288)
+++ trunk/LayoutTests/media/modern-media-controls/mute-button/mute-button-expected.txt 2017-03-02 18:28:28 UTC (rev 213289)
@@ -10,8 +10,8 @@
PASS muteButton.muted is false
PASS mutedButton.muted is true
PASS mutedButton.iconName is "volume-mute"
-PASS muteButton.element.style.webkitMaskImage.includes("macOS/volume@") is true
-PASS mutedButton.element.style.webkitMaskImage.includes("macOS/volume-mute@") is true
+PASS muteButton.element.style.webkitMaskImage.includes("macOS/volume@") became true
+PASS mutedButton.element.style.webkitMaskImage.includes("macOS/volume-mute@") became true
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/media/modern-media-controls/mute-button/mute-button.html (213288 => 213289)
--- trunk/LayoutTests/media/modern-media-controls/mute-button/mute-button.html 2017-03-02 18:28:06 UTC (rev 213288)
+++ trunk/LayoutTests/media/modern-media-controls/mute-button/mute-button.html 2017-03-02 18:28:28 UTC (rev 213289)
@@ -21,16 +21,10 @@
shouldBeTrue("mutedButton.muted");
shouldBeEqualToString("mutedButton.iconName", `${Icons.VolumeMuted}`);
-scheduler.frameDidFire = function()
-{
- if ([muteButton, mutedButton].some(button => button.width == 0))
- return;
+shouldBecomeEqual('muteButton.element.style.webkitMaskImage.includes("macOS/volume@")', "true", () => {
+ shouldBecomeEqual('mutedButton.element.style.webkitMaskImage.includes("macOS/volume-mute@")', "true", finishJSTest);
+});
- shouldBeTrue('muteButton.element.style.webkitMaskImage.includes("macOS/volume@")');
- shouldBeTrue('mutedButton.element.style.webkitMaskImage.includes("macOS/volume-mute@")');
- finishMediaControlsTest();
-};
-
</script>
<script src=""
</body>
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
