Title: [99243] trunk/Source/WebKit2
- Revision
- 99243
- Author
- [email protected]
- Date
- 2011-11-03 16:17:44 -0700 (Thu, 03 Nov 2011)
Log Message
Move plug-in size and backing store checks to PluginProxy::updateBackingStore
https://bugs.webkit.org/show_bug.cgi?id=71508
Reviewed by Darin Adler.
* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::geometryDidChange):
Remove code to send back an empty backing store if the plug-in size is empty
or doesn't need a backing store. This check is now done...
(WebKit::PluginProxy::updateBackingStore):
...here.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (99242 => 99243)
--- trunk/Source/WebKit2/ChangeLog 2011-11-03 23:17:39 UTC (rev 99242)
+++ trunk/Source/WebKit2/ChangeLog 2011-11-03 23:17:44 UTC (rev 99243)
@@ -1,5 +1,20 @@
2011-11-03 Anders Carlsson <[email protected]>
+ Move plug-in size and backing store checks to PluginProxy::updateBackingStore
+ https://bugs.webkit.org/show_bug.cgi?id=71508
+
+ Reviewed by Darin Adler.
+
+ * WebProcess/Plugins/PluginProxy.cpp:
+ (WebKit::PluginProxy::geometryDidChange):
+ Remove code to send back an empty backing store if the plug-in size is empty
+ or doesn't need a backing store. This check is now done...
+
+ (WebKit::PluginProxy::updateBackingStore):
+ ...here.
+
+2011-11-03 Anders Carlsson <[email protected]>
+
Get rid of PluginControllerProxy::m_frameRectInWindowCoordinates
https://bugs.webkit.org/show_bug.cgi?id=71506
Modified: trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp (99242 => 99243)
--- trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp 2011-11-03 23:17:39 UTC (rev 99242)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PluginProxy.cpp 2011-11-03 23:17:44 UTC (rev 99243)
@@ -175,12 +175,6 @@
{
ASSERT(m_isStarted);
- if (m_pluginSize.isEmpty() || !needsBackingStore()) {
- ShareableBitmap::Handle pluginBackingStoreHandle;
- m_connection->connection()->send(Messages::PluginControllerProxy::GeometryDidChange(m_pluginSize, m_clipRect, m_pluginToRootViewTransform, contentsScaleFactor(), pluginBackingStoreHandle), m_pluginInstanceID, CoreIPC::DispatchMessageEvenWhenWaitingForSyncReply);
- return;
- }
-
ShareableBitmap::Handle pluginBackingStoreHandle;
if (updateBackingStore()) {
@@ -442,6 +436,9 @@
bool PluginProxy::updateBackingStore()
{
+ if (m_pluginSize.isEmpty() || !needsBackingStore())
+ return false;
+
IntSize backingStoreSize = m_pluginSize;
backingStoreSize.scale(contentsScaleFactor());
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
