Title: [213351] trunk/LayoutTests
- Revision
- 213351
- Author
- commit-qu...@webkit.org
- Date
- 2017-03-02 21:33:00 -0800 (Thu, 02 Mar 2017)
Log Message
LayoutTest media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=169109
<rdar://problem/30824252>
Patch by Antoine Quint <grao...@apple.com> on 2017-03-02
Reviewed by Simon Fraser.
Ensure the tracks button is sized before pressing it to make the track panel appear.
* media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel-expected.txt:
* media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (213350 => 213351)
--- trunk/LayoutTests/ChangeLog 2017-03-03 05:22:28 UTC (rev 213350)
+++ trunk/LayoutTests/ChangeLog 2017-03-03 05:33:00 UTC (rev 213351)
@@ -1,5 +1,18 @@
2017-03-02 Antoine Quint <grao...@apple.com>
+ LayoutTest media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html is a flaky timeout
+ https://bugs.webkit.org/show_bug.cgi?id=169109
+ <rdar://problem/30824252>
+
+ Reviewed by Simon Fraser.
+
+ Ensure the tracks button is sized before pressing it to make the track panel appear.
+
+ * media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel-expected.txt:
+ * media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html:
+
+2017-03-02 Antoine Quint <grao...@apple.com>
+
Remove references to tests that no longer exist and remove a duplicate test.
Unreviewed test gardening.
Modified: trunk/LayoutTests/media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel-expected.txt (213350 => 213351)
--- trunk/LayoutTests/media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel-expected.txt 2017-03-03 05:22:28 UTC (rev 213350)
+++ trunk/LayoutTests/media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel-expected.txt 2017-03-03 05:33:00 UTC (rev 213351)
@@ -7,6 +7,8 @@
media.audioTracks[1].enabled = false
media.audioTracks[2].enabled = false
+PASS shadowRoot.lastChild.querySelector('button.tracks').getBoundingClientRect().width became different from 0
+
Clicking on the tracks button
Clicking on second audio track in tracks panel
Modified: trunk/LayoutTests/media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html (213350 => 213351)
--- trunk/LayoutTests/media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html 2017-03-03 05:22:28 UTC (rev 213350)
+++ trunk/LayoutTests/media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html 2017-03-03 05:33:00 UTC (rev 213351)
@@ -19,7 +19,11 @@
dumpAudioTracksEnabledState();
media.audioTracks.addEventListener("change", audioTracksDidChange);
- clickOnTracksButton(clickOnSecondAudioTrack);
+
+ debug("");
+ shouldBecomeDifferent("shadowRoot.lastChild.querySelector('button.tracks').getBoundingClientRect().width", "0", () => {
+ clickOnTracksButton(clickOnSecondAudioTrack);
+ });
});
function clickOnTracksButton(continuation)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
