Title: [213364] trunk/LayoutTests
- Revision
- 213364
- Author
- [email protected]
- Date
- 2017-03-03 05:07:45 -0800 (Fri, 03 Mar 2017)
Log Message
LayoutTest media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=167275
<rdar://problem/30824290>
Patch by Antoine Quint <[email protected]> on 2017-03-03
Reviewed by Dean Jackson.
Ensure that we have metrics for buttons before attempting to click on them and let dragging interaction
apply changes to CSS on the next rAF before trying to pursue the next step.
* media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls-expected.txt:
* media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html:
* platform/mac/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (213363 => 213364)
--- trunk/LayoutTests/ChangeLog 2017-03-03 13:02:49 UTC (rev 213363)
+++ trunk/LayoutTests/ChangeLog 2017-03-03 13:07:45 UTC (rev 213364)
@@ -1,3 +1,18 @@
+2017-03-03 Antoine Quint <[email protected]>
+
+ LayoutTest media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html is flaky
+ https://bugs.webkit.org/show_bug.cgi?id=167275
+ <rdar://problem/30824290>
+
+ Reviewed by Dean Jackson.
+
+ Ensure that we have metrics for buttons before attempting to click on them and let dragging interaction
+ apply changes to CSS on the next rAF before trying to pursue the next step.
+
+ * media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls-expected.txt:
+ * media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html:
+ * platform/mac/TestExpectations:
+
2017-03-03 Joseph Pecoraro <[email protected]>
LayoutTest performance-api/performance-observer-basic.html is a flaky timeout
Modified: trunk/LayoutTests/media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls-expected.txt (213363 => 213364)
--- trunk/LayoutTests/media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls-expected.txt 2017-03-03 13:02:49 UTC (rev 213363)
+++ trunk/LayoutTests/media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls-expected.txt 2017-03-03 13:07:45 UTC (rev 213364)
@@ -3,7 +3,9 @@
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-PASS shadowRoot.querySelector('button.tracks').getBoundingClientRect().right === shadowRoot.querySelector('.tracks-panel').getBoundingClientRect().right is true
+PASS shadowRoot.querySelector('button.fullscreen').getBoundingClientRect() became different from 0
+PASS shadowRoot.querySelector('button.tracks').getBoundingClientRect() became different from 0
+PASS shadowRoot.querySelector('button.tracks').getBoundingClientRect().right is shadowRoot.querySelector('.tracks-panel').getBoundingClientRect().right
PASS shadowRoot.querySelector('.tracks-panel').style.bottom is "151px"
PASS successfullyParsed is true
Modified: trunk/LayoutTests/media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html (213363 => 213364)
--- trunk/LayoutTests/media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html 2017-03-03 13:02:49 UTC (rev 213363)
+++ trunk/LayoutTests/media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html 2017-03-03 13:07:45 UTC (rev 213364)
@@ -1,5 +1,6 @@
<!DOCTYPE html>
<script src=""
+<script src="" type="text/_javascript_"></script>
<body>
<video src="" style="width: 320px; height: 240px;" controls autoplay></video>
<script type="text/_javascript_">
@@ -16,29 +17,29 @@
});
media.addEventListener("webkitfullscreenchange", () => {
- if (media.webkitDisplayingFullscreen) {
- window.requestAnimationFrame(() => {
- const bounds = shadowRoot.querySelector(".controls-bar").getBoundingClientRect();
- eventSender.mouseMoveTo(bounds.left + 118, bounds.top + 10);
- eventSender.mouseDown();
- eventSender.mouseMoveTo(bounds.left + 68, bounds.top - 40);
- eventSender.mouseUp();
+ if (!media.webkitDisplayingFullscreen)
+ return;
- window.requestAnimationFrame(() => {
- window.requestAnimationFrame(() => {
- clickOnButton("tracks");
- window.requestAnimationFrame(() => {
- shouldBeTrue("shadowRoot.querySelector('button.tracks').getBoundingClientRect().right === shadowRoot.querySelector('.tracks-panel').getBoundingClientRect().right");
- shouldBeEqualToString("shadowRoot.querySelector('.tracks-panel').style.bottom", "151px");
+ window.requestAnimationFrame(() => {
+ const bounds = shadowRoot.querySelector(".controls-bar").getBoundingClientRect();
+ eventSender.mouseMoveTo(bounds.left + 118, bounds.top + 10);
+ eventSender.mouseDown();
+ eventSender.mouseMoveTo(bounds.left + 68, bounds.top - 40);
+ eventSender.mouseUp();
- debug("");
- media.remove();
- finishJSTest();
- });
+ requestAnimationFrame(() => {
+ clickOnButton("tracks", () => {
+ requestAnimationFrame(() => {
+ shouldBe("shadowRoot.querySelector('button.tracks').getBoundingClientRect().right", "shadowRoot.querySelector('.tracks-panel').getBoundingClientRect().right")
+ shouldBeEqualToString("shadowRoot.querySelector('.tracks-panel').style.bottom", "151px");
+
+ debug("");
+ media.remove();
+ finishJSTest();
});
});
});
- }
+ });
});
media.addEventListener("play", () => {
@@ -46,12 +47,11 @@
window.requestAnimationFrame(() => clickOnButton("fullscreen"));
});
-function clickOnButton(name)
+function clickOnButton(name, continuation)
{
- const bounds = shadowRoot.querySelector(`button.${name}`).getBoundingClientRect();
- eventSender.mouseMoveTo(bounds.left + 1, bounds.top + 1);
- eventSender.mouseDown();
- eventSender.mouseUp();
+ shouldBecomeDifferent(`shadowRoot.querySelector('button.${name}').getBoundingClientRect()`, "0", () => {
+ pressOnElement(shadowRoot.querySelector(`button.${name}`), continuation);
+ });
}
</script>
Modified: trunk/LayoutTests/platform/mac/TestExpectations (213363 => 213364)
--- trunk/LayoutTests/platform/mac/TestExpectations 2017-03-03 13:02:49 UTC (rev 213363)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2017-03-03 13:07:45 UTC (rev 213364)
@@ -1481,8 +1481,6 @@
media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button.html [ Skip ]
media/modern-media-controls/media-controller/media-controller-tight-padding.html [ Skip ]
-webkit.org/b/167275 media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html [ Pass Failure ]
-
webkit.org/b/167266 media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-over-controls-bar.html [ Pass Failure ]
webkit.org/b/167373 media/modern-media-controls/tracks-support/tracks-support-show-panel-fullscreen.html [ Pass Failure ]
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
