Title: [213369] trunk/Source/WebCore
- Revision
- 213369
- Author
- [email protected]
- Date
- 2017-03-03 09:51:23 -0800 (Fri, 03 Mar 2017)
Log Message
Add assertion in Frame::setView() to make sure associated document has no living render tree
https://bugs.webkit.org/show_bug.cgi?id=169134
Reviewed by Brent Fulgham.
Add assertion in Frame::setView() to make sure associated document has no living render tree.
This is not supposed to happen and r213311 fixed one case where this could happen. We need
to find out if it can still happen.
* page/Frame.cpp:
(WebCore::Frame::setView):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (213368 => 213369)
--- trunk/Source/WebCore/ChangeLog 2017-03-03 17:50:10 UTC (rev 213368)
+++ trunk/Source/WebCore/ChangeLog 2017-03-03 17:51:23 UTC (rev 213369)
@@ -1,3 +1,17 @@
+2017-03-03 Chris Dumez <[email protected]>
+
+ Add assertion in Frame::setView() to make sure associated document has no living render tree
+ https://bugs.webkit.org/show_bug.cgi?id=169134
+
+ Reviewed by Brent Fulgham.
+
+ Add assertion in Frame::setView() to make sure associated document has no living render tree.
+ This is not supposed to happen and r213311 fixed one case where this could happen. We need
+ to find out if it can still happen.
+
+ * page/Frame.cpp:
+ (WebCore::Frame::setView):
+
2017-03-02 Sam Weinig <[email protected]>
Rename htmlediting.h/cpp to Editing.h/cpp
Modified: trunk/Source/WebCore/page/Frame.cpp (213368 => 213369)
--- trunk/Source/WebCore/page/Frame.cpp 2017-03-03 17:50:10 UTC (rev 213368)
+++ trunk/Source/WebCore/page/Frame.cpp 2017-03-03 17:51:23 UTC (rev 213369)
@@ -256,6 +256,8 @@
m_eventHandler->clear();
bool hadLivingRenderTree = m_doc ? m_doc->hasLivingRenderTree() : false;
+ // Try and catch cases where this might still be happening after r213311.
+ ASSERT_WITH_SECURITY_IMPLICATION(!hadLivingRenderTree);
if (hadLivingRenderTree)
m_doc->destroyRenderTree();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
