Diff
Modified: trunk/Source/WebCore/ChangeLog (213542 => 213543)
--- trunk/Source/WebCore/ChangeLog 2017-03-07 22:24:19 UTC (rev 213542)
+++ trunk/Source/WebCore/ChangeLog 2017-03-07 22:44:53 UTC (rev 213543)
@@ -1,5 +1,25 @@
2017-03-07 Chris Dumez <[email protected]>
+ Drop non-standard MessageEvent.webkitInitMessageEvent()
+ https://bugs.webkit.org/show_bug.cgi?id=169295
+
+ Reviewed by Joseph Pecoraro.
+
+ Drop non-standard MessageEvent.webkitInitMessageEvent().
+
+ Chrome dropped it almost 3 years ago. They had UseCounter data showing
+ consistent 0% usage:
+ - https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/H6lsGFqdy3Y
+ - https://www.chromestatus.com/metrics/feature/timeline/popularity/223
+ - https://src.chromium.org/viewvc/blink?revision=174967&view=revision
+
+ * bindings/js/JSMessageEventCustom.cpp:
+ (WebCore::handleInitMessageEvent): Deleted.
+ (WebCore::JSMessageEvent::webkitInitMessageEvent): Deleted.
+ * dom/MessageEvent.idl:
+
+2017-03-07 Chris Dumez <[email protected]>
+
Label of an <option> element should not be displayed in quirks mode
https://bugs.webkit.org/show_bug.cgi?id=169296
<rdar://problem/30900751>
Modified: trunk/Source/WebCore/bindings/js/JSMessageEventCustom.cpp (213542 => 213543)
--- trunk/Source/WebCore/bindings/js/JSMessageEventCustom.cpp 2017-03-07 22:24:19 UTC (rev 213542)
+++ trunk/Source/WebCore/bindings/js/JSMessageEventCustom.cpp 2017-03-07 22:44:53 UTC (rev 213543)
@@ -103,46 +103,4 @@
return result;
}
-static JSC::JSValue handleInitMessageEvent(JSMessageEvent* jsEvent, JSC::ExecState& state)
-{
- VM& vm = state.vm();
- auto scope = DECLARE_THROW_SCOPE(vm);
-
- const String& typeArg = state.argument(0).toWTFString(&state);
- RETURN_IF_EXCEPTION(scope, JSValue());
-
- bool canBubbleArg = state.argument(1).toBoolean(&state);
- RETURN_IF_EXCEPTION(scope, JSValue());
-
- bool cancelableArg = state.argument(2).toBoolean(&state);
- RETURN_IF_EXCEPTION(scope, JSValue());
-
- JSValue dataArg = state.argument(3);
-
- const String originArg = convert<IDLUSVString>(state, state.argument(4));
- RETURN_IF_EXCEPTION(scope, JSValue());
-
- const String lastEventIdArg = state.argument(5).toWTFString(&state);
- RETURN_IF_EXCEPTION(scope, JSValue());
-
- auto sourceArg = convert<IDLNullable<IDLUnion<IDLInterface<DOMWindow>, IDLInterface<MessagePort>>>>(state, state.argument(6));
- RETURN_IF_EXCEPTION(scope, JSValue());
-
- Vector<RefPtr<MessagePort>> messagePorts;
- if (!state.argument(7).isUndefinedOrNull()) {
- messagePorts = convert<IDLSequence<IDLInterface<MessagePort>>>(state, state.argument(7));
- RETURN_IF_EXCEPTION(scope, JSValue());
- }
-
- MessageEvent& event = jsEvent->wrapped();
- event.initMessageEvent(state, typeArg, canBubbleArg, cancelableArg, dataArg, originArg, lastEventIdArg, WTFMove(sourceArg), WTFMove(messagePorts));
- jsEvent->m_data.set(vm, jsEvent, dataArg);
- return jsUndefined();
-}
-
-JSC::JSValue JSMessageEvent::webkitInitMessageEvent(JSC::ExecState& state)
-{
- return handleInitMessageEvent(this, state);
-}
-
} // namespace WebCore
Modified: trunk/Source/WebCore/dom/MessageEvent.idl (213542 => 213543)
--- trunk/Source/WebCore/dom/MessageEvent.idl 2017-03-07 22:24:19 UTC (rev 213542)
+++ trunk/Source/WebCore/dom/MessageEvent.idl 2017-03-07 22:44:53 UTC (rev 213543)
@@ -40,9 +40,6 @@
[CallWith=ScriptState] void initMessageEvent(DOMString type, optional boolean bubbles = false, optional boolean cancelable = false,
optional any data = "" optional USVString originArg = "", optional DOMString lastEventId = "", optional (DOMWindow or MessagePort)? source = null,
optional sequence<MessagePort> messagePorts = []);
- [Custom] void webkitInitMessageEvent(optional DOMString typeArg, optional boolean canBubbleArg, optional boolean cancelableArg,
- optional any dataArg, optional USVString originArg, optional DOMString lastEventIdArg, optional (DOMWindow or MessagePort)? sourceArg,
- optional sequence<MessagePort> messagePorts);
};
dictionary MessageEventInit : EventInit {
Modified: trunk/Source/WebInspectorUI/ChangeLog (213542 => 213543)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-03-07 22:24:19 UTC (rev 213542)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-03-07 22:44:53 UTC (rev 213543)
@@ -1,3 +1,15 @@
+2017-03-07 Chris Dumez <[email protected]>
+
+ Drop non-standard MessageEvent.webkitInitMessageEvent()
+ https://bugs.webkit.org/show_bug.cgi?id=169295
+
+ Reviewed by Joseph Pecoraro.
+
+ Drop MessageEvent.webkitInitMessageEvent and update parameters for various
+ init*Event() operations to match the current implementation.
+
+ * UserInterface/Models/NativeFunctionParameters.js:
+
2017-03-04 Nikita Vasilyev <[email protected]>
Web Inspector: Show Web Socket connections in Network tab
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js (213542 => 213543)
--- trunk/Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js 2017-03-07 22:24:19 UTC (rev 213542)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js 2017-03-07 22:44:53 UTC (rev 213543)
@@ -728,7 +728,7 @@
},
CustomEvent: {
- initCustomEvent: "[typeArg], [canBubbleArg], [cancelableArg], [detailArg]",
+ initCustomEvent: "type, [bubbles], [cancelable], [detail]",
__proto__: null,
},
@@ -820,7 +820,7 @@
},
Event: {
- initEvent: "type, canBubble, cancelable",
+ initEvent: "type, [bubbles], [cancelable]",
__proto__: null,
},
@@ -1119,8 +1119,7 @@
},
MessageEvent: {
- initMessageEvent: "[typeArg], [canBubbleArg], [cancelableArg], [dataArg], [originArg], [lastEventIdArg], [sourceArg], [messagePorts]",
- webkitInitMessageEvent: "[typeArg], [canBubbleArg], [cancelableArg], [dataArg], [originArg], [lastEventIdArg], [sourceArg], [transferables]",
+ initMessageEvent: "type, [bubbles], [cancelable], [data], [origin], [lastEventId], [source], [messagePorts]",
__proto__: null,
},
