Title: [213561] trunk/Source/WebCore
- Revision
- 213561
- Author
- [email protected]
- Date
- 2017-03-07 19:15:02 -0800 (Tue, 07 Mar 2017)
Log Message
Parsing -webkit-hyphenate-character uses confusingly named consumeLocale()
https://bugs.webkit.org/show_bug.cgi?id=168638
Reviewed by Zalan Bujtas.
Parsing CSSPropertyWebkitHyphenateCharacter very confusingly called consumeLocale(),
which is really just "consume the 'auto' ident or a string", so rename that function.
* css/parser/CSSPropertyParser.cpp:
(WebCore::consumeAutoOrString):
(WebCore::CSSPropertyParser::parseSingleValue):
(WebCore::consumeLocale): Deleted.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (213560 => 213561)
--- trunk/Source/WebCore/ChangeLog 2017-03-08 02:09:38 UTC (rev 213560)
+++ trunk/Source/WebCore/ChangeLog 2017-03-08 03:15:02 UTC (rev 213561)
@@ -1,3 +1,18 @@
+2017-03-07 Simon Fraser <[email protected]>
+
+ Parsing -webkit-hyphenate-character uses confusingly named consumeLocale()
+ https://bugs.webkit.org/show_bug.cgi?id=168638
+
+ Reviewed by Zalan Bujtas.
+
+ Parsing CSSPropertyWebkitHyphenateCharacter very confusingly called consumeLocale(),
+ which is really just "consume the 'auto' ident or a string", so rename that function.
+
+ * css/parser/CSSPropertyParser.cpp:
+ (WebCore::consumeAutoOrString):
+ (WebCore::CSSPropertyParser::parseSingleValue):
+ (WebCore::consumeLocale): Deleted.
+
2017-03-07 Jiewen Tan <[email protected]>
[WebCrypto] Implement ECDH ImportKey/ExportKey operations
Modified: trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp (213560 => 213561)
--- trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp 2017-03-08 02:09:38 UTC (rev 213560)
+++ trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp 2017-03-08 03:15:02 UTC (rev 213561)
@@ -1378,7 +1378,7 @@
return consumePositiveInteger(range);
}
-static RefPtr<CSSValue> consumeLocale(CSSParserTokenRange& range)
+static RefPtr<CSSValue> consumeAutoOrString(CSSParserTokenRange& range)
{
if (range.peek().id() == CSSValueAuto)
return consumeIdent(range);
@@ -3922,7 +3922,7 @@
return consumeLength(m_range, m_context.mode, ValueRangeAll, UnitlessQuirk::Allow);
case CSSPropertyWebkitHyphenateCharacter:
case CSSPropertyWebkitLocale:
- return consumeLocale(m_range);
+ return consumeAutoOrString(m_range);
case CSSPropertyWebkitHyphenateLimitBefore:
case CSSPropertyWebkitHyphenateLimitAfter:
return consumeHyphenateLimit(m_range, CSSValueAuto);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
