Log Message
Remove never-implemented CSS3 text decoration-related properties https://bugs.webkit.org/show_bug.cgi?id=169009
Reviewed by Zalan Bujtas.
The following CSS properties were added many years ago based on an old CSS3 Text
draft (https://www.w3.org/TR/2003/CR-css3-text-20030514/), but never had any implementations.
Remove them.
text-line-through
text-line-through-color
text-line-through-mode
text-line-through-style
text-line-through-width
text-overline
text-overline-color
text-overline-mode
text-overline-style
text-overline-width
text-underline
text-underline-color
text-underline-mode
text-underline-style
text-underline-width
* WebCore.xcodeproj/project.pbxproj:
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
* css/CSSProperties.json:
* css/parser/CSSParserFastPaths.cpp:
(WebCore::CSSParserFastPaths::isKeywordPropertyID):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (213566 => 213567)
--- trunk/Source/WebCore/ChangeLog 2017-03-08 05:46:52 UTC (rev 213566)
+++ trunk/Source/WebCore/ChangeLog 2017-03-08 06:06:41 UTC (rev 213567)
@@ -1,5 +1,39 @@
2017-03-07 Simon Fraser <[email protected]>
+ Remove never-implemented CSS3 text decoration-related properties
+ https://bugs.webkit.org/show_bug.cgi?id=169009
+
+ Reviewed by Zalan Bujtas.
+
+ The following CSS properties were added many years ago based on an old CSS3 Text
+ draft (https://www.w3.org/TR/2003/CR-css3-text-20030514/), but never had any implementations.
+ Remove them.
+
+ text-line-through
+ text-line-through-color
+ text-line-through-mode
+ text-line-through-style
+ text-line-through-width
+ text-overline
+ text-overline-color
+ text-overline-mode
+ text-overline-style
+ text-overline-width
+ text-underline
+ text-underline-color
+ text-underline-mode
+ text-underline-style
+ text-underline-width
+
+ * WebCore.xcodeproj/project.pbxproj:
+ * css/CSSComputedStyleDeclaration.cpp:
+ (WebCore::ComputedStyleExtractor::propertyValue):
+ * css/CSSProperties.json:
+ * css/parser/CSSParserFastPaths.cpp:
+ (WebCore::CSSParserFastPaths::isKeywordPropertyID):
+
+2017-03-07 Simon Fraser <[email protected]>
+
Have fixedPositionCreatesStackingContext be on by default everywhere
https://bugs.webkit.org/show_bug.cgi?id=169334
Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (213566 => 213567)
--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2017-03-08 05:46:52 UTC (rev 213566)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj 2017-03-08 06:06:41 UTC (rev 213567)
@@ -7663,6 +7663,7 @@
0F8B45731DC41DBA00443C3F /* JSIntersectionObserverCallback.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSIntersectionObserverCallback.cpp; sourceTree = "<group>"; };
0F8B45741DC41DBA00443C3F /* JSIntersectionObserverCallback.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSIntersectionObserverCallback.h; sourceTree = "<group>"; };
0F97A657155DA81E00FADD4C /* DisplayRefreshMonitorIOS.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = DisplayRefreshMonitorIOS.mm; sourceTree = "<group>"; };
+ 0FA0852B1E6FB55A00975FDD /* CSSProperties.json */ = {isa = PBXFileReference; lastKnownFileType = text.json; path = CSSProperties.json; sourceTree = "<group>"; };
0FA24D77162DF91900A3F4C0 /* GraphicsLayerUpdater.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = GraphicsLayerUpdater.cpp; sourceTree = "<group>"; };
0FA24D78162DF91900A3F4C0 /* GraphicsLayerUpdater.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = GraphicsLayerUpdater.h; sourceTree = "<group>"; };
0FA88EBC16A8D1BD00F99984 /* ScrollingStateFrameScrollingNodeMac.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = ScrollingStateFrameScrollingNodeMac.mm; sourceTree = "<group>"; };
@@ -24075,6 +24076,7 @@
A80E6CDB0A1989CA007FB8C5 /* CSSPrimitiveValue.cpp */,
A80E6CBC0A1989CA007FB8C5 /* CSSPrimitiveValue.h */,
E1ED8AC20CC49BE000BFC557 /* CSSPrimitiveValueMappings.h */,
+ 0FA0852B1E6FB55A00975FDD /* CSSProperties.json */,
A80E6CCD0A1989CA007FB8C5 /* CSSProperty.cpp */,
A80E6CD50A1989CA007FB8C5 /* CSSProperty.h */,
82E3D8DC122EA0D1003AE5BC /* CSSPropertySourceData.cpp */,
Modified: trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp (213566 => 213567)
--- trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp 2017-03-08 05:46:52 UTC (rev 213566)
+++ trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp 2017-03-08 06:06:41 UTC (rev 213567)
@@ -3870,21 +3870,6 @@
case CSSPropertyAll:
case CSSPropertyAnimation:
case CSSPropertyWebkitTextEmphasis:
- case CSSPropertyTextLineThrough:
- case CSSPropertyTextLineThroughColor:
- case CSSPropertyTextLineThroughMode:
- case CSSPropertyTextLineThroughStyle:
- case CSSPropertyTextLineThroughWidth:
- case CSSPropertyTextOverline:
- case CSSPropertyTextOverlineColor:
- case CSSPropertyTextOverlineMode:
- case CSSPropertyTextOverlineStyle:
- case CSSPropertyTextOverlineWidth:
- case CSSPropertyTextUnderline:
- case CSSPropertyTextUnderlineColor:
- case CSSPropertyTextUnderlineMode:
- case CSSPropertyTextUnderlineStyle:
- case CSSPropertyTextUnderlineWidth:
break;
/* Directional properties are resolved by resolveDirectionAwareProperty() before the switch. */
Modified: trunk/Source/WebCore/css/CSSProperties.json (213566 => 213567)
--- trunk/Source/WebCore/css/CSSProperties.json 2017-03-08 05:46:52 UTC (rev 213566)
+++ trunk/Source/WebCore/css/CSSProperties.json 2017-03-08 06:06:41 UTC (rev 213567)
@@ -3148,8 +3148,9 @@
},
"text-line-through": {
"codegen-properties": {
- "skip-builder": true
+ "skip-codegen": true
},
+ "status": "removed",
"specification": {
"category": "css3-text",
"url": "https://www.w3.org/TR/2003/CR-css3-text-20030514/#text-line-through"
@@ -3157,8 +3158,9 @@
},
"text-line-through-color": {
"codegen-properties": {
- "skip-builder": true
+ "skip-codegen": true
},
+ "status": "removed",
"specification": {
"category": "css3-text",
"url": "https://www.w3.org/TR/2003/CR-css3-text-20030514/#text-line-through-color"
@@ -3169,8 +3171,9 @@
"continuous",
"skip-white-space"
],
+ "status": "removed",
"codegen-properties": {
- "skip-builder": true
+ "skip-codegen": true
},
"specification": {
"category": "css3-text",
@@ -3187,8 +3190,9 @@
"dot-dot-dash",
"wave"
],
+ "status": "removed",
"codegen-properties": {
- "skip-builder": true
+ "skip-codegen": true
},
"specification": {
"category": "css3-text",
@@ -3197,8 +3201,9 @@
},
"text-line-through-width": {
"codegen-properties": {
- "skip-builder": true
+ "skip-codegen": true
},
+ "status": "removed",
"specification": {
"category": "css3-text",
"url": "https://www.w3.org/TR/2003/CR-css3-text-20030514/#text-line-through-width"
@@ -3216,8 +3221,9 @@
},
"text-overline": {
"codegen-properties": {
- "skip-builder": true
+ "skip-codegen": true
},
+ "status": "removed",
"specification": {
"category": "css3-text",
"url": "https://www.w3.org/TR/2003/CR-css3-text-20030514/#text-overline"
@@ -3225,8 +3231,9 @@
},
"text-overline-color": {
"codegen-properties": {
- "skip-builder": true
+ "skip-codegen": true
},
+ "status": "removed",
"specification": {
"category": "css3-text",
"url": "https://www.w3.org/TR/2003/CR-css3-text-20030514/#text-overline-color"
@@ -3238,8 +3245,9 @@
"skip-white-space"
],
"codegen-properties": {
- "skip-builder": true
+ "skip-codegen": true
},
+ "status": "removed",
"specification": {
"category": "css3-text",
"url": "https://www.w3.org/TR/2003/CR-css3-text-20030514/#text-overline-mode"
@@ -3256,8 +3264,9 @@
"wave"
],
"codegen-properties": {
- "skip-builder": true
+ "skip-codegen": true
},
+ "status": "removed",
"specification": {
"category": "css3-text",
"url": "https://www.w3.org/TR/2003/CR-css3-text-20030514/#text-overline-style"
@@ -3265,8 +3274,9 @@
},
"text-overline-width": {
"codegen-properties": {
- "skip-builder": true
+ "skip-codegen": true
},
+ "status": "removed",
"specification": {
"category": "css3-text",
"url": "https://www.w3.org/TR/2003/CR-css3-text-20030514/#text-overline-width"
@@ -3302,8 +3312,9 @@
},
"text-underline": {
"codegen-properties": {
- "skip-builder": true
+ "skip-codegen": true
},
+ "status": "removed",
"specification": {
"category": "css3-text",
"url": "https://www.w3.org/TR/2003/CR-css3-text-20030514/#text-underline"
@@ -3311,8 +3322,9 @@
},
"text-underline-color": {
"codegen-properties": {
- "skip-builder": true
+ "skip-codegen": true
},
+ "status": "removed",
"specification": {
"category": "css3-text",
"url": "https://www.w3.org/TR/2003/CR-css3-text-20030514/#text-underline-color"
@@ -3324,8 +3336,9 @@
"skip-white-space"
],
"codegen-properties": {
- "skip-builder": true
+ "skip-codegen": true
},
+ "status": "removed",
"specification": {
"category": "css3-text",
"url": "https://www.w3.org/TR/2003/CR-css3-text-20030514/#text-underline-mode"
@@ -3342,8 +3355,9 @@
"wave"
],
"codegen-properties": {
- "skip-builder": true
+ "skip-codegen": true
},
+ "status": "removed",
"specification": {
"category": "css3-text",
"url": "https://www.w3.org/TR/2003/CR-css3-text-20030514/#text-underline-style"
@@ -3351,8 +3365,9 @@
},
"text-underline-width": {
"codegen-properties": {
- "skip-builder": true
+ "skip-codegen": true
},
+ "status": "removed",
"specification": {
"category": "css3-text",
"url": "https://www.w3.org/TR/2003/CR-css3-text-20030514/#text-underline-width"
Modified: trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp (213566 => 213567)
--- trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp 2017-03-08 05:46:52 UTC (rev 213566)
+++ trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp 2017-03-08 06:06:41 UTC (rev 213567)
@@ -846,15 +846,9 @@
case CSSPropertySpeak:
case CSSPropertyTableLayout:
case CSSPropertyTextAlign:
- case CSSPropertyTextLineThroughMode:
- case CSSPropertyTextLineThroughStyle:
case CSSPropertyTextOverflow:
- case CSSPropertyTextOverlineMode:
- case CSSPropertyTextOverlineStyle:
case CSSPropertyTextRendering:
case CSSPropertyTextTransform:
- case CSSPropertyTextUnderlineMode:
- case CSSPropertyTextUnderlineStyle:
case CSSPropertyTransformStyle:
case CSSPropertyUnicodeBidi:
case CSSPropertyVisibility:
_______________________________________________ webkit-changes mailing list [email protected] https://lists.webkit.org/mailman/listinfo/webkit-changes
