Title: [213575] trunk/Source/WebCore
- Revision
- 213575
- Author
- [email protected]
- Date
- 2017-03-08 09:43:30 -0800 (Wed, 08 Mar 2017)
Log Message
MediaPlayerPrivateGStreamerBase::volume() should override the MediaPlayerPrivate method
https://bugs.webkit.org/show_bug.cgi?id=169347
Reviewed by Carlos Garcia Campos.
Enable the MediaPlayerPrivate::volume() method for the USE(GSTREAMER) configuration
and override it in the MediaPlayerPrivateGStreamerBase class.
* platform/graphics/MediaPlayerPrivate.h:
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (213574 => 213575)
--- trunk/Source/WebCore/ChangeLog 2017-03-08 17:10:12 UTC (rev 213574)
+++ trunk/Source/WebCore/ChangeLog 2017-03-08 17:43:30 UTC (rev 213575)
@@ -1,3 +1,16 @@
+2017-03-08 Zan Dobersek <[email protected]>
+
+ MediaPlayerPrivateGStreamerBase::volume() should override the MediaPlayerPrivate method
+ https://bugs.webkit.org/show_bug.cgi?id=169347
+
+ Reviewed by Carlos Garcia Campos.
+
+ Enable the MediaPlayerPrivate::volume() method for the USE(GSTREAMER) configuration
+ and override it in the MediaPlayerPrivateGStreamerBase class.
+
+ * platform/graphics/MediaPlayerPrivate.h:
+ * platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
+
2017-03-08 Enrique Ocaña González <[email protected]>
[GStreamer][MSE] Actually implement flush() on playback pipeline
Modified: trunk/Source/WebCore/platform/graphics/MediaPlayerPrivate.h (213574 => 213575)
--- trunk/Source/WebCore/platform/graphics/MediaPlayerPrivate.h 2017-03-08 17:10:12 UTC (rev 213574)
+++ trunk/Source/WebCore/platform/graphics/MediaPlayerPrivate.h 2017-03-08 17:43:30 UTC (rev 213575)
@@ -119,7 +119,7 @@
virtual void setVolume(float) { }
virtual void setVolumeDouble(double volume) { return setVolume(volume); }
-#if PLATFORM(IOS)
+#if PLATFORM(IOS) || USE(GSTREAMER)
virtual float volume() const { return 1; }
#endif
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h (213574 => 213575)
--- trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h 2017-03-08 17:10:12 UTC (rev 213574)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h 2017-03-08 17:43:30 UTC (rev 213575)
@@ -69,7 +69,7 @@
FloatSize naturalSize() const override;
void setVolume(float) override;
- virtual float volume() const;
+ float volume() const override;
#if USE(GSTREAMER_GL)
bool ensureGstGLContext();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
