Title: [213689] trunk/Source/WebInspectorUI
- Revision
- 213689
- Author
- [email protected]
- Date
- 2017-03-09 16:52:07 -0800 (Thu, 09 Mar 2017)
Log Message
REGRESSION (r196271): Web Inspector: DOM element loses focus/active selection after committing an inline attribute editor in DOMTreeOutline
https://bugs.webkit.org/show_bug.cgi?id=168119
<rdar://problem/30466013>
Reviewed by Brian Burg.
Fix a regression caused by http://trac.webkit.org/changeset/196271, which
updated WebInspector.isEventTargetAnEditableField to detect the editing
scenarios used by DOMTreeElement and DataGrid. This subtly changed the
behavior of WebInspector._focusChanged, which expected all editable fields
to be backed by a CodeMirror instance.
* UserInterface/Base/Main.js:
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (213688 => 213689)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-03-10 00:46:25 UTC (rev 213688)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-03-10 00:52:07 UTC (rev 213689)
@@ -1,3 +1,19 @@
+2017-03-09 Matt Baker <[email protected]>
+
+ REGRESSION (r196271): Web Inspector: DOM element loses focus/active selection after committing an inline attribute editor in DOMTreeOutline
+ https://bugs.webkit.org/show_bug.cgi?id=168119
+ <rdar://problem/30466013>
+
+ Reviewed by Brian Burg.
+
+ Fix a regression caused by http://trac.webkit.org/changeset/196271, which
+ updated WebInspector.isEventTargetAnEditableField to detect the editing
+ scenarios used by DOMTreeElement and DataGrid. This subtly changed the
+ behavior of WebInspector._focusChanged, which expected all editable fields
+ to be backed by a CodeMirror instance.
+
+ * UserInterface/Base/Main.js:
+
2017-03-09 Joseph Pecoraro <[email protected]>
Web Inspector: Show HTTP protocol version and other Network Load Metrics (IP Address, Priority, Connection ID)
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (213688 => 213689)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2017-03-10 00:46:25 UTC (rev 213688)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2017-03-10 00:52:07 UTC (rev 213689)
@@ -1328,8 +1328,8 @@
if (codeMirrorEditorElement && codeMirrorEditorElement !== this.currentFocusElement) {
this.previousFocusElement = this.currentFocusElement;
this.currentFocusElement = codeMirrorEditorElement;
+ return;
}
- return;
}
var selection = window.getSelection();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
