Title: [213734] trunk/Source/WebInspectorUI
- Revision
- 213734
- Author
- commit-qu...@webkit.org
- Date
- 2017-03-10 16:45:39 -0800 (Fri, 10 Mar 2017)
Log Message
Web Inspector: REGRESSION(r213149): scope bar items in elements sidebar have wrong padding/margin
https://bugs.webkit.org/show_bug.cgi?id=169204
Patch by Devin Rousso <dcrousso+web...@gmail.com> on 2017-03-10
Reviewed by Brian Burg.
* UserInterface/Views/Sidebar.css:
(.sidebar > .navigation-bar):
Replace `align-content` with `align-items`, as the former causes the child elements to fill
as much vertical space as possible instead of only using the space necessary for its content.
* UserInterface/Views/ScopeRadioButtonNavigationItem.css:
(.scope-radio-button-navigation-item > .arrows):
Drive-by fix: ensure that the up/down arrows are not clickable, which would prevent the
<select> from showing.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (213733 => 213734)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-03-11 00:33:18 UTC (rev 213733)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-03-11 00:45:39 UTC (rev 213734)
@@ -1,3 +1,20 @@
+2017-03-10 Devin Rousso <dcrousso+web...@gmail.com>
+
+ Web Inspector: REGRESSION(r213149): scope bar items in elements sidebar have wrong padding/margin
+ https://bugs.webkit.org/show_bug.cgi?id=169204
+
+ Reviewed by Brian Burg.
+
+ * UserInterface/Views/Sidebar.css:
+ (.sidebar > .navigation-bar):
+ Replace `align-content` with `align-items`, as the former causes the child elements to fill
+ as much vertical space as possible instead of only using the space necessary for its content.
+
+ * UserInterface/Views/ScopeRadioButtonNavigationItem.css:
+ (.scope-radio-button-navigation-item > .arrows):
+ Drive-by fix: ensure that the up/down arrows are not clickable, which would prevent the
+ <select> from showing.
+
2017-03-09 Matt Baker <mattba...@apple.com>
Web Inspector: Add XHR breakpoints UI
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ScopeRadioButtonNavigationItem.css (213733 => 213734)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ScopeRadioButtonNavigationItem.css 2017-03-11 00:33:18 UTC (rev 213733)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ScopeRadioButtonNavigationItem.css 2017-03-11 00:45:39 UTC (rev 213734)
@@ -59,6 +59,7 @@
.scope-radio-button-navigation-item > .arrows {
width: 5px;
height: 11px;
+ pointer-events: none;
transform: translateY(1px);
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Sidebar.css (213733 => 213734)
--- trunk/Source/WebInspectorUI/UserInterface/Views/Sidebar.css 2017-03-11 00:33:18 UTC (rev 213733)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Sidebar.css 2017-03-11 00:45:39 UTC (rev 213734)
@@ -39,7 +39,7 @@
top: 0;
left: 0;
right: 0;
- align-content: center;
+ align-items: center;
}
.sidebar > .panel {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
