Title: [213763] trunk/Source/WebInspectorUI
Revision
213763
Author
[email protected]
Date
2017-03-11 17:07:32 -0800 (Sat, 11 Mar 2017)

Log Message

Web Inspector: RTL: fix broken font content view
https://bugs.webkit.org/show_bug.cgi?id=169513

Reviewed by Brian Burg.

Add RTL support to the Font content view.

* UserInterface/Views/FontResourceContentView.css:
(.content-view.resource.font .preview > .line > .metric):
(body[dir=ltr] .content-view.resource.font .preview > .line > .metric):
(body[dir=rtl] .content-view.resource.font .preview > .line > .metric):
Compensate for the flipped z-order of the content and metric elements in
RTL by pushing metrics below the content.

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (213762 => 213763)


--- trunk/Source/WebInspectorUI/ChangeLog	2017-03-11 23:09:26 UTC (rev 213762)
+++ trunk/Source/WebInspectorUI/ChangeLog	2017-03-12 01:07:32 UTC (rev 213763)
@@ -1,3 +1,19 @@
+2017-03-11  Matt Baker  <[email protected]>
+
+        Web Inspector: RTL: fix broken font content view
+        https://bugs.webkit.org/show_bug.cgi?id=169513
+
+        Reviewed by Brian Burg.
+
+        Add RTL support to the Font content view.
+
+        * UserInterface/Views/FontResourceContentView.css:
+        (.content-view.resource.font .preview > .line > .metric):
+        (body[dir=ltr] .content-view.resource.font .preview > .line > .metric):
+        (body[dir=rtl] .content-view.resource.font .preview > .line > .metric):
+        Compensate for the flipped z-order of the content and metric elements in
+        RTL by pushing metrics below the content.
+
 2017-03-10  Matt Baker  <[email protected]>
 
         Web Inspector: Only show "Break on..." menu if backend supports DOM breakpoints

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/FontResourceContentView.css (213762 => 213763)


--- trunk/Source/WebInspectorUI/UserInterface/Views/FontResourceContentView.css	2017-03-11 23:09:26 UTC (rev 213762)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/FontResourceContentView.css	2017-03-12 01:07:32 UTC (rev 213763)
@@ -71,9 +71,19 @@
     width: 100%;
     height: 1px;
 
-    margin-right: -100%; /* Causes this element to be zero width and draw behind the text. */
+    --margin-end: -100%; /* Causes this element to be zero width and draw behind the text. */
 }
 
+body[dir=ltr] .content-view.resource.font .preview > .line > .metric {
+    margin-right: var(--margin-end);
+}
+
+body[dir=rtl] .content-view.resource.font .preview > .line > .metric {
+    margin-left: var(--margin-end);
+    position: relative;
+    z-index: -1;
+}
+
 .content-view.resource.font .metric.top {
     vertical-align: top;
     background-color: lightgrey;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to