Title: [213795] releases/WebKitGTK/webkit-2.16/Source/WebCore
- Revision
- 213795
- Author
- [email protected]
- Date
- 2017-03-13 02:46:34 -0700 (Mon, 13 Mar 2017)
Log Message
Merge r213218 - [GTK] Fix problems found by Coverity scan in platform's keyboard and mouse events
https://bugs.webkit.org/show_bug.cgi?id=169028
Reviewed by Carlos Garcia Campos.
* platform/gtk/PlatformKeyboardEventGtk.cpp:
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): Initialize
the m_handledByInputMethod member.
* platform/gtk/PlatformMouseEventGtk.cpp:
(WebCore::PlatformMouseEvent::PlatformMouseEvent): Initialize the
m_modifierFlags member.
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog (213794 => 213795)
--- releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog 2017-03-13 09:43:57 UTC (rev 213794)
+++ releases/WebKitGTK/webkit-2.16/Source/WebCore/ChangeLog 2017-03-13 09:46:34 UTC (rev 213795)
@@ -1,3 +1,24 @@
+2017-03-01 Tomas Popela <[email protected]>
+
+ Unreviewed compiler warning fix after r213218
+
+ * platform/gtk/PlatformKeyboardEventGtk.cpp:
+ (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
+
+2017-03-01 Tomas Popela <[email protected]>
+
+ [GTK] Fix problems found by Coverity scan in platform's keyboard and mouse events
+ https://bugs.webkit.org/show_bug.cgi?id=169028
+
+ Reviewed by Carlos Garcia Campos.
+
+ * platform/gtk/PlatformKeyboardEventGtk.cpp:
+ (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): Initialize
+ the m_handledByInputMethod member.
+ * platform/gtk/PlatformMouseEventGtk.cpp:
+ (WebCore::PlatformMouseEvent::PlatformMouseEvent): Initialize the
+ m_modifierFlags member.
+
2017-02-27 Zan Dobersek <[email protected]>
[TextureMapper] Clean up BitmapTextureGL construction
Modified: releases/WebKitGTK/webkit-2.16/Source/WebCore/platform/gtk/PlatformKeyboardEventGtk.cpp (213794 => 213795)
--- releases/WebKitGTK/webkit-2.16/Source/WebCore/platform/gtk/PlatformKeyboardEventGtk.cpp 2017-03-13 09:43:57 UTC (rev 213794)
+++ releases/WebKitGTK/webkit-2.16/Source/WebCore/platform/gtk/PlatformKeyboardEventGtk.cpp 2017-03-13 09:46:34 UTC (rev 213795)
@@ -1266,6 +1266,7 @@
, m_code(keyCodeForHardwareKeyCode(event->hardware_keycode))
, m_keyIdentifier(keyIdentifierForGdkKeyCode(event->keyval))
, m_windowsVirtualKeyCode(windowsKeyCodeForGdkKeyCode(event->keyval))
+ , m_handledByInputMethod(false)
, m_autoRepeat(false)
, m_isKeypad(event->keyval >= GDK_KP_Space && event->keyval <= GDK_KP_9)
, m_isSystemKey(false)
Modified: releases/WebKitGTK/webkit-2.16/Source/WebCore/platform/gtk/PlatformMouseEventGtk.cpp (213794 => 213795)
--- releases/WebKitGTK/webkit-2.16/Source/WebCore/platform/gtk/PlatformMouseEventGtk.cpp 2017-03-13 09:43:57 UTC (rev 213794)
+++ releases/WebKitGTK/webkit-2.16/Source/WebCore/platform/gtk/PlatformMouseEventGtk.cpp 2017-03-13 09:46:34 UTC (rev 213795)
@@ -41,6 +41,7 @@
m_timestamp = event->time;
m_position = IntPoint((int)event->x, (int)event->y);
m_globalPosition = IntPoint((int)event->x_root, (int)event->y_root);
+ m_modifierFlags = 0;
if (event->state & GDK_SHIFT_MASK)
m_modifiers |= PlatformEvent::Modifier::ShiftKey;
@@ -87,6 +88,7 @@
m_timestamp = motion->time;
m_position = IntPoint((int)motion->x, (int)motion->y);
m_globalPosition = IntPoint((int)motion->x_root, (int)motion->y_root);
+ m_modifierFlags = 0;
if (motion->state & GDK_SHIFT_MASK)
m_modifiers |= PlatformEvent::Modifier::ShiftKey;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
