Title: [213799] releases/WebKitGTK/webkit-2.16/Source/_javascript_Core
Revision
213799
Author
[email protected]
Date
2017-03-13 02:54:47 -0700 (Mon, 13 Mar 2017)

Log Message

Merge r213275 - Incorrect RELEASE_ASSERT in JSGlobalObject::addStaticGlobals()
https://bugs.webkit.org/show_bug.cgi?id=169034

Reviewed by Mark Lam.

It should not assign to offset, but compare to offset.

* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::addStaticGlobals):

Modified Paths

Diff

Modified: releases/WebKitGTK/webkit-2.16/Source/_javascript_Core/ChangeLog (213798 => 213799)


--- releases/WebKitGTK/webkit-2.16/Source/_javascript_Core/ChangeLog	2017-03-13 09:49:20 UTC (rev 213798)
+++ releases/WebKitGTK/webkit-2.16/Source/_javascript_Core/ChangeLog	2017-03-13 09:54:47 UTC (rev 213799)
@@ -1,3 +1,15 @@
+2017-03-02  Tomas Popela  <[email protected]>
+
+        Incorrect RELEASE_ASSERT in JSGlobalObject::addStaticGlobals()
+        https://bugs.webkit.org/show_bug.cgi?id=169034
+
+        Reviewed by Mark Lam.
+
+        It should not assign to offset, but compare to offset.
+
+        * runtime/JSGlobalObject.cpp:
+        (JSC::JSGlobalObject::addStaticGlobals):
+
 2017-02-28  Saam Barati  <[email protected]>
 
         Arm64 disassembler prints "ars" instead of "asr"

Modified: releases/WebKitGTK/webkit-2.16/Source/_javascript_Core/runtime/JSGlobalObject.cpp (213798 => 213799)


--- releases/WebKitGTK/webkit-2.16/Source/_javascript_Core/runtime/JSGlobalObject.cpp	2017-03-13 09:49:20 UTC (rev 213798)
+++ releases/WebKitGTK/webkit-2.16/Source/_javascript_Core/runtime/JSGlobalObject.cpp	2017-03-13 09:54:47 UTC (rev 213799)
@@ -1316,7 +1316,7 @@
         {
             ConcurrentJSLocker locker(symbolTable()->m_lock);
             ScopeOffset offset = symbolTable()->takeNextScopeOffset(locker);
-            RELEASE_ASSERT(offset = startOffset + i);
+            RELEASE_ASSERT(offset == startOffset + i);
             SymbolTableEntry newEntry(VarOffset(offset), global.attributes);
             newEntry.prepareToWatch();
             watchpointSet = newEntry.watchpointSet();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to