Title: [213843] trunk/Source/WebKit2
Revision
213843
Author
[email protected]
Date
2017-03-13 07:04:37 -0700 (Mon, 13 Mar 2017)

Log Message

[cmake] [WK2] Guard flags intended for GCC-like compilers with COMPILER_IS_GCC_OR_CLANG
https://bugs.webkit.org/show_bug.cgi?id=169551

Reviewed by Yusuke Suzuki.

This change allows building WK2 code with MSVC.

* CMakeLists.txt:

Modified Paths

Diff

Modified: trunk/Source/WebKit2/CMakeLists.txt (213842 => 213843)


--- trunk/Source/WebKit2/CMakeLists.txt	2017-03-13 13:26:15 UTC (rev 213842)
+++ trunk/Source/WebKit2/CMakeLists.txt	2017-03-13 14:04:37 UTC (rev 213843)
@@ -794,12 +794,14 @@
 add_dependencies(WebKit2 WebCore ${WEBKIT2_EXTRA_DEPENDENCIES})
 add_webkit2_prefix_header(WebKit2)
 
-if (NOT APPLE)
+if (COMPILER_IS_GCC_OR_CLANG AND NOT APPLE)
     target_link_libraries(WebKit2 -Wl,--start-group WebCore WebCoreDerivedSources -Wl,--end-group)
 endif ()
 
 # Suppress unused parameter warnings for sources in WebKit2.
-ADD_TARGET_PROPERTIES(WebKit2 COMPILE_FLAGS "-Wno-unused-parameter")
+if (COMPILER_IS_GCC_OR_CLANG)
+    ADD_TARGET_PROPERTIES(WebKit2 COMPILE_FLAGS "-Wno-unused-parameter")
+endif ()
 
 if (WebKit2_VERSION_SCRIPT)
     ADD_TARGET_PROPERTIES(WebKit2 LINK_FLAGS "${WebKit2_VERSION_SCRIPT}")

Modified: trunk/Source/WebKit2/ChangeLog (213842 => 213843)


--- trunk/Source/WebKit2/ChangeLog	2017-03-13 13:26:15 UTC (rev 213842)
+++ trunk/Source/WebKit2/ChangeLog	2017-03-13 14:04:37 UTC (rev 213843)
@@ -1,3 +1,14 @@
+2017-03-13  Konstantin Tokarev  <[email protected]>
+
+        [cmake] [WK2] Guard flags intended for GCC-like compilers with COMPILER_IS_GCC_OR_CLANG
+        https://bugs.webkit.org/show_bug.cgi?id=169551
+
+        Reviewed by Yusuke Suzuki.
+
+        This change allows building WK2 code with MSVC.
+
+        * CMakeLists.txt:
+
 2017-03-13  Chris Dumez  <[email protected]>
 
         [WK2] Only report background WebProcesses as unresponsive in the background after 90 seconds
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to