Title: [99307] trunk/Source/WebCore
- Revision
- 99307
- Author
- [email protected]
- Date
- 2011-11-04 11:52:53 -0700 (Fri, 04 Nov 2011)
Log Message
RenderLayer::styleChanged invalidates the GraphicsLayer needlessly
https://bugs.webkit.org/show_bug.cgi?id=71517
Reviewed by Simon Fraser.
Unused code removal covered by existing tests.
The current code is invalidating the whole RenderLayerBacking as part of
a style change. However this is redundant with the repainting logic which
would invalidate only the necessary bits.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::styleChanged):
Remove the invalidation code as it duplicates and defeats the repaint logic.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (99306 => 99307)
--- trunk/Source/WebCore/ChangeLog 2011-11-04 18:38:20 UTC (rev 99306)
+++ trunk/Source/WebCore/ChangeLog 2011-11-04 18:52:53 UTC (rev 99307)
@@ -1,3 +1,20 @@
+2011-11-04 Julien Chaffraix <[email protected]>
+
+ RenderLayer::styleChanged invalidates the GraphicsLayer needlessly
+ https://bugs.webkit.org/show_bug.cgi?id=71517
+
+ Reviewed by Simon Fraser.
+
+ Unused code removal covered by existing tests.
+
+ The current code is invalidating the whole RenderLayerBacking as part of
+ a style change. However this is redundant with the repainting logic which
+ would invalidate only the necessary bits.
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::styleChanged):
+ Remove the invalidation code as it duplicates and defeats the repaint logic.
+
2011-11-04 Mihnea Ovidenie <[email protected]>
Correct parsing of incomplete @-webkit-region rules.
Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (99306 => 99307)
--- trunk/Source/WebCore/rendering/RenderLayer.cpp 2011-11-04 18:38:20 UTC (rev 99306)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp 2011-11-04 18:52:53 UTC (rev 99307)
@@ -4172,7 +4172,7 @@
|| renderer()->isRenderIFrame();
}
-void RenderLayer::styleChanged(StyleDifference diff, const RenderStyle* oldStyle)
+void RenderLayer::styleChanged(StyleDifference, const RenderStyle* oldStyle)
{
bool isNormalFlowOnly = shouldBeNormalFlowOnly();
if (isNormalFlowOnly != m_isNormalFlowOnly) {
@@ -4235,11 +4235,6 @@
if (stackingContext()->hasCompositingDescendant())
compositor()->setCompositingLayersNeedRebuild();
}
-
- if (m_backing && diff >= StyleDifferenceRepaint)
- m_backing->setContentsNeedDisplay();
-#else
- UNUSED_PARAM(diff);
#endif
}
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
