Title: [214004] trunk/Source/WebInspectorUI
- Revision
- 214004
- Author
- commit-qu...@webkit.org
- Date
- 2017-03-15 13:00:32 -0700 (Wed, 15 Mar 2017)
Log Message
JSContext Inspector: NetworkAgent may be unavailable
https://bugs.webkit.org/show_bug.cgi?id=169691
Patch by Joseph Pecoraro <pecor...@apple.com> on 2017-03-15
Reviewed by Brian Burg.
* UserInterface/Views/ResourceDetailsSidebarPanel.js:
(WebInspector.ResourceDetailsSidebarPanel.prototype._refreshRequestAndResponse):
Check that NetworkAgent even exists. An augmented JSContext may have Resources
without having a NetworkAgent.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (214003 => 214004)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-03-15 19:56:03 UTC (rev 214003)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-03-15 20:00:32 UTC (rev 214004)
@@ -1,3 +1,15 @@
+2017-03-15 Joseph Pecoraro <pecor...@apple.com>
+
+ JSContext Inspector: NetworkAgent may be unavailable
+ https://bugs.webkit.org/show_bug.cgi?id=169691
+
+ Reviewed by Brian Burg.
+
+ * UserInterface/Views/ResourceDetailsSidebarPanel.js:
+ (WebInspector.ResourceDetailsSidebarPanel.prototype._refreshRequestAndResponse):
+ Check that NetworkAgent even exists. An augmented JSContext may have Resources
+ without having a NetworkAgent.
+
2017-03-15 Nikita Vasilyev <nvasil...@apple.com>
REGRESSION (r213622): Web Inspector: DataGrid headers should NOT be centered
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ResourceDetailsSidebarPanel.js (214003 => 214004)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ResourceDetailsSidebarPanel.js 2017-03-15 19:56:03 UTC (rev 214003)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ResourceDetailsSidebarPanel.js 2017-03-15 20:00:32 UTC (rev 214004)
@@ -301,7 +301,7 @@
this._requestMethodRow.value = this._resource.requestMethod || emDash;
// COMPATIBILITY(iOS 10.3): Network load metrics were not previously available.
- if (NetworkAgent.hasEventParameter("loadingFinished", "metrics")) {
+ if (window.NetworkAgent && NetworkAgent.hasEventParameter("loadingFinished", "metrics")) {
this._protocolRow.value = this._resource.protocol || emDash;
switch (this._resource.priority) {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
