Title: [214083] trunk/Source/WebInspectorUI
Revision
214083
Author
[email protected]
Date
2017-03-16 17:23:45 -0700 (Thu, 16 Mar 2017)

Log Message

Web Inspector: REGRESSION (r213691): Saving DOM breakpoints broken after refactoring
https://bugs.webkit.org/show_bug.cgi?id=169779

Reviewed by Joseph Pecoraro.

Use correct method: _saveBreakpoints -> _saveDOMBreakpoints.

* UserInterface/Controllers/DOMDebuggerManager.js:
(WebInspector.DOMDebuggerManager.prototype.addDOMBreakpoint):
Remove check before saving to be consistent with similar code in
DebuggerManager and DOMDebuggerManager.

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (214082 => 214083)


--- trunk/Source/WebInspectorUI/ChangeLog	2017-03-17 00:20:45 UTC (rev 214082)
+++ trunk/Source/WebInspectorUI/ChangeLog	2017-03-17 00:23:45 UTC (rev 214083)
@@ -1,3 +1,17 @@
+2017-03-16  Matt Baker  <[email protected]>
+
+        Web Inspector: REGRESSION (r213691): Saving DOM breakpoints broken after refactoring
+        https://bugs.webkit.org/show_bug.cgi?id=169779
+
+        Reviewed by Joseph Pecoraro.
+
+        Use correct method: _saveBreakpoints -> _saveDOMBreakpoints.
+
+        * UserInterface/Controllers/DOMDebuggerManager.js:
+        (WebInspector.DOMDebuggerManager.prototype.addDOMBreakpoint):
+        Remove check before saving to be consistent with similar code in
+        DebuggerManager and DOMDebuggerManager.
+
 2017-03-16  Devin Rousso  <[email protected]>
 
         Web Inspector: add "Save Selected" context menu item to Console

Modified: trunk/Source/WebInspectorUI/UserInterface/Controllers/DOMDebuggerManager.js (214082 => 214083)


--- trunk/Source/WebInspectorUI/UserInterface/Controllers/DOMDebuggerManager.js	2017-03-17 00:20:45 UTC (rev 214082)
+++ trunk/Source/WebInspectorUI/UserInterface/Controllers/DOMDebuggerManager.js	2017-03-17 00:23:45 UTC (rev 214083)
@@ -151,8 +151,7 @@
 
         this.dispatchEventToListeners(WebInspector.DOMDebuggerManager.Event.DOMBreakpointAdded, {breakpoint});
 
-        if (!this._restoringBreakpoints)
-            this._saveBreakpoints();
+        this._saveDOMBreakpoints();
     }
 
     removeDOMBreakpoint(breakpoint)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to