Title: [214104] trunk/Source/WebKit2
- Revision
- 214104
- Author
- [email protected]
- Date
- 2017-03-17 06:13:02 -0700 (Fri, 17 Mar 2017)
Log Message
Fix uninitialized public members in WebProcess
https://bugs.webkit.org/show_bug.cgi?id=169604
Reviewed by Michael Catanzaro.
Found by Coverity scan.
* WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h:
* WebProcess/InjectedBundle/InjectedBundleNavigationAction.h:
* WebProcess/Plugins/Netscape/NetscapePlugin.h:
* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePluginX11::NetscapePluginX11):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (214103 => 214104)
--- trunk/Source/WebKit2/ChangeLog 2017-03-17 12:22:10 UTC (rev 214103)
+++ trunk/Source/WebKit2/ChangeLog 2017-03-17 13:13:02 UTC (rev 214104)
@@ -1,5 +1,20 @@
2017-03-17 Tomas Popela <[email protected]>
+ Fix uninitialized public members in WebProcess
+ https://bugs.webkit.org/show_bug.cgi?id=169604
+
+ Reviewed by Michael Catanzaro.
+
+ Found by Coverity scan.
+
+ * WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h:
+ * WebProcess/InjectedBundle/InjectedBundleNavigationAction.h:
+ * WebProcess/Plugins/Netscape/NetscapePlugin.h:
+ * WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
+ (WebKit::NetscapePluginX11::NetscapePluginX11):
+
+2017-03-17 Tomas Popela <[email protected]>
+
Fix uninitialized public members in NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=169598
Modified: trunk/Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h (214103 => 214104)
--- trunk/Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h 2017-03-17 12:22:10 UTC (rev 214103)
+++ trunk/Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h 2017-03-17 13:13:02 UTC (rev 214104)
@@ -112,7 +112,7 @@
IPC::Connection* messageSenderConnection() final;
- uint64_t m_identifier;
+ uint64_t m_identifier { 0 };
bool m_isOpenInServer { false };
RefPtr<WebCore::IDBClient::IDBConnectionToServer> m_connectionToServer;
};
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleNavigationAction.h (214103 => 214104)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleNavigationAction.h 2017-03-17 12:22:10 UTC (rev 214103)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleNavigationAction.h 2017-03-17 13:13:02 UTC (rev 214104)
@@ -68,7 +68,7 @@
WebCore::NavigationType m_navigationType;
WebEvent::Modifiers m_modifiers;
WebMouseEvent::Button m_mouseButton;
- WebMouseEvent::SyntheticClickType m_syntheticClickType;
+ WebMouseEvent::SyntheticClickType m_syntheticClickType { WebMouseEvent::NoTap };
RefPtr<InjectedBundleHitTestResult> m_hitTestResult;
RefPtr<InjectedBundleNodeHandle> m_formElement;
AtomicString m_downloadAttribute;
Modified: trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h (214103 => 214104)
--- trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h 2017-03-17 12:22:10 UTC (rev 214103)
+++ trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h 2017-03-17 13:13:02 UTC (rev 214104)
@@ -344,8 +344,8 @@
TimerMap m_timers;
unsigned m_nextTimerID;
- bool m_privateBrowsingState;
- bool m_storageBlockingState;
+ bool m_privateBrowsingState { false };
+ bool m_storageBlockingState { false };
#if PLUGIN_ARCHITECTURE(MAC)
NPDrawingModel m_drawingModel;
Modified: trunk/Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp (214103 => 214104)
--- trunk/Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp 2017-03-17 12:22:10 UTC (rev 214103)
+++ trunk/Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp 2017-03-17 13:13:02 UTC (rev 214104)
@@ -166,6 +166,7 @@
Visual* visual = visualInfo.get()[0].visual;
ASSERT(visual);
+ m_setWindowCallbackStruct.type = NP_SETWINDOW;
m_setWindowCallbackStruct.visual = visual;
m_setWindowCallbackStruct.colormap = XCreateColormap(hostDisplay, rootWindowID(), visual, AllocNone);
}
@@ -195,6 +196,7 @@
Display* hostDisplay = x11HostDisplay();
m_npWindowID = gtk_socket_get_id(GTK_SOCKET(socket));
GdkWindow* window = gtk_widget_get_window(socket);
+ m_setWindowCallbackStruct.type = NP_SETWINDOW;
m_setWindowCallbackStruct.display = GDK_WINDOW_XDISPLAY(window);
m_setWindowCallbackStruct.visual = GDK_VISUAL_XVISUAL(gdk_window_get_visual(window));
m_setWindowCallbackStruct.depth = gdk_visual_get_depth(gdk_window_get_visual(window));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
