Title: [214308] trunk/Source/WebInspectorUI
- Revision
- 214308
- Author
- [email protected]
- Date
- 2017-03-23 11:47:49 -0700 (Thu, 23 Mar 2017)
Log Message
Web Inspector: Editing local storage keys/values starts with truncated strings
https://bugs.webkit.org/show_bug.cgi?id=169896
Reviewed by Brian Burg.
* UserInterface/Views/DataGrid.css:
(.data-grid td.editing > div):
* UserInterface/Views/DataGrid.js:
(WebInspector.DataGrid.prototype._editingCancelled):
div.cell-content is removed because the <td> itself is contenteditable (using -webkit-user-modify:read-write-plaintext-only),
not the inner div.cell-content. Re-create div.cell-content after commiting (by pressing Enter) or canceling (by pressing Esc)
since it may get removed while editing.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (214307 => 214308)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-03-23 18:45:50 UTC (rev 214307)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-03-23 18:47:49 UTC (rev 214308)
@@ -1,3 +1,18 @@
+2017-03-23 Nikita Vasilyev <[email protected]>
+
+ Web Inspector: Editing local storage keys/values starts with truncated strings
+ https://bugs.webkit.org/show_bug.cgi?id=169896
+
+ Reviewed by Brian Burg.
+
+ * UserInterface/Views/DataGrid.css:
+ (.data-grid td.editing > div):
+ * UserInterface/Views/DataGrid.js:
+ (WebInspector.DataGrid.prototype._editingCancelled):
+ div.cell-content is removed because the <td> itself is contenteditable (using -webkit-user-modify:read-write-plaintext-only),
+ not the inner div.cell-content. Re-create div.cell-content after commiting (by pressing Enter) or canceling (by pressing Esc)
+ since it may get removed while editing.
+
2017-03-22 Matt Baker <[email protected]>
Web Inspector: Clicking DOM breakpoint marker should enable/disable breakpoints
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.css (214307 => 214308)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.css 2017-03-23 18:45:50 UTC (rev 214307)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.css 2017-03-23 18:47:49 UTC (rev 214308)
@@ -204,6 +204,11 @@
overflow: hidden;
}
+/* FIXME: Remove this once <https://webkit.org/b/169972> is fixed. */
+.data-grid td.editing > div {
+ text-overflow: clip;
+}
+
.data-grid .centered div {
text-align: center;
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js (214307 => 214308)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js 2017-03-23 18:45:50 UTC (rev 214307)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.js 2017-03-23 18:47:49 UTC (rev 214308)
@@ -603,6 +603,9 @@
_editingCancelled(element)
{
console.assert(this._editingNode.element === element.enclosingNodeOrSelfWithNodeName("tr"));
+
+ this._editingNode.refresh();
+
this._editing = false;
this._editingNode = null;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
