Title: [214368] trunk
- Revision
- 214368
- Author
- [email protected]
- Date
- 2017-03-24 12:43:42 -0700 (Fri, 24 Mar 2017)
Log Message
Add support for qpSum in WebRTC stats
https://bugs.webkit.org/show_bug.cgi?id=170060
Patch by Youenn Fablet <[email protected]> on 2017-03-24
Reviewed by Eric Carlson.
Source/WebCore:
* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
(WebCore::fillRTCRTPStreamStats): exposing libwebrtc qpSum value.
LayoutTests:
* webrtc/video-stats.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (214367 => 214368)
--- trunk/LayoutTests/ChangeLog 2017-03-24 19:41:38 UTC (rev 214367)
+++ trunk/LayoutTests/ChangeLog 2017-03-24 19:43:42 UTC (rev 214368)
@@ -1,3 +1,12 @@
+2017-03-24 Youenn Fablet <[email protected]>
+
+ Add support for qpSum in WebRTC stats
+ https://bugs.webkit.org/show_bug.cgi?id=170060
+
+ Reviewed by Eric Carlson.
+
+ * webrtc/video-stats.html:
+
2017-03-24 Daniel Bates <[email protected]>
Prevent new navigations during document unload
Modified: trunk/LayoutTests/webrtc/video-stats.html (214367 => 214368)
--- trunk/LayoutTests/webrtc/video-stats.html 2017-03-24 19:41:38 UTC (rev 214367)
+++ trunk/LayoutTests/webrtc/video-stats.html 2017-03-24 19:43:42 UTC (rev 214368)
@@ -36,18 +36,6 @@
});
}
-function testStatsTwice(firstConnection, secondConnection)
-{
- return Promise.all([
- firstConnection.getStats().then((report) => {
- firstReportB = report;
- }),
- secondConnection.getStats().then((report) => {
- secondReportB = report;
- })
- ]);
-}
-
var firstConnection, secondConnection;
promise_test((test) => {
if (window.testRunner)
@@ -77,11 +65,13 @@
}).then((stats) => {
assert_true(!!stats, "outbound-rtp stats should not be null");
assert_true(Number.isInteger(stats.framesEncoded), "framesEncoded should be an integer");
+ assert_true(Number.isInteger(stats.qpSum), "outbound qpSum should be an integer");
statsFirstConnection = stats;
return getInboundRTPStats(secondConnection);
}).then((stats) => {
assert_true(!!stats, "inbound-rtp stats should not be null");
assert_true(Number.isInteger(stats.framesDecoded), "framesDecoded should be an integer");
+ assert_true(Number.isInteger(stats.qpSum), "inbound qpSum should be an integer");
statsSecondConnection = stats;
return waitFor(300);
}).then(() => {
@@ -89,6 +79,7 @@
}).then((stats) => {
assert_true(stats.timestamp > statsFirstConnection.timestamp, "Timestamp for first connection should have increased");
assert_true(stats.framesEncoded > statsFirstConnection.framesEncoded, "Number of encoded frames should have increased");
+
return getInboundRTPStats(secondConnection);
}).then((stats) => {
assert_true(stats.timestamp > statsSecondConnection.timestamp, "Timestamp for second connection should have increased");
Modified: trunk/Source/WebCore/ChangeLog (214367 => 214368)
--- trunk/Source/WebCore/ChangeLog 2017-03-24 19:41:38 UTC (rev 214367)
+++ trunk/Source/WebCore/ChangeLog 2017-03-24 19:43:42 UTC (rev 214368)
@@ -1,3 +1,13 @@
+2017-03-24 Youenn Fablet <[email protected]>
+
+ Add support for qpSum in WebRTC stats
+ https://bugs.webkit.org/show_bug.cgi?id=170060
+
+ Reviewed by Eric Carlson.
+
+ * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
+ (WebCore::fillRTCRTPStreamStats): exposing libwebrtc qpSum value.
+
2017-03-24 Daniel Bates <[email protected]>
Prevent new navigations during document unload
Modified: trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp (214367 => 214368)
--- trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp 2017-03-24 19:41:38 UTC (rev 214367)
+++ trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp 2017-03-24 19:43:42 UTC (rev 214368)
@@ -268,7 +268,8 @@
stats.nackCount = *rtcStats.nack_count;
if (rtcStats.sli_count.is_defined())
stats.sliCount = *rtcStats.sli_count;
- // FIXME: Set qpSum
+ if (rtcStats.qp_sum.is_defined())
+ stats.qpSum = *rtcStats.qp_sum;
stats.qpSum = 0;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
