Title: [214444] trunk/Source/WebKit2
- Revision
- 214444
- Author
- [email protected]
- Date
- 2017-03-27 17:16:09 -0700 (Mon, 27 Mar 2017)
Log Message
Update NetworkResourceLoader logging statement
https://bugs.webkit.org/show_bug.cgi?id=170126
Reviewed by Alex Christensen.
NetworkResourceLoader contains a logging statement that prints, in
part: "start: Retrieving resource from cache". This is misleading,
since it's not necessarily the case that the resource will be loaded
from the cache. What is actually happening at the point where that is
logged is that the cache is being checked for the resource. It still
remains to be seen if the resource will be found in it. To address
this, change the logging to say "start: Checking cache for resource".
* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::start):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (214443 => 214444)
--- trunk/Source/WebKit2/ChangeLog 2017-03-28 00:06:28 UTC (rev 214443)
+++ trunk/Source/WebKit2/ChangeLog 2017-03-28 00:16:09 UTC (rev 214444)
@@ -1,3 +1,21 @@
+2017-03-27 Keith Rollin <[email protected]>
+
+ Update NetworkResourceLoader logging statement
+ https://bugs.webkit.org/show_bug.cgi?id=170126
+
+ Reviewed by Alex Christensen.
+
+ NetworkResourceLoader contains a logging statement that prints, in
+ part: "start: Retrieving resource from cache". This is misleading,
+ since it's not necessarily the case that the resource will be loaded
+ from the cache. What is actually happening at the point where that is
+ logged is that the cache is being checked for the resource. It still
+ remains to be seen if the resource will be found in it. To address
+ this, change the logging to say "start: Checking cache for resource".
+
+ * NetworkProcess/NetworkResourceLoader.cpp:
+ (WebKit::NetworkResourceLoader::start):
+
2017-03-27 Joseph Pecoraro <[email protected]>
Web Inspector: Saving files should not suggest the top level directory
Modified: trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp (214443 => 214444)
--- trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp 2017-03-28 00:06:28 UTC (rev 214443)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkResourceLoader.cpp 2017-03-28 00:16:09 UTC (rev 214444)
@@ -163,7 +163,7 @@
#if ENABLE(NETWORK_CACHE)
if (canUseCache(originalRequest())) {
- RELEASE_LOG_IF_ALLOWED("start: Retrieving resource from cache (pageID = %" PRIu64 ", frameID = %" PRIu64 ", resourceID = %" PRIu64 ", isMainResource = %d, isSynchronous = %d)", m_parameters.webPageID, m_parameters.webFrameID, m_parameters.identifier, isMainResource(), isSynchronous());
+ RELEASE_LOG_IF_ALLOWED("start: Checking cache for resource (pageID = %" PRIu64 ", frameID = %" PRIu64 ", resourceID = %" PRIu64 ", isMainResource = %d, isSynchronous = %d)", m_parameters.webPageID, m_parameters.webFrameID, m_parameters.identifier, isMainResource(), isSynchronous());
retrieveCacheEntry(originalRequest());
return;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
