Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js (214469 => 214470)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js 2017-03-28 07:49:56 UTC (rev 214469)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js 2017-03-28 09:33:21 UTC (rev 214470)
@@ -167,6 +167,13 @@
};
this.queue.branches = [this.trunkBranch];
this.view = new MockBuildbotQueueView([this.queue]);
+ this.view._latestProductiveIteration = function(queue)
+ {
+ var iteration = {
+ revision: { "openSource": "33021" },
+ };
+ return iteration;
+ }
}
});
@@ -173,7 +180,7 @@
var settings = new Settings;
test("_appendPendingRevisionCount", function()
{
- this.view._appendPendingRevisionCount(this.queue);
+ this.view._appendPendingRevisionCount(this.queue, this.view._latestProductiveIteration);
var revisionsBehind = this.view.element.getElementsByClassName("message")[0].innerHTML.match(/.*(\d+) revision(|s) behind/)[1];
strictEqual(revisionsBehind, "1", "assert revisions behind");
});
@@ -188,7 +195,7 @@
{
var element = document.createElement("div");
var popover = new Dashboard.Popover();
- this.view._presentPopoverForPendingCommits(element, popover, this.queue);
+ this.view._presentPopoverForPendingCommits(this.view._latestProductiveIteration, element, popover, this.queue);
var nodeList = popover._element.getElementsByClassName("pending-commit");
strictEqual(nodeList.length, 1, "has 1 pending commit");
});
@@ -204,16 +211,9 @@
}
};
this.queue.branches = [this.someOtherBranch];
- this.view._latestProductiveIteration = function(queue)
- {
- var iteration = {
- revision: { "openSource": "33021" },
- };
- return iteration;
- };
var element = document.createElement("div");
var popover = new Dashboard.Popover();
- this.view._presentPopoverForPendingCommits(element, popover, this.queue);
+ this.view._presentPopoverForPendingCommits(this.view._latestProductiveIteration, element, popover, this.queue);
var nodeList = popover._element.getElementsByClassName("pending-commit");
strictEqual(nodeList.length, 0, "has 0 pending commits");
});
Modified: trunk/Tools/ChangeLog (214469 => 214470)
--- trunk/Tools/ChangeLog 2017-03-28 07:49:56 UTC (rev 214469)
+++ trunk/Tools/ChangeLog 2017-03-28 09:33:21 UTC (rev 214470)
@@ -1,3 +1,13 @@
+2017-03-28 Aakash Jain <[email protected]>
+
+ Dashboard test fails with error: latestIterationGetter is not a function
+ https://bugs.webkit.org/show_bug.cgi?id=170167
+
+ Reviewed by Alexey Proskuryakov.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
+ (this.view._latestProductiveIteration): Configure _latestProductiveIteration in setup.
+
2017-03-27 Lucas Forschler <[email protected]>
Another test v8.
