- Revision
- 214512
- Author
- [email protected]
- Date
- 2017-03-28 18:31:29 -0700 (Tue, 28 Mar 2017)
Log Message
Fix dashboard test results on the dashboard
https://bugs.webkit.org/show_bug.cgi?id=170158
Reviewed by Tim Horton.
Link to result diff instead of stdio. Looking at the diff, I wonder if it can be
further improved, as it's not super readable, but stdio is entirely useless in this context.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
(Buildbot.prototype.dashboardTestResultsURLForIteration): Generate formatted diff link.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
Fixed a typo in step name, so that it's actually treated as productive.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView.prototype.appendBuilderQueueStatus):
(BuildbotTesterQueueView.prototype.update):
(BuildbotTesterQueueView.prototype._presentPopoverForGenericTestFailures):
Added special handling for dashboard test results.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js (214511 => 214512)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js 2017-03-29 01:14:49 UTC (rev 214511)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js 2017-03-29 01:31:29 UTC (rev 214512)
@@ -179,6 +179,11 @@
return this.layoutTestResultsDirectoryURLForIteration(iteration) + "/results.html";
},
+ dashboardTestResultsURLForIteration: function(iteration)
+ {
+ return this.layoutTestResultsDirectoryURLForIteration(iteration) + "/dashboard-layout-test-results/index-pretty-diff.html";
+ },
+
layoutTestFullResultsURLForIteration: function(iteration)
{
return this.layoutTestResultsDirectoryURLForIteration(iteration) + "/full_results.json";
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js (214511 => 214512)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js 2017-03-29 01:14:49 UTC (rev 214511)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js 2017-03-29 01:31:29 UTC (rev 214512)
@@ -81,7 +81,7 @@
"layout-test": "layout test",
"perf-test": "performance test",
"run-api-tests": "api test",
- "run-dashboard-tests": "dashboard test",
+ "dashboard-tests": "dashboard test",
"webkit-32bit-jsc-test": "_javascript_ test",
"webkit-jsc-cloop-test": "_javascript_ cloop test",
"webkitperl-test": "webkitperl test",
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js (214511 => 214512)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js 2017-03-29 01:14:49 UTC (rev 214511)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js 2017-03-29 01:31:29 UTC (rev 214512)
@@ -108,6 +108,9 @@
} else if (/(?=.*test)(?=.*jsc)/.test(failedStep.name)) {
var status = new StatusLineView(messageElement, StatusLineView.Status.Bad, this._testStepFailureDescription(failedStep), failedStep.failureCount, iteration.queue.buildbot._javascript_CoreTestStdioUrlForIteration(iteration, failedStep.name));
new PopoverTracker(status.statusBubbleElement, this._presentPopoverForJavaScriptCoreTestRegressions.bind(this, failedStep.name), iteration);
+ } else if (failedStep.name === "dashboard-tests") {
+ var status = new StatusLineView(messageElement, StatusLineView.Status.Bad, this._testStepFailureDescription(failedStep), undefined, iteration.queue.buildbot.dashboardTestResultsURLForIteration(iteration));
+ new PopoverTracker(status.statusBubbleElement, this._presentPopoverForGenericTestFailures.bind(this), iteration);
} else {
var status = new StatusLineView(messageElement, StatusLineView.Status.Bad, this._testStepFailureDescription(failedStep), failedStep.failureCount ? failedStep.failureCount : undefined, failedStep.URL);
new PopoverTracker(status.statusBubbleElement, this._presentPopoverForGenericTestFailures.bind(this), iteration);
@@ -252,6 +255,8 @@
iteration.failedTestSteps.forEach(function(failedStep) {
if (failedStep.name === "layout-test")
addResultKind(this._testStepFailureDescriptionWithCount(failedStep), iteration.queue.buildbot.layoutTestResultsURLForIteration(iteration));
+ if (failedStep.name === "dashboard-tests")
+ addResultKind(this._testStepFailureDescription(failedStep), iteration.queue.buildbot.dashboardTestResultsURLForIteration(iteration));
else
addResultKind(this._testStepFailureDescriptionWithCount(failedStep), failedStep.URL);
}, this);
Modified: trunk/Tools/ChangeLog (214511 => 214512)
--- trunk/Tools/ChangeLog 2017-03-29 01:14:49 UTC (rev 214511)
+++ trunk/Tools/ChangeLog 2017-03-29 01:31:29 UTC (rev 214512)
@@ -1,3 +1,25 @@
+2017-03-28 Alexey Proskuryakov <[email protected]>
+
+ Fix dashboard test results on the dashboard
+ https://bugs.webkit.org/show_bug.cgi?id=170158
+
+ Reviewed by Tim Horton.
+
+ Link to result diff instead of stdio. Looking at the diff, I wonder if it can be
+ further improved, as it's not super readable, but stdio is entirely useless in this context.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
+ (Buildbot.prototype.dashboardTestResultsURLForIteration): Generate formatted diff link.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
+ Fixed a typo in step name, so that it's actually treated as productive.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
+ (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus):
+ (BuildbotTesterQueueView.prototype.update):
+ (BuildbotTesterQueueView.prototype._presentPopoverForGenericTestFailures):
+ Added special handling for dashboard test results.
+
2017-03-28 Aakash Jain <[email protected]>
Fix Dashboard test _presentPopoverForJavaScriptCoreTestRegressions
