Title: [214551] trunk/Source/WebInspectorUI
- Revision
- 214551
- Author
- commit-qu...@webkit.org
- Date
- 2017-03-29 11:57:52 -0700 (Wed, 29 Mar 2017)
Log Message
Web Inspector: Network tab content view is blank after reload
https://bugs.webkit.org/show_bug.cgi?id=168029
Patch by Sam Brodkin <i...@apple.com> on 2017-03-29
Reviewed by Brian Burg.
* UserInterface/Views/NetworkSidebarPanel.js:
(WebInspector.NetworkSidebarPanel.prototype._networkTimelineReset):
showDefaultContentView() which shows networkGridView in the contentView was not being called
when the NetworkSidebarPanel was not visible. Removing the if statement always shows the
networkGridView which fixes the bug. This wouldn't be easy to regression test.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (214550 => 214551)
--- trunk/Source/WebInspectorUI/ChangeLog 2017-03-29 18:44:57 UTC (rev 214550)
+++ trunk/Source/WebInspectorUI/ChangeLog 2017-03-29 18:57:52 UTC (rev 214551)
@@ -1,3 +1,16 @@
+2017-03-29 Sam Brodkin <i...@apple.com>
+
+ Web Inspector: Network tab content view is blank after reload
+ https://bugs.webkit.org/show_bug.cgi?id=168029
+
+ Reviewed by Brian Burg.
+
+ * UserInterface/Views/NetworkSidebarPanel.js:
+ (WebInspector.NetworkSidebarPanel.prototype._networkTimelineReset):
+ showDefaultContentView() which shows networkGridView in the contentView was not being called
+ when the NetworkSidebarPanel was not visible. Removing the if statement always shows the
+ networkGridView which fixes the bug. This wouldn't be easy to regression test.
+
2017-03-28 Brian Burg <bb...@apple.com>
Web Inspector: RTL: keyboard shortcuts with directionality need to be flipped (forward/back, etc)
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NetworkSidebarPanel.js (214550 => 214551)
--- trunk/Source/WebInspectorUI/UserInterface/Views/NetworkSidebarPanel.js 2017-03-29 18:44:57 UTC (rev 214550)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NetworkSidebarPanel.js 2017-03-29 18:57:52 UTC (rev 214551)
@@ -191,9 +191,7 @@
_networkTimelineReset(event)
{
this.contentBrowser.contentViewContainer.closeAllContentViews();
-
- if (this.visible)
- this.showDefaultContentView();
+ this.showDefaultContentView();
}
_contentBrowserCurrentContentViewDidChange(event)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
