Title: [214622] trunk/Tools
- Revision
- 214622
- Author
- [email protected]
- Date
- 2017-03-30 14:10:54 -0700 (Thu, 30 Mar 2017)
Log Message
[Win] Pass close_fds = True in Python popen call.
https://bugs.webkit.org/show_bug.cgi?id=170172
Reviewed by Brent Fulgham.
This was previously not supported on Windows, but in Python 2.7.10 it is.
* Scripts/webkitpy/common/system/executive.py:
(Executive._should_close_fds):
* Scripts/webkitpy/port/server_process.py:
(ServerProcess._start):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (214621 => 214622)
--- trunk/Tools/ChangeLog 2017-03-30 21:05:58 UTC (rev 214621)
+++ trunk/Tools/ChangeLog 2017-03-30 21:10:54 UTC (rev 214622)
@@ -1,3 +1,17 @@
+2017-03-30 Per Arne Vollan <[email protected]>
+
+ [Win] Pass close_fds = True in Python popen call.
+ https://bugs.webkit.org/show_bug.cgi?id=170172
+
+ Reviewed by Brent Fulgham.
+
+ This was previously not supported on Windows, but in Python 2.7.10 it is.
+
+ * Scripts/webkitpy/common/system/executive.py:
+ (Executive._should_close_fds):
+ * Scripts/webkitpy/port/server_process.py:
+ (ServerProcess._start):
+
2017-03-30 Aakash Jain <[email protected]>
Change my status to be a WebKit reviewer.
Modified: trunk/Tools/Scripts/webkitpy/common/system/executive.py (214621 => 214622)
--- trunk/Tools/Scripts/webkitpy/common/system/executive.py 2017-03-30 21:05:58 UTC (rev 214621)
+++ trunk/Tools/Scripts/webkitpy/common/system/executive.py 2017-03-30 21:10:54 UTC (rev 214622)
@@ -91,9 +91,8 @@
# We need to pass close_fds=True to work around Python bug #2320
# (otherwise we can hang when we kill DumpRenderTree when we are running
# multiple threads). See http://bugs.python.org/issue2320 .
- # Note that close_fds isn't supported on Windows, but this bug only
- # shows up on Mac and Linux.
- return not (sys.platform == 'cygwin' or sys.platform.startswith('win'))
+ # In Python 2.7.10, close_fds is also supported on Windows.
+ return True
def _run_command_with_teed_output(self, args, teed_output, **kwargs):
child_process = self.popen(args,
Modified: trunk/Tools/Scripts/webkitpy/port/server_process.py (214621 => 214622)
--- trunk/Tools/Scripts/webkitpy/port/server_process.py 2017-03-30 21:05:58 UTC (rev 214621)
+++ trunk/Tools/Scripts/webkitpy/port/server_process.py 2017-03-30 21:10:54 UTC (rev 214622)
@@ -114,7 +114,8 @@
raise ValueError("%s already running" % self._name)
self._reset()
# close_fds is a workaround for http://bugs.python.org/issue2320
- close_fds = not self._host.platform.is_win()
+ # In Python 2.7.10, close_fds is also supported on Windows.
+ close_fds = True
self._proc = self._host.executive.popen(self._cmd, stdin=self._host.executive.PIPE,
stdout=self._host.executive.PIPE,
stderr=self._host.executive.PIPE,
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
