Title: [214626] trunk/LayoutTests
Revision
214626
Author
[email protected]
Date
2017-03-30 14:35:39 -0700 (Thu, 30 Mar 2017)

Log Message

svg/animations/animations-paused-in-background-page.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=170290

Reviewed by Simon Fraser.

Fix shouldBecomeEqual() check in the test which was wrong and was passing by chance
due to a race.

* svg/animations/animations-paused-in-background-page-expected.txt:
* svg/animations/animations-paused-in-background-page.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (214625 => 214626)


--- trunk/LayoutTests/ChangeLog	2017-03-30 21:33:08 UTC (rev 214625)
+++ trunk/LayoutTests/ChangeLog	2017-03-30 21:35:39 UTC (rev 214626)
@@ -1,3 +1,16 @@
+2017-03-30  Chris Dumez  <[email protected]>
+
+        svg/animations/animations-paused-in-background-page.html is flaky
+        https://bugs.webkit.org/show_bug.cgi?id=170290
+
+        Reviewed by Simon Fraser.
+
+        Fix shouldBecomeEqual() check in the test which was wrong and was passing by chance
+        due to a race.
+
+        * svg/animations/animations-paused-in-background-page-expected.txt:
+        * svg/animations/animations-paused-in-background-page.html:
+
 2017-03-30  Javier Fernandez  <[email protected]>
 
         [css-align] Adapt content-alignment properties to the new baseline syntax

Modified: trunk/LayoutTests/svg/animations/animations-paused-in-background-page-expected.txt (214625 => 214626)


--- trunk/LayoutTests/svg/animations/animations-paused-in-background-page-expected.txt	2017-03-30 21:33:08 UTC (rev 214625)
+++ trunk/LayoutTests/svg/animations/animations-paused-in-background-page-expected.txt	2017-03-30 21:35:39 UTC (rev 214626)
@@ -7,7 +7,7 @@
 Setting page visibility to hidden
 PASS internals.isImageAnimating(testImage) became false
 Setting page visibility to visible
-PASS internals.isImageAnimating(testImage) became false
+PASS internals.isImageAnimating(testImage) became true
 PASS successfullyParsed is true
 
 TEST COMPLETE

Modified: trunk/LayoutTests/svg/animations/animations-paused-in-background-page.html (214625 => 214626)


--- trunk/LayoutTests/svg/animations/animations-paused-in-background-page.html	2017-03-30 21:33:08 UTC (rev 214625)
+++ trunk/LayoutTests/svg/animations/animations-paused-in-background-page.html	2017-03-30 21:35:39 UTC (rev 214626)
@@ -11,7 +11,7 @@
     debug("Setting page visibility to visible");
     if (window.testRunner)
         testRunner.setPageVisibility('visible');
-    shouldBecomeEqual("internals.isImageAnimating(testImage)", "false", finishJSTest);
+    shouldBecomeEqual("internals.isImageAnimating(testImage)", "true", finishJSTest);
 }
 
 window._onload_ = function() {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to